chore: pr feedbacks
This commit is contained in:
parent
a558b46b0e
commit
c8eecb1c5d
3 changed files with 5 additions and 8 deletions
|
|
@ -129,6 +129,7 @@ export function NotificationsPage() {
|
||||||
<SelectItem value="ntfy">Ntfy</SelectItem>
|
<SelectItem value="ntfy">Ntfy</SelectItem>
|
||||||
<SelectItem value="pushover">Pushover</SelectItem>
|
<SelectItem value="pushover">Pushover</SelectItem>
|
||||||
<SelectItem value="telegram">Telegram</SelectItem>
|
<SelectItem value="telegram">Telegram</SelectItem>
|
||||||
|
<SelectItem value="generic">Generic</SelectItem>
|
||||||
<SelectItem value="custom">Custom</SelectItem>
|
<SelectItem value="custom">Custom</SelectItem>
|
||||||
</SelectContent>
|
</SelectContent>
|
||||||
</Select>
|
</Select>
|
||||||
|
|
|
||||||
|
|
@ -97,10 +97,8 @@ export function RepositoriesPage() {
|
||||||
...listRepositoriesOptions(),
|
...listRepositoriesOptions(),
|
||||||
});
|
});
|
||||||
|
|
||||||
const repositories = data as RepositoryRow[];
|
|
||||||
|
|
||||||
const table = useReactTable({
|
const table = useReactTable({
|
||||||
data: repositories,
|
data,
|
||||||
columns: repositoryColumns,
|
columns: repositoryColumns,
|
||||||
state: { columnFilters, sorting },
|
state: { columnFilters, sorting },
|
||||||
onColumnFiltersChange: setColumnFilters,
|
onColumnFiltersChange: setColumnFilters,
|
||||||
|
|
@ -114,7 +112,7 @@ export function RepositoriesPage() {
|
||||||
|
|
||||||
const clearFilters = () => table.resetColumnFilters();
|
const clearFilters = () => table.resetColumnFilters();
|
||||||
|
|
||||||
const hasNoRepositories = repositories.length === 0;
|
const hasNoRepositories = data.length === 0;
|
||||||
const hasNoFilteredRepositories = rows.length === 0 && !hasNoRepositories;
|
const hasNoFilteredRepositories = rows.length === 0 && !hasNoRepositories;
|
||||||
|
|
||||||
if (hasNoRepositories) {
|
if (hasNoRepositories) {
|
||||||
|
|
|
||||||
|
|
@ -77,10 +77,8 @@ export function VolumesPage() {
|
||||||
const navigate = useNavigate();
|
const navigate = useNavigate();
|
||||||
const { data } = useSuspenseQuery({ ...listVolumesOptions() });
|
const { data } = useSuspenseQuery({ ...listVolumesOptions() });
|
||||||
|
|
||||||
const volumes = data as VolumeRow[];
|
|
||||||
|
|
||||||
const table = useReactTable({
|
const table = useReactTable({
|
||||||
data: volumes,
|
data,
|
||||||
columns: volumeColumns,
|
columns: volumeColumns,
|
||||||
state: { columnFilters, sorting },
|
state: { columnFilters, sorting },
|
||||||
onColumnFiltersChange: setColumnFilters,
|
onColumnFiltersChange: setColumnFilters,
|
||||||
|
|
@ -95,7 +93,7 @@ export function VolumesPage() {
|
||||||
|
|
||||||
const clearFilters = () => table.resetColumnFilters();
|
const clearFilters = () => table.resetColumnFilters();
|
||||||
|
|
||||||
const hasNoVolumes = volumes.length === 0;
|
const hasNoVolumes = data.length === 0;
|
||||||
const hasNoFilteredVolumes = rows.length === 0 && !hasNoVolumes;
|
const hasNoFilteredVolumes = rows.length === 0 && !hasNoVolumes;
|
||||||
|
|
||||||
if (hasNoVolumes) {
|
if (hasNoVolumes) {
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue