From c8eecb1c5dac027b78adac13291287a9e240a7d0 Mon Sep 17 00:00:00 2001 From: Nicolas Meienberger Date: Sat, 2 May 2026 10:16:27 +0200 Subject: [PATCH] chore: pr feedbacks --- app/client/modules/notifications/routes/notifications.tsx | 1 + app/client/modules/repositories/routes/repositories.tsx | 6 ++---- app/client/modules/volumes/routes/volumes.tsx | 6 ++---- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/app/client/modules/notifications/routes/notifications.tsx b/app/client/modules/notifications/routes/notifications.tsx index 8a8744c4..6f6b91a5 100644 --- a/app/client/modules/notifications/routes/notifications.tsx +++ b/app/client/modules/notifications/routes/notifications.tsx @@ -129,6 +129,7 @@ export function NotificationsPage() { Ntfy Pushover Telegram + Generic Custom diff --git a/app/client/modules/repositories/routes/repositories.tsx b/app/client/modules/repositories/routes/repositories.tsx index a52cbb6b..5a2b4879 100644 --- a/app/client/modules/repositories/routes/repositories.tsx +++ b/app/client/modules/repositories/routes/repositories.tsx @@ -97,10 +97,8 @@ export function RepositoriesPage() { ...listRepositoriesOptions(), }); - const repositories = data as RepositoryRow[]; - const table = useReactTable({ - data: repositories, + data, columns: repositoryColumns, state: { columnFilters, sorting }, onColumnFiltersChange: setColumnFilters, @@ -114,7 +112,7 @@ export function RepositoriesPage() { const clearFilters = () => table.resetColumnFilters(); - const hasNoRepositories = repositories.length === 0; + const hasNoRepositories = data.length === 0; const hasNoFilteredRepositories = rows.length === 0 && !hasNoRepositories; if (hasNoRepositories) { diff --git a/app/client/modules/volumes/routes/volumes.tsx b/app/client/modules/volumes/routes/volumes.tsx index 2efdb69f..8a0c3e06 100644 --- a/app/client/modules/volumes/routes/volumes.tsx +++ b/app/client/modules/volumes/routes/volumes.tsx @@ -77,10 +77,8 @@ export function VolumesPage() { const navigate = useNavigate(); const { data } = useSuspenseQuery({ ...listVolumesOptions() }); - const volumes = data as VolumeRow[]; - const table = useReactTable({ - data: volumes, + data, columns: volumeColumns, state: { columnFilters, sorting }, onColumnFiltersChange: setColumnFilters, @@ -95,7 +93,7 @@ export function VolumesPage() { const clearFilters = () => table.resetColumnFilters(); - const hasNoVolumes = volumes.length === 0; + const hasNoVolumes = data.length === 0; const hasNoFilteredVolumes = rows.length === 0 && !hasNoVolumes; if (hasNoVolumes) {