chore: pr feedback

This commit is contained in:
Nicolas Meienberger 2026-01-21 21:40:10 +01:00
parent 4ba182732c
commit 82e7382459
5 changed files with 5 additions and 6 deletions

View file

@ -159,7 +159,6 @@ export const CreateNotificationForm = ({ onSubmit, mode = "create", initialValue
<FormLabel>Type</FormLabel> <FormLabel>Type</FormLabel>
<Select <Select
onValueChange={field.onChange} onValueChange={field.onChange}
defaultValue={field.value}
value={field.value} value={field.value}
disabled={mode === "update"} disabled={mode === "update"}
> >

View file

@ -90,7 +90,7 @@ export const NtfyForm = ({ form }: Props) => {
render={({ field }) => ( render={({ field }) => (
<FormItem> <FormItem>
<FormLabel>Priority</FormLabel> <FormLabel>Priority</FormLabel>
<Select onValueChange={field.onChange} defaultValue={String(field.value)} value={String(field.value)}> <Select onValueChange={field.onChange} value={String(field.value)}>
<FormControl> <FormControl>
<SelectTrigger> <SelectTrigger>
<SelectValue placeholder="Select priority" /> <SelectValue placeholder="Select priority" />

View file

@ -126,7 +126,7 @@ export const CreateRepositoryForm = ({
render={({ field }) => ( render={({ field }) => (
<FormItem> <FormItem>
<FormLabel>Backend</FormLabel> <FormLabel>Backend</FormLabel>
<Select onValueChange={field.onChange} defaultValue={field.value} value={field.value}> <Select onValueChange={field.onChange} value={field.value}>
<FormControl> <FormControl>
<SelectTrigger> <SelectTrigger>
<SelectValue placeholder="Select a backend" /> <SelectValue placeholder="Select a backend" />
@ -164,7 +164,7 @@ export const CreateRepositoryForm = ({
render={({ field }) => ( render={({ field }) => (
<FormItem> <FormItem>
<FormLabel>Compression Mode</FormLabel> <FormLabel>Compression Mode</FormLabel>
<Select onValueChange={field.onChange} defaultValue={field.value} value={field.value}> <Select onValueChange={field.onChange} value={field.value}>
<FormControl> <FormControl>
<SelectTrigger> <SelectTrigger>
<SelectValue placeholder="Select compression mode" /> <SelectValue placeholder="Select compression mode" />

View file

@ -52,7 +52,7 @@ export const RcloneRepositoryForm = ({ form }: Props) => {
render={({ field }) => ( render={({ field }) => (
<FormItem> <FormItem>
<FormLabel>Remote</FormLabel> <FormLabel>Remote</FormLabel>
<Select onValueChange={(v) => field.onChange(v)} defaultValue={field.value} value={field.value}> <Select onValueChange={(v) => field.onChange(v)} value={field.value}>
<FormControl> <FormControl>
<SelectTrigger> <SelectTrigger>
<SelectValue placeholder="Select an rclone remote" /> <SelectValue placeholder="Select an rclone remote" />

View file

@ -153,7 +153,7 @@ export function CreateUserDialog({ onUserCreated }: CreateUserDialogProps) {
render={({ field }) => ( render={({ field }) => (
<FormItem> <FormItem>
<FormLabel>Role</FormLabel> <FormLabel>Role</FormLabel>
<Select onValueChange={field.onChange} defaultValue={field.value} disabled={isLoading}> <Select onValueChange={field.onChange} value={field.value} disabled={isLoading}>
<FormControl> <FormControl>
<SelectTrigger> <SelectTrigger>
<SelectValue placeholder="Select a role" /> <SelectValue placeholder="Select a role" />