From 82e73824591a85803dba74a73742b06a3e37ac9e Mon Sep 17 00:00:00 2001
From: Nicolas Meienberger <github@thisprops.com>
Date: Wed, 21 Jan 2026 21:40:10 +0100
Subject: [PATCH] chore: pr feedback

---
 .../notifications/components/create-notification-form.tsx     | 1 -
 .../notifications/components/notification-forms/ntfy-form.tsx | 2 +-
 .../repositories/components/create-repository-form.tsx        | 4 ++--
 .../components/repository-forms/rclone-repository-form.tsx    | 2 +-
 app/client/modules/settings/components/create-user-dialog.tsx | 2 +-
 5 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/app/client/modules/notifications/components/create-notification-form.tsx b/app/client/modules/notifications/components/create-notification-form.tsx
index 8b913664..07608605 100644
--- a/app/client/modules/notifications/components/create-notification-form.tsx
+++ b/app/client/modules/notifications/components/create-notification-form.tsx
@@ -159,7 +159,6 @@ export const CreateNotificationForm = ({ onSubmit, mode = "create", initialValue
 							<FormLabel>Type</FormLabel>
 							<Select
 								onValueChange={field.onChange}
-								defaultValue={field.value}
 								value={field.value}
 								disabled={mode === "update"}
 							>
diff --git a/app/client/modules/notifications/components/notification-forms/ntfy-form.tsx b/app/client/modules/notifications/components/notification-forms/ntfy-form.tsx
index 7fa21920..16ecec98 100644
--- a/app/client/modules/notifications/components/notification-forms/ntfy-form.tsx
+++ b/app/client/modules/notifications/components/notification-forms/ntfy-form.tsx
@@ -90,7 +90,7 @@ export const NtfyForm = ({ form }: Props) => {
 				render={({ field }) => (
 					<FormItem>
 						<FormLabel>Priority</FormLabel>
-						<Select onValueChange={field.onChange} defaultValue={String(field.value)} value={String(field.value)}>
+						<Select onValueChange={field.onChange} value={String(field.value)}>
 							<FormControl>
 								<SelectTrigger>
 									<SelectValue placeholder="Select priority" />
diff --git a/app/client/modules/repositories/components/create-repository-form.tsx b/app/client/modules/repositories/components/create-repository-form.tsx
index 9d590b55..be8ec32d 100644
--- a/app/client/modules/repositories/components/create-repository-form.tsx
+++ b/app/client/modules/repositories/components/create-repository-form.tsx
@@ -126,7 +126,7 @@ export const CreateRepositoryForm = ({
 					render={({ field }) => (
 						<FormItem>
 							<FormLabel>Backend</FormLabel>
-							<Select onValueChange={field.onChange} defaultValue={field.value} value={field.value}>
+							<Select onValueChange={field.onChange} value={field.value}>
 								<FormControl>
 									<SelectTrigger>
 										<SelectValue placeholder="Select a backend" />
@@ -164,7 +164,7 @@ export const CreateRepositoryForm = ({
 					render={({ field }) => (
 						<FormItem>
 							<FormLabel>Compression Mode</FormLabel>
-							<Select onValueChange={field.onChange} defaultValue={field.value} value={field.value}>
+							<Select onValueChange={field.onChange} value={field.value}>
 								<FormControl>
 									<SelectTrigger>
 										<SelectValue placeholder="Select compression mode" />
diff --git a/app/client/modules/repositories/components/repository-forms/rclone-repository-form.tsx b/app/client/modules/repositories/components/repository-forms/rclone-repository-form.tsx
index 5941191a..106a8681 100644
--- a/app/client/modules/repositories/components/repository-forms/rclone-repository-form.tsx
+++ b/app/client/modules/repositories/components/repository-forms/rclone-repository-form.tsx
@@ -52,7 +52,7 @@ export const RcloneRepositoryForm = ({ form }: Props) => {
 				render={({ field }) => (
 					<FormItem>
 						<FormLabel>Remote</FormLabel>
-						<Select onValueChange={(v) => field.onChange(v)} defaultValue={field.value} value={field.value}>
+						<Select onValueChange={(v) => field.onChange(v)} value={field.value}>
 							<FormControl>
 								<SelectTrigger>
 									<SelectValue placeholder="Select an rclone remote" />
diff --git a/app/client/modules/settings/components/create-user-dialog.tsx b/app/client/modules/settings/components/create-user-dialog.tsx
index dc76e7e5..51160419 100644
--- a/app/client/modules/settings/components/create-user-dialog.tsx
+++ b/app/client/modules/settings/components/create-user-dialog.tsx
@@ -153,7 +153,7 @@ export function CreateUserDialog({ onUserCreated }: CreateUserDialogProps) {
 								render={({ field }) => (
 									<FormItem>
 										<FormLabel>Role</FormLabel>
-										<Select onValueChange={field.onChange} defaultValue={field.value} disabled={isLoading}>
+										<Select onValueChange={field.onChange} value={field.value} disabled={isLoading}>
 											<FormControl>
 												<SelectTrigger>
 													<SelectValue placeholder="Select a role" />