danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix one more coderabbit identified issue

Browse source
This commit is contained in:
Raj Dave 2026-04-28 23:27:23 +03:00
parent 4ae9a1f7e3
commit 02934e0426
1 changed files with 12 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
app/client/components/snapshots-table.tsx
View file

@ -105,12 +105,13 @@ export const SnapshotsTable = ({ snapshots, repositoryId, backups, listSnapshots
const handleSnapshotSelection = (snapshotId: string, event?: React.MouseEvent | React.KeyboardEvent) => { const handleSnapshotSelection = (snapshotId: string, event?: React.MouseEvent | React.KeyboardEvent) => {
const isShiftClick = event && "shiftKey" in event && event.shiftKey; const isShiftClick = event && "shiftKey" in event && event.shiftKey;
// Attempt range selection first
if (isShiftClick && lastSelectedId) { if (isShiftClick && lastSelectedId) {
// Range selection
const lastIndex = snapshots.findIndex((s) => s.short_id === lastSelectedId); const lastIndex = snapshots.findIndex((s) => s.short_id === lastSelectedId);
const currentIndex = snapshots.findIndex((s) => s.short_id === snapshotId); const currentIndex = snapshots.findIndex((s) => s.short_id === snapshotId);
if (lastIndex !== -1 && currentIndex !== -1) { if (lastIndex !== -1 && currentIndex !== -1) {
// Valid range selection
const start = Math.min(lastIndex, currentIndex); const start = Math.min(lastIndex, currentIndex);
const end = Math.max(lastIndex, currentIndex); const end = Math.max(lastIndex, currentIndex);
const rangeIds = new Set(snapshots.slice(start, end + 1).map((s) => s.short_id)); const rangeIds = new Set(snapshots.slice(start, end + 1).map((s) => s.short_id));
@ -119,27 +120,19 @@ export const SnapshotsTable = ({ snapshots, repositoryId, backups, listSnapshots
const newSelected = new Set(selectedIds); const newSelected = new Set(selectedIds);
rangeIds.forEach((id) => newSelected.add(id)); rangeIds.forEach((id) => newSelected.add(id));
setSelectedIds(newSelected); setSelectedIds(newSelected);
} else { setLastSelectedId(snapshotId);
// Fallback to single-toggle when range selection fails due to stale lastSelectedId return;
const newSelected = new Set(selectedIds);
if (newSelected.has(snapshotId)) {
newSelected.delete(snapshotId);
} else {
newSelected.add(snapshotId);
}
setSelectedIds(newSelected);
} }
} else {
// Single selection toggle
const newSelected = new Set(selectedIds);
if (newSelected.has(snapshotId)) {
newSelected.delete(snapshotId);
} else {
newSelected.add(snapshotId);
}
setSelectedIds(newSelected);
} }
// Single selection toggle (used as fallback or when shift-click not applicable)
const newSelected = new Set(selectedIds);
if (newSelected.has(snapshotId)) {
newSelected.delete(snapshotId);
} else {
newSelected.add(snapshotId);
}
setSelectedIds(newSelected);
setLastSelectedId(snapshotId); setLastSelectedId(snapshotId);
}; };