From 02934e0426a7366b0f38ef9d3fcfd0eb382d71b3 Mon Sep 17 00:00:00 2001
From: Raj Dave <rajdave8002@gmail.com>
Date: Tue, 28 Apr 2026 23:27:23 +0300
Subject: [PATCH] fix one more coderabbit identified issue

---
 app/client/components/snapshots-table.tsx | 31 +++++++++--------------
 1 file changed, 12 insertions(+), 19 deletions(-)

diff --git a/app/client/components/snapshots-table.tsx b/app/client/components/snapshots-table.tsx
index 273c11ed..7962aa42 100644
--- a/app/client/components/snapshots-table.tsx
+++ b/app/client/components/snapshots-table.tsx
@@ -105,12 +105,13 @@ export const SnapshotsTable = ({ snapshots, repositoryId, backups, listSnapshots
 	const handleSnapshotSelection = (snapshotId: string, event?: React.MouseEvent | React.KeyboardEvent) => {
 		const isShiftClick = event && "shiftKey" in event && event.shiftKey;
 
+		// Attempt range selection first
 		if (isShiftClick && lastSelectedId) {
-			// Range selection
 			const lastIndex = snapshots.findIndex((s) => s.short_id === lastSelectedId);
 			const currentIndex = snapshots.findIndex((s) => s.short_id === snapshotId);
 
 			if (lastIndex !== -1 && currentIndex !== -1) {
+				// Valid range selection
 				const start = Math.min(lastIndex, currentIndex);
 				const end = Math.max(lastIndex, currentIndex);
 				const rangeIds = new Set(snapshots.slice(start, end + 1).map((s) => s.short_id));
@@ -119,27 +120,19 @@ export const SnapshotsTable = ({ snapshots, repositoryId, backups, listSnapshots
 				const newSelected = new Set(selectedIds);
 				rangeIds.forEach((id) => newSelected.add(id));
 				setSelectedIds(newSelected);
-			} else {
-				// Fallback to single-toggle when range selection fails due to stale lastSelectedId
-				const newSelected = new Set(selectedIds);
-				if (newSelected.has(snapshotId)) {
-					newSelected.delete(snapshotId);
-				} else {
-					newSelected.add(snapshotId);
-				}
-				setSelectedIds(newSelected);
+				setLastSelectedId(snapshotId);
+				return;
 			}
-		} else {
-			// Single selection toggle
-			const newSelected = new Set(selectedIds);
-			if (newSelected.has(snapshotId)) {
-				newSelected.delete(snapshotId);
-			} else {
-				newSelected.add(snapshotId);
-			}
-			setSelectedIds(newSelected);
 		}
 
+		// Single selection toggle (used as fallback or when shift-click not applicable)
+		const newSelected = new Set(selectedIds);
+		if (newSelected.has(snapshotId)) {
+			newSelected.delete(snapshotId);
+		} else {
+			newSelected.add(snapshotId);
+		}
+		setSelectedIds(newSelected);
 		setLastSelectedId(snapshotId);
 	};