danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix test

Browse source
This commit is contained in:
Jesse Bannon 2023-07-24 10:55:21 -07:00
parent b68fba2825
commit b9ad72430d
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/ytdl_sub/plugins/embed_thumbnail.py
View file

@ -1,3 +1,4 @@
from typing import List
from typing import Optional from typing import Optional
import mediafile import mediafile
@ -43,7 +44,7 @@ class EmbedThumbnailPlugin(Plugin[EmbedThumbnailOptions]):
thumbnail_path = entry.get_download_thumbnail_path() thumbnail_path = entry.get_download_thumbnail_path()
tmp_file_path = FFMPEG.tmp_file_path(file_path) tmp_file_path = FFMPEG.tmp_file_path(file_path)
try: try:
cmd = [ ffmpeg_args: List[str] = [
"-i", "-i",
file_path, file_path,
"-i", "-i",
@ -60,7 +61,7 @@ class EmbedThumbnailPlugin(Plugin[EmbedThumbnailOptions]):
"attached_pic", "attached_pic",
tmp_file_path, tmp_file_path,
] ]
FFMPEG.run(cmd) FFMPEG.run(ffmpeg_args)
FileHandler.move(tmp_file_path, file_path) FileHandler.move(tmp_file_path, file_path)
finally: finally:
FileHandler.delete(tmp_file_path) FileHandler.delete(tmp_file_path)

6
tests/unit/config/test_config_file.py
View file

@ -51,7 +51,11 @@ class TestConfigFilePartiallyValidatesPresets:
@pytest.mark.parametrize("plugin", PluginMapping.plugins()) @pytest.mark.parametrize("plugin", PluginMapping.plugins())
def test_success__empty_plugins(self, plugin: str): def test_success__empty_plugins(self, plugin: str):
self._partial_validate({plugin: {}}) excluded_plugins = [
"embed_thumbnail", # value is bool, not dict
]
if plugin not in excluded_plugins:
self._partial_validate({plugin: {}})
@pytest.mark.parametrize("source", DownloadStrategyMapping.sources()) @pytest.mark.parametrize("source", DownloadStrategyMapping.sources())
def test_success__empty_sources(self, source: str): def test_success__empty_sources(self, source: str):