From b9ad72430d7b82d725f769a0d91dadddb7ec963e Mon Sep 17 00:00:00 2001 From: Jesse Bannon Date: Mon, 24 Jul 2023 10:55:21 -0700 Subject: [PATCH] fix test --- src/ytdl_sub/plugins/embed_thumbnail.py | 5 +++-- tests/unit/config/test_config_file.py | 6 +++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/ytdl_sub/plugins/embed_thumbnail.py b/src/ytdl_sub/plugins/embed_thumbnail.py index 6310569d..c4ead413 100644 --- a/src/ytdl_sub/plugins/embed_thumbnail.py +++ b/src/ytdl_sub/plugins/embed_thumbnail.py @@ -1,3 +1,4 @@ +from typing import List from typing import Optional import mediafile @@ -43,7 +44,7 @@ class EmbedThumbnailPlugin(Plugin[EmbedThumbnailOptions]): thumbnail_path = entry.get_download_thumbnail_path() tmp_file_path = FFMPEG.tmp_file_path(file_path) try: - cmd = [ + ffmpeg_args: List[str] = [ "-i", file_path, "-i", @@ -60,7 +61,7 @@ class EmbedThumbnailPlugin(Plugin[EmbedThumbnailOptions]): "attached_pic", tmp_file_path, ] - FFMPEG.run(cmd) + FFMPEG.run(ffmpeg_args) FileHandler.move(tmp_file_path, file_path) finally: FileHandler.delete(tmp_file_path) diff --git a/tests/unit/config/test_config_file.py b/tests/unit/config/test_config_file.py index 2bda9621..24de3269 100644 --- a/tests/unit/config/test_config_file.py +++ b/tests/unit/config/test_config_file.py @@ -51,7 +51,11 @@ class TestConfigFilePartiallyValidatesPresets: @pytest.mark.parametrize("plugin", PluginMapping.plugins()) def test_success__empty_plugins(self, plugin: str): - self._partial_validate({plugin: {}}) + excluded_plugins = [ + "embed_thumbnail", # value is bool, not dict + ] + if plugin not in excluded_plugins: + self._partial_validate({plugin: {}}) @pytest.mark.parametrize("source", DownloadStrategyMapping.sources()) def test_success__empty_sources(self, source: str):