danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[REVERT] Remove default match-filter that filters live videos (#739)

Browse source 
Adding a default match-filter broke other people's match-filters. This is because each match-filter acts as an OR. I.e.
```
match_filters:
  filters:
    - "!is_live & !is_upcoming & !post_live"  # the one I added
    - "original_url!*=/shorts/ & !is_live"
```
Would not filter shorts, because under the hood, yt-dlp evaluates it as `(!is_live & !is_upcoming & !post_live) | (original_url!*=/shorts/ & !is_live)`

Need to rethink how to filter live videos by default 🤔
This commit is contained in:
Jesse Bannon 2023-09-22 08:33:49 -07:00 committed by GitHub
parent f05fdbc498
commit 723c40b59b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/ytdl_sub/prebuilt_presets/helpers/players.yaml
View file

@ -1,9 +1,6 @@
presets:
_base:
match_filters:
filters:
- "!is_live & !is_upcoming & !post_live"
overrides:
file_uid: "{uid_sanitized}"
file_title: "{title_sanitized}"