From 723c40b59be3737a19a9346c7fdaac34264b4938 Mon Sep 17 00:00:00 2001 From: Jesse Bannon Date: Fri, 22 Sep 2023 08:33:49 -0700 Subject: [PATCH] [REVERT] Remove default match-filter that filters live videos (#739) Adding a default match-filter broke other people's match-filters. This is because each match-filter acts as an OR. I.e. ``` match_filters: filters: - "!is_live & !is_upcoming & !post_live" # the one I added - "original_url!*=/shorts/ & !is_live" ``` Would not filter shorts, because under the hood, yt-dlp evaluates it as `(!is_live & !is_upcoming & !post_live) | (original_url!*=/shorts/ & !is_live)` Need to rethink how to filter live videos by default :thinking: --- src/ytdl_sub/prebuilt_presets/helpers/players.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/ytdl_sub/prebuilt_presets/helpers/players.yaml b/src/ytdl_sub/prebuilt_presets/helpers/players.yaml index 27870139..a0d62694 100644 --- a/src/ytdl_sub/prebuilt_presets/helpers/players.yaml +++ b/src/ytdl_sub/prebuilt_presets/helpers/players.yaml @@ -1,9 +1,6 @@ presets: _base: - match_filters: - filters: - - "!is_live & !is_upcoming & !post_live" overrides: file_uid: "{uid_sanitized}" file_title: "{title_sanitized}"