danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

video settings: stop music's verify loop choking on tvdb/tmdb ('Unknown service')

Browse source 
The video API-key frames had the real data-service attribute, so music's
settings.js verify loop (#settings-page .stg-service[data-service]) picked them
up and errored 'Unknown service: tvdb' — and it ran on the music side too
(shared DOM), so it WAS impacting music. Renamed to data-video-service: same
identical .api-service-frame look, but music's [data-service] selector can't
match them. Music untouched again.
This commit is contained in:
BoulderBadgeDad 2026-06-14 12:16:44 -07:00
parent 941ebd42d9
commit d35bb695ae
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/test_video_side_shell.py
View file

@ -230,9 +230,13 @@ def test_video_side_hides_music_api_config_and_shows_placeholders():
css = _CSS_PATH.read_text(encoding="utf-8") css = _CSS_PATH.read_text(encoding="utf-8")
assert 'body[data-side="video"] [data-music-only]' in css # music API hidden on video assert 'body[data-side="video"] [data-music-only]' in css # music API hidden on video
assert "data-music-only" in _INDEX # the music API group is marked assert "data-music-only" in _INDEX # the music API group is marked
# Video placeholders use the SAME .api-service-frame structure as music. # Video API frames use the SAME .api-service-frame structure as music but a
assert 'class="api-service-frame stg-service" data-service="tmdb"' in _INDEX # data-VIDEO-service attribute, so music's settings.js [data-service] verify
assert 'class="api-service-frame stg-service" data-service="tvdb"' in _INDEX # loop can't pick them up ("Unknown service: tvdb").
assert 'class="api-service-frame stg-service" data-video-service="tmdb"' in _INDEX
assert 'class="api-service-frame stg-service" data-video-service="tvdb"' in _INDEX
# They must NOT carry the music-hooked data-service attribute.
assert 'data-service="tmdb"' not in _INDEX and 'data-service="tvdb"' not in _INDEX
def test_dashboard_enrichment_buttons_present(): def test_dashboard_enrichment_buttons_present():

4
webui/index.html
View file

@ -4841,7 +4841,7 @@
music service frames above. --> music service frames above. -->
<div class="settings-group" data-stg="connections" data-video-only> <div class="settings-group" data-stg="connections" data-video-only>
<h3>API Configuration <button class="stg-accordion-toggle" onclick="toggleAllServiceAccordions(this)">Expand All</button></h3> <h3>API Configuration <button class="stg-accordion-toggle" onclick="toggleAllServiceAccordions(this)">Expand All</button></h3>
<div class="api-service-frame stg-service" data-service="tmdb"> <div class="api-service-frame stg-service" data-video-service="tmdb">
<div class="stg-service-header" onclick="toggleStgService(this)"> <div class="stg-service-header" onclick="toggleStgService(this)">
<span class="stg-service-dot" style="color: #01b4e4;"></span> <span class="stg-service-dot" style="color: #01b4e4;"></span>
<h4 class="service-title">TMDB</h4> <h4 class="service-title">TMDB</h4>
@ -4858,7 +4858,7 @@
</div> </div>
</div> </div>
</div> </div>
<div class="api-service-frame stg-service" data-service="tvdb"> <div class="api-service-frame stg-service" data-video-service="tvdb">
<div class="stg-service-header" onclick="toggleStgService(this)"> <div class="stg-service-header" onclick="toggleStgService(this)">
<span class="stg-service-dot" style="color: #6cd391;"></span> <span class="stg-service-dot" style="color: #6cd391;"></span>
<h4 class="service-title">TVDB</h4> <h4 class="service-title">TVDB</h4>