From d35bb695aeae9439d96c6c3857e5aca613da2314 Mon Sep 17 00:00:00 2001
From: BoulderBadgeDad <batmanesignal@gmail.com>
Date: Sun, 14 Jun 2026 12:16:44 -0700
Subject: [PATCH] video settings: stop music's verify loop choking on tvdb/tmdb
 ('Unknown service')
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The video API-key frames had the real data-service attribute, so music's
settings.js verify loop (#settings-page .stg-service[data-service]) picked them
up and errored 'Unknown service: tvdb' — and it ran on the music side too
(shared DOM), so it WAS impacting music. Renamed to data-video-service: same
identical .api-service-frame look, but music's [data-service] selector can't
match them. Music untouched again.
---
 tests/test_video_side_shell.py | 10 +++++++---
 webui/index.html               |  4 ++--
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/tests/test_video_side_shell.py b/tests/test_video_side_shell.py
index 29bf5e5b..31a01513 100644
--- a/tests/test_video_side_shell.py
+++ b/tests/test_video_side_shell.py
@@ -230,9 +230,13 @@ def test_video_side_hides_music_api_config_and_shows_placeholders():
     css = _CSS_PATH.read_text(encoding="utf-8")
     assert 'body[data-side="video"] [data-music-only]' in css   # music API hidden on video
     assert "data-music-only" in _INDEX                          # the music API group is marked
-    # Video placeholders use the SAME .api-service-frame structure as music.
-    assert 'class="api-service-frame stg-service" data-service="tmdb"' in _INDEX
-    assert 'class="api-service-frame stg-service" data-service="tvdb"' in _INDEX
+    # Video API frames use the SAME .api-service-frame structure as music but a
+    # data-VIDEO-service attribute, so music's settings.js [data-service] verify
+    # loop can't pick them up ("Unknown service: tvdb").
+    assert 'class="api-service-frame stg-service" data-video-service="tmdb"' in _INDEX
+    assert 'class="api-service-frame stg-service" data-video-service="tvdb"' in _INDEX
+    # They must NOT carry the music-hooked data-service attribute.
+    assert 'data-service="tmdb"' not in _INDEX and 'data-service="tvdb"' not in _INDEX
 
 
 def test_dashboard_enrichment_buttons_present():
diff --git a/webui/index.html b/webui/index.html
index fbbc800c..6895484f 100644
--- a/webui/index.html
+++ b/webui/index.html
@@ -4841,7 +4841,7 @@
                                  music service frames above. -->
                             <div class="settings-group" data-stg="connections" data-video-only>
                                 <h3>API Configuration <button class="stg-accordion-toggle" onclick="toggleAllServiceAccordions(this)">Expand All</button></h3>
-                                <div class="api-service-frame stg-service" data-service="tmdb">
+                                <div class="api-service-frame stg-service" data-video-service="tmdb">
                                     <div class="stg-service-header" onclick="toggleStgService(this)">
                                         <span class="stg-service-dot" style="color: #01b4e4;"></span>
                                         <h4 class="service-title">TMDB</h4>
@@ -4858,7 +4858,7 @@
                                         </div>
                                     </div>
                                 </div>
-                                <div class="api-service-frame stg-service" data-service="tvdb">
+                                <div class="api-service-frame stg-service" data-video-service="tvdb">
                                     <div class="stg-service-header" onclick="toggleStgService(this)">
                                         <span class="stg-service-dot" style="color: #6cd391;"></span>
                                         <h4 class="service-title">TVDB</h4>