danvics/soulsync
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

C2: Migrate remaining uniform is_connected dispatches

Browse source 
Two more sites in web_server.py replaced (tag-preview + batch
tag-preview server_type checks). Same pattern as C1: 3-way
if/elif → engine.is_connected().

Honest scope note: the recon agent counted 33 dispatch sites,
but most are deeply server-specific logic where each branch
does completely different work (playlist track replace, per-
server metadata sync, deep scan with server-specific helpers).
Lifting those would move per-server branches into engine helper
methods that route the same work — net zero LOC, more indirection.
Engine helps where the shape is TRULY uniform; the deep dispatches
stay explicit. Phase C ends here at 4 simple sites lifted.

Suite still green.
This commit is contained in:
Broque Thomas 2026-05-04 21:28:09 -07:00
parent 971d683ebd
commit b769f02f04
1 changed files with 3 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
web_server.py
View file

@ -9551,13 +9551,7 @@ def get_track_tag_preview(track_id):
# Include server type so frontend can offer server sync option
active_server = config_manager.get_active_media_server()
server_connected = False
if active_server == 'plex':
server_connected = plex_client.is_connected()
elif active_server == 'jellyfin':
server_connected = jellyfin_client.is_connected()
elif active_server == 'navidrome':
server_connected = navidrome_client.is_connected()
server_connected = media_server_engine.is_connected() if media_server_engine else False
return jsonify({
"success": True,
@ -9658,15 +9652,9 @@ def get_batch_tag_preview():
results.append(entry)
# Server type info
# Server type info — engine routes to active client.
active_server = config_manager.get_active_media_server()
server_connected = False
if active_server == 'plex':
server_connected = plex_client.is_connected()
elif active_server == 'jellyfin':
server_connected = jellyfin_client.is_connected()
elif active_server == 'navidrome':
server_connected = navidrome_client.is_connected()
server_connected = media_server_engine.is_connected() if media_server_engine else False
return jsonify({
"success": True,