From b769f02f04fa14083265fca8267e8f7cf8c94ae0 Mon Sep 17 00:00:00 2001 From: Broque Thomas <26755000+Nezreka@users.noreply.github.com> Date: Mon, 4 May 2026 21:28:09 -0700 Subject: [PATCH] C2: Migrate remaining uniform is_connected dispatches MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two more sites in web_server.py replaced (tag-preview + batch tag-preview server_type checks). Same pattern as C1: 3-way if/elif → engine.is_connected(). Honest scope note: the recon agent counted 33 dispatch sites, but most are deeply server-specific logic where each branch does completely different work (playlist track replace, per- server metadata sync, deep scan with server-specific helpers). Lifting those would move per-server branches into engine helper methods that route the same work — net zero LOC, more indirection. Engine helps where the shape is TRULY uniform; the deep dispatches stay explicit. Phase C ends here at 4 simple sites lifted. Suite still green. --- web_server.py | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/web_server.py b/web_server.py index 896e7de5..17b0bd0b 100644 --- a/web_server.py +++ b/web_server.py @@ -9551,13 +9551,7 @@ def get_track_tag_preview(track_id): # Include server type so frontend can offer server sync option active_server = config_manager.get_active_media_server() - server_connected = False - if active_server == 'plex': - server_connected = plex_client.is_connected() - elif active_server == 'jellyfin': - server_connected = jellyfin_client.is_connected() - elif active_server == 'navidrome': - server_connected = navidrome_client.is_connected() + server_connected = media_server_engine.is_connected() if media_server_engine else False return jsonify({ "success": True, @@ -9658,15 +9652,9 @@ def get_batch_tag_preview(): results.append(entry) - # Server type info + # Server type info — engine routes to active client. active_server = config_manager.get_active_media_server() - server_connected = False - if active_server == 'plex': - server_connected = plex_client.is_connected() - elif active_server == 'jellyfin': - server_connected = jellyfin_client.is_connected() - elif active_server == 'navidrome': - server_connected = navidrome_client.is_connected() + server_connected = media_server_engine.is_connected() if media_server_engine else False return jsonify({ "success": True,