Album picker #730: drop the unused artist_name param (review cleanup)

Review caught that artist_name was added to pick_best_album_release's signature
and threaded through both call sites but never actually used — dead, misleading
code. Removed it from the helper + both callers. Artist-aware gating would be a
deliberate future feature (titles carry the artist inconsistently, so a hard
artist gate would risk the same false-negative class I just fixed); the album
relevance gate already resolves the reported wrong-release bug. No behavior
change. 127 plugin tests pass; compile + ruff clean.
This commit is contained in:
BoulderBadgeDad 2026-05-30 19:10:51 -07:00
parent 78c6f09e13
commit 1c2efbb15c
3 changed files with 3 additions and 5 deletions

View file

@ -171,7 +171,7 @@ def album_title_relevance(candidate_title: str, album_name: str) -> float:
def pick_best_album_release(candidates, quality_guess,
album_name: str = "", artist_name: str = "") -> Optional[object]:
album_name: str = "") -> Optional[object]:
"""Pick the single best torrent / NZB for an album-bundle download.
Heuristic, in priority order:

View file

@ -498,8 +498,7 @@ class TorrentDownloadPlugin(DownloadSourcePlugin):
return result
picked = pick_best_album_release(
candidates, _guess_quality_from_title,
album_name=album_name, artist_name=artist_name,
candidates, _guess_quality_from_title, album_name=album_name,
)
if picked is None:
# No candidate matched the requested album (or none passed filtering).

View file

@ -469,8 +469,7 @@ class UsenetDownloadPlugin(DownloadSourcePlugin):
return result
picked = pick_best_album_release(
candidates, _guess_quality_from_title,
album_name=album_name, artist_name=artist_name,
candidates, _guess_quality_from_title, album_name=album_name,
)
if picked is None:
# No candidate matched the requested album (or none passed filtering).