From 1c2efbb15cac6ac2a0168517568945f13d067380 Mon Sep 17 00:00:00 2001 From: BoulderBadgeDad Date: Sat, 30 May 2026 19:10:51 -0700 Subject: [PATCH] Album picker #730: drop the unused artist_name param (review cleanup) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Review caught that artist_name was added to pick_best_album_release's signature and threaded through both call sites but never actually used — dead, misleading code. Removed it from the helper + both callers. Artist-aware gating would be a deliberate future feature (titles carry the artist inconsistently, so a hard artist gate would risk the same false-negative class I just fixed); the album relevance gate already resolves the reported wrong-release bug. No behavior change. 127 plugin tests pass; compile + ruff clean. --- core/download_plugins/album_bundle.py | 2 +- core/download_plugins/torrent.py | 3 +-- core/download_plugins/usenet.py | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/core/download_plugins/album_bundle.py b/core/download_plugins/album_bundle.py index 398a45dc..0ae9d634 100644 --- a/core/download_plugins/album_bundle.py +++ b/core/download_plugins/album_bundle.py @@ -171,7 +171,7 @@ def album_title_relevance(candidate_title: str, album_name: str) -> float: def pick_best_album_release(candidates, quality_guess, - album_name: str = "", artist_name: str = "") -> Optional[object]: + album_name: str = "") -> Optional[object]: """Pick the single best torrent / NZB for an album-bundle download. Heuristic, in priority order: diff --git a/core/download_plugins/torrent.py b/core/download_plugins/torrent.py index 45615bc4..e97a2b5a 100644 --- a/core/download_plugins/torrent.py +++ b/core/download_plugins/torrent.py @@ -498,8 +498,7 @@ class TorrentDownloadPlugin(DownloadSourcePlugin): return result picked = pick_best_album_release( - candidates, _guess_quality_from_title, - album_name=album_name, artist_name=artist_name, + candidates, _guess_quality_from_title, album_name=album_name, ) if picked is None: # No candidate matched the requested album (or none passed filtering). diff --git a/core/download_plugins/usenet.py b/core/download_plugins/usenet.py index 31aee2b0..2b5bca62 100644 --- a/core/download_plugins/usenet.py +++ b/core/download_plugins/usenet.py @@ -469,8 +469,7 @@ class UsenetDownloadPlugin(DownloadSourcePlugin): return result picked = pick_best_album_release( - candidates, _guess_quality_from_title, - album_name=album_name, artist_name=artist_name, + candidates, _guess_quality_from_title, album_name=album_name, ) if picked is None: # No candidate matched the requested album (or none passed filtering).