docs: the generation comment still said "one pass, on generation only"
Some checks failed
Forgejo Android APK / Root app tests (push) Successful in 47s
Forgejo Docker Build / Root app tests (push) Successful in 48s
Forgejo Android APK / Build signed APK (push) Successful in 1m52s
Forgejo Docker Build / Build Docker image (push) Successful in 10s
Forgejo Docker Build / Deploy to the host (push) Failing after 2s
Some checks failed
Forgejo Android APK / Root app tests (push) Successful in 47s
Forgejo Docker Build / Root app tests (push) Successful in 48s
Forgejo Android APK / Build signed APK (push) Successful in 1m52s
Forgejo Docker Build / Build Docker image (push) Successful in 10s
Forgejo Docker Build / Deploy to the host (push) Failing after 2s
Modifying now reviews its own result, so that line described the rule as it was a commit ago. Also says what the generation pass can actually see: the deck is rendered there without its figures, because they were enqueued a few lines earlier and are still being drawn, so it judges the space a figure will occupy rather than the artwork that lands in it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dv6sqaY6Vq3ChZHMem3cnU
This commit is contained in:
parent
e244ee5240
commit
4dcd0b4fc7
1 changed files with 7 additions and 4 deletions
|
|
@ -415,10 +415,13 @@ router.post('/my-resources/generate', async function (req, res) {
|
|||
}
|
||||
|
||||
// Look at what was built. The model that wrote the deck never sees it, so
|
||||
// overflow, a figure on the wrong slide and a nine-item list that wants two
|
||||
// columns are invisible to it. One pass, on generation only, and only when
|
||||
// an administrator has named a reviewer — a second pass costs as much as
|
||||
// the first and fixes far less.
|
||||
// overflow and a nine-item list that wants two columns are invisible to it.
|
||||
// One pass, and only when an administrator has named a reviewer. Modifying
|
||||
// reviews its own result the same way — see the refine handler.
|
||||
//
|
||||
// The deck is rendered here *without* its figures: they were only enqueued a
|
||||
// few lines above and are still being drawn. So this pass judges the space a
|
||||
// figure will occupy, not the artwork that lands in it.
|
||||
// Computed here, before anything reads it. It used to be declared inside the
|
||||
// review branch below, so with no reviewer configured — the default — it was
|
||||
// undefined by the time the INSERT stringified it, and every generation
|
||||
|
|
|
|||
Loading…
Reference in a new issue