From 4dcd0b4fc70e52241ddf2995543e19f4bea27cf6 Mon Sep 17 00:00:00 2001 From: Daniel Date: Sat, 12 Sep 2026 07:29:01 +0200 Subject: [PATCH] docs: the generation comment still said "one pass, on generation only" Modifying now reviews its own result, so that line described the rule as it was a commit ago. Also says what the generation pass can actually see: the deck is rendered there without its figures, because they were enqueued a few lines earlier and are still being drawn, so it judges the space a figure will occupy rather than the artwork that lands in it. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01Dv6sqaY6Vq3ChZHMem3cnU --- src/routes/myResources.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/routes/myResources.js b/src/routes/myResources.js index e117a081..bc11c560 100644 --- a/src/routes/myResources.js +++ b/src/routes/myResources.js @@ -415,10 +415,13 @@ router.post('/my-resources/generate', async function (req, res) { } // Look at what was built. The model that wrote the deck never sees it, so - // overflow, a figure on the wrong slide and a nine-item list that wants two - // columns are invisible to it. One pass, on generation only, and only when - // an administrator has named a reviewer — a second pass costs as much as - // the first and fixes far less. + // overflow and a nine-item list that wants two columns are invisible to it. + // One pass, and only when an administrator has named a reviewer. Modifying + // reviews its own result the same way — see the refine handler. + // + // The deck is rendered here *without* its figures: they were only enqueued a + // few lines above and are still being drawn. So this pass judges the space a + // figure will occupy, not the artwork that lands in it. // Computed here, before anything reads it. It used to be declared inside the // review branch below, so with no reviewer configured — the default — it was // undefined by the time the INSERT stringified it, and every generation