danvics/oxipng
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove default value for interlace to ensure it is kept when nx is used (#620)

Browse source 
Fixes #619.

Interlacing still defaults to 0 when `--nx` is not specified and can
still be explicitly set even if it is (e.g. `-i 0 --nx` will still
deinterlace).
This commit is contained in:
andrews05 2024-06-03 04:46:44 +12:00 committed by GitHub
parent 290bf9d11f
commit e2c5b45f4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/cli.rs
View file

@ -171,8 +171,9 @@ transformation and may be unsuitable for some applications.")
.action(ArgAction::SetTrue), .action(ArgAction::SetTrue),
) )
.arg( .arg(
// Note: The default value is not explicitly set here, as it is dependant on the `--nx` flag.
Arg::new("interlace") Arg::new("interlace")
.help("Set PNG interlacing type (0, 1, keep)") .help("Set PNG interlacing type (0, 1, keep) [default: 0]")
.long_help("\ .long_help("\
Set the PNG interlacing type, where <type> is one of: Set the PNG interlacing type, where <type> is one of:
@ -181,11 +182,12 @@ Set the PNG interlacing type, where <type> is one of:
keep => Keep the existing interlacing type of each image keep => Keep the existing interlacing type of each image
Note that interlacing can add 25-50% to the size of an optimized image. Only use it if you \ Note that interlacing can add 25-50% to the size of an optimized image. Only use it if you \
believe the benefits outweigh the costs for your use case.") believe the benefits outweigh the costs for your use case.
[default: 0]")
.short('i') .short('i')
.long("interlace") .long("interlace")
.value_name("type") .value_name("type")
.default_value("0")
.value_parser(["0", "1", "keep"]) .value_parser(["0", "1", "keep"])
.hide_possible_values(true), .hide_possible_values(true),
) )