From e2c5b45f4bc0cd6007d350251bd8f7817ca612ee Mon Sep 17 00:00:00 2001 From: andrews05 Date: Mon, 3 Jun 2024 04:46:44 +1200 Subject: [PATCH] Remove default value for interlace to ensure it is kept when nx is used (#620) Fixes #619. Interlacing still defaults to 0 when `--nx` is not specified and can still be explicitly set even if it is (e.g. `-i 0 --nx` will still deinterlace). --- src/cli.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/cli.rs b/src/cli.rs index 88c0f41b..3c06c766 100644 --- a/src/cli.rs +++ b/src/cli.rs @@ -171,8 +171,9 @@ transformation and may be unsuitable for some applications.") .action(ArgAction::SetTrue), ) .arg( + // Note: The default value is not explicitly set here, as it is dependant on the `--nx` flag. Arg::new("interlace") - .help("Set PNG interlacing type (0, 1, keep)") + .help("Set PNG interlacing type (0, 1, keep) [default: 0]") .long_help("\ Set the PNG interlacing type, where is one of: @@ -181,11 +182,12 @@ Set the PNG interlacing type, where is one of: keep => Keep the existing interlacing type of each image Note that interlacing can add 25-50% to the size of an optimized image. Only use it if you \ -believe the benefits outweigh the costs for your use case.") +believe the benefits outweigh the costs for your use case. + +[default: 0]") .short('i') .long("interlace") .value_name("type") - .default_value("0") .value_parser(["0", "1", "keep"]) .hide_possible_values(true), )