1481 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
rcourtman	d219d9965d	test: Add ValidateSession tests for API package ... Add comprehensive tests for the ValidateSession wrapper function covering: - Non-existent token (returns false) - Empty token (returns false) - Valid token (returns true) - Expired token (returns false) The ValidateSession function is a simple wrapper around the SessionStore's ValidateSession method, but having direct tests ensures the wrapper is exercised and documents its expected behavior. Coverage: ValidateSession 0% → 100%	2025-12-02 13:22:45 +00:00
rcourtman	ef6a370144	test: Add ensureScope tests for API package ... Add comprehensive tests for the ensureScope function covering: - Empty scope parameter (always allows access) - No token in context (session-based request, allows access) - Token with matching scope (allows access) - Token with multiple scopes including required one (allows access) - Token missing required scope (rejects with 403) - Token with empty scopes (defaults to wildcard, allows access) - Rejection returns proper JSON response format Coverage: ensureScope 0% → 100% Coverage: API package 32.1% → 32.2%	2025-12-02 13:19:11 +00:00
rcourtman	301338d800	test: Add sendResolvedEmail tests for notifications package ... Add comprehensive tests for the sendResolvedEmail function covering: - Empty alert list (returns error) - Nil alert list (returns error) - All nil alerts (returns error from content builder) - Single alert (exercises email sending path) - Multiple alerts (tests grouped notification) - Mixed nil and valid alerts (filters correctly) - Zero resolved time (handles gracefully) Also improves buildResolvedNotificationContent coverage as a collateral benefit since sendResolvedEmail calls it internally. Coverage: sendResolvedEmail 0% → 100% Coverage: buildResolvedNotificationContent → 100% Coverage: notifications package 58.3% → 58.6%	2025-12-02 13:14:22 +00:00
rcourtman	d970055532	test: Add RequireAuth tests for API package ... Add comprehensive tests for the RequireAuth middleware covering: - No auth configured (allows access by design) - API-only mode (rejects requests without token) - API-only mode (accepts valid X-API-Token) - Basic auth with invalid credentials - Basic auth JSON vs plain text error responses - Valid basic auth (allowed) - Proxy auth (allowed) - Proxy auth with invalid secret (rejected) - Bearer token with basic auth configured (allowed) - Invalid Bearer token (rejected) Coverage: RequireAuth 7.1% → 78.6% Coverage: CheckAuth 66.9% → 69.1% Coverage: API package 31.9% → 32.1%	2025-12-02 13:09:48 +00:00
rcourtman	1073c511b3	test: Add RequireAdmin tests for API package ... Add comprehensive tests for the RequireAdmin middleware covering: - No auth configured (allows access by design) - API-only mode (rejects requests without token) - Basic auth with invalid credentials - Proxy auth with admin role (allowed) - Proxy auth with non-admin role (forbidden) - Proxy auth with invalid secret (unauthorized) - Proxy auth without role header (defaults to admin) - Proxy auth with custom role separator - Proxy auth with spaces in roles (trimmed) - Basic auth authenticated users (allowed as admin) - JSON vs plain text error responses based on path/Accept header Also improves CheckProxyAuth coverage as a side effect. Coverage: RequireAdmin 20.8% → 87.5% Coverage: CheckProxyAuth 0.0% → 89.3% Coverage: API package 30.9% → 31.9%	2025-12-02 13:06:06 +00:00
rcourtman	71e15886ed	test: Add isRequestAuthenticated tests for API package ... Add comprehensive tests for the isRequestAuthenticated function covering: - Nil inputs (config, request, both) - Basic auth (valid, invalid password, invalid username, malformed base64, missing colon) - API token via X-API-Token header - API token via Bearer authorization header (case insensitive) - Invalid/empty/whitespace API tokens - No auth configured scenarios - Empty session cookie handling Coverage: isRequestAuthenticated 26.1% → 82.6% Coverage: API package 30.7% → 30.9%	2025-12-02 12:59:18 +00:00
rcourtman	cf6149e884	test: Add CheckCSRF tests for API package ... Add comprehensive tests for the CheckCSRF function covering: - Safe methods (GET, HEAD, OPTIONS) bypass - API token authentication bypass - Basic auth bypass - No session cookie handling - Missing CSRF token rejection with new token issuance - Invalid CSRF token rejection with new token issuance - CSRF token from FormValue - Unsafe methods (POST, PUT, DELETE, PATCH) enforcement Coverage: CheckCSRF 32.0% → 96.0% Coverage: API package 30.5% → 30.7%	2025-12-02 12:53:32 +00:00
rcourtman	5deca850d4	test: Add saveHistoryWithRetry tests for alerts package ... Add comprehensive tests for the saveHistoryWithRetry function covering: - Backup file creation from existing history - Empty history serialization - Single retry success - Read-only directory failure with retries - Concurrent saves with serialization via saveMu - Snapshot isolation during save Coverage: saveHistoryWithRetry 58.6% → 86.2% Coverage: alerts package 87.4% → 87.8%	2025-12-02 12:49:27 +00:00
rcourtman	cd33c577f8	test: Add resolvePublicURL tests for API package ... Add comprehensive tests for the resolvePublicURL function covering: - Configured PublicURL (simple, trailing slashes, ports, whitespace) - Request-derived URL (HTTP, HTTPS via TLS, X-Forwarded-Proto) - No host fallback (with/without frontend port) - Nil request handling Coverage: resolvePublicURL 12.5% → 100% Coverage: API package 30.3% → 30.5%	2025-12-02 12:45:04 +00:00
rcourtman	80739cce94	test: Add rescheduleTask tests for monitoring package ... Add comprehensive tests for the rescheduleTask function covering: - Nil taskQueue handling (early return) - Successful task outcome (regular rescheduling) - Transient failure with backoff - Non-transient failure routing to dead letter queue - Exceeded retry attempts routing to dead letter queue - No outcome uses default interval - PBS and PMG instance type intervals - Adaptive polling max interval capping - Existing interval preservation Coverage: rescheduleTask 32.1% → 58.9% Coverage: monitoring package 52.8% → 53.5%	2025-12-02 12:38:50 +00:00
rcourtman	2842dded28	test: Add getGuestThresholds tests for alerts package ... Add comprehensive tests for the getGuestThresholds function covering: - Default threshold application - Guest-specific overrides - Custom rule filter matching - Override precedence over custom rules - Priority-based rule selection - Disabled rules handling - Disabled override handling - DisableConnectivity propagation from overrides and rules - Legacy CPU threshold conversion - Legacy ID migration (clustered and standalone VMs) - Container type support - All metric thresholds application Coverage: getGuestThresholds 40.2% → 77.6%	2025-12-02 12:35:07 +00:00
rcourtman	a4e3fe65b8	test: Add preserveAlertState, checkPMGQuarantineBacklog, LoadActiveAlerts tests ... Add comprehensive tests for three low-coverage functions: - preserveAlertState: nil handling, state preservation from existing alerts, ackState fallback, new alert handling - checkPMGQuarantineBacklog: nil quarantine handling, warning/critical thresholds, growth rate alerts, alert updates, virus quarantine - LoadActiveAlerts: missing file, valid file loading, old alert filtering, old acknowledged alert filtering, ack state restoration, invalid JSON, duplicate alert handling Coverage improvements: - preserveAlertState: 63.6% → 100% - checkPMGQuarantineBacklog: 12.9% → 100% - checkQuarantineMetric: 0% → 93.1% - LoadActiveAlerts: 26.2% → 80.0% - Alerts package: 83.5% → 86.6%	2025-12-02 12:22:14 +00:00
rcourtman	2133b25bb7	test: Add performCleanup tests for notifications queue ... Add 4 tests covering the performCleanup function: - cleanup removes old completed entries (>7 days) - cleanup removes old DLQ entries (>30 days) - cleanup removes old audit logs (>30 days) - cleanup with empty database (no panic) performCleanup coverage: 0% → 87.0% Notifications package: 57.3% → 58.3%	2025-12-02 12:16:55 +00:00
rcourtman	a6f4fc7bc0	test: Add GetQueue, addWebhookDelivery, GetWebhookHistory tests ... Tests for NotificationManager accessor and helper functions. Covers queue retrieval, webhook delivery tracking, history trimming to max 100 entries, and copy-on-read semantics. Notifications 56.6%→57.3%.	2025-12-02 12:10:29 +00:00
rcourtman	f184174f2b	test: Add HistoryManager tests for alerts package ... New history_test.go with 24 tests covering GetStats, getFileSize, AddAlert, GetHistory, GetAllHistory, RemoveAlert, ClearAllHistory, cleanOldEntries, saveHistory, loadHistory. Alerts package 83.6%→84.0%.	2025-12-02 12:06:53 +00:00
rcourtman	fc96ba7b69	test: Add WaitNext and key() tests for TaskQueue ... Tests cover context cancellation, immediately due tasks, waiting for future tasks, empty queue timeout, and multiple task priority ordering. WaitNext coverage 0%→92.3%, key() 0%→100%. Monitoring package 52.3%→52.9%.	2025-12-02 12:02:13 +00:00
rcourtman	e63c297ca3	test: Add BuildPlan, FilterDue, DispatchDue, LastScheduled tests ... Comprehensive tests for AdaptiveScheduler methods covering empty inventory, single/multiple instances, priority ordering, interval clamping, task caching, nil receiver handling, and task filtering. Monitoring package 51.4%→52.3%.	2025-12-02 11:59:37 +00:00
rcourtman	ea120b78d7	test: Add RecordNodeResult, RecordQueueWait, SetQueueDepth tests ... Improves metrics.go coverage to 100%. Added comprehensive tests for node-level poll metrics, queue wait time recording, and queue depth setting with edge cases (nil receiver, negative values, label normalization).	2025-12-02 11:57:05 +00:00
rcourtman	47d0fb5a44	test: Add dispatchAlert tests (55.6%→77.8%) ... Add TestDispatchAlert with 8 test cases covering: - Returns false when onAlert callback is nil - Returns false when alert is nil - Returns false when activation state is pending - Returns false when activation state is snoozed - Returns false for monitor-only alerts - Dispatches synchronously when async is false - Dispatches asynchronously when async is true - Clones alert before dispatch Alerts package coverage: 83.4%→83.5%	2025-12-02 11:47:24 +00:00
rcourtman	b3bf63d3c7	test: Add CheckStorage tests (52.4%→92.9%) ... Add comprehensive TestCheckStorageComprehensive with 11 test cases covering: - Returns early when alerts disabled - DisableAllStorage clears existing usage and offline alerts - Override with Disabled clears alerts - Usage threshold checking - Override threshold applied correctly - Skips usage check when offline/unavailable/zero usage - Offline status creates alert after confirmations - Unavailable status creates alert - Clears offline alert when back online Alerts package coverage: 82.4%→83.4%	2025-12-02 11:43:56 +00:00
rcourtman	9127b27f4c	test: Add CheckPMG tests (0%→100%) ... Add comprehensive TestCheckPMGComprehensive with 9 test cases covering: - Returns early when alerts disabled - DisableAllPMG clears all PMG alert types (queue-total, queue-deferred, queue-hold, oldest-message, offline) - Override with Disabled clears alerts - DisableAllPMGOffline clears offline alert - Offline status creates alert after confirmations - Connection health error triggers offline alert - Connection health unhealthy triggers offline alert - Clears offline alert when back online - Skips metrics when PMG is offline Alerts package coverage: 81.5%→82.4%	2025-12-02 11:40:53 +00:00
rcourtman	073d5ffa55	fix: Use --ctid instead of --standalone --http-mode in quick-setup command ... The quick-setup command for temperature monitoring was generating --standalone --http-mode which is meant for Docker deployments. This confused users trying to set up multi-server Proxmox monitoring. Now uses --ctid which works for both local and remote Proxmox hosts. The installer detects when the container doesn't exist locally and installs in "host monitoring only" mode automatically. If we can determine the actual CTID from the host proxy summary, we use it; otherwise we show <PULSE_CTID> for the user to replace. Related to #785	2025-12-02 11:38:47 +00:00
rcourtman	9f174be20b	test: Add CheckPBS tests (0%→98.3%) ... Add comprehensive TestCheckPBSComprehensive with 12 test cases covering: - Returns early when alerts disabled - DisableAllPBS clears existing CPU/memory/offline alerts - Override with Disabled clears alerts - DisableAllPBSOffline clears offline alert - CPU threshold checking when online - Memory threshold checking when online - Skips metrics when PBS is offline - Override thresholds applied correctly - Offline status creates alert after confirmations - Connection health error triggers offline alert - Connection health unhealthy triggers offline alert - Clears offline alert when back online Alerts package coverage: 80.0%→81.5%	2025-12-02 11:38:36 +00:00
rcourtman	de6bd8065b	docs: Clarify multi-server Proxmox temperature monitoring setup ... The quick-setup command from Pulse UI uses --standalone --http-mode which is for Docker deployments. Users with multiple Proxmox servers (Pulse on server A, monitoring server B) should use --ctid instead. The installer detects when the container doesn't exist locally and installs in "host monitoring only" mode. Related to #785	2025-12-02 11:36:43 +00:00
rcourtman	13f5ca4018	test: Add CheckHost tests (49.6%→98.3%) ... Add comprehensive TestCheckHostComprehensive with 17 test cases covering: - Empty host ID early return - Alerts disabled early return - DisableAllHosts clears existing alerts - Override with Disabled clears alerts - CPU/Memory/Disk threshold nil clears alerts - RAID degraded/rebuilding/healthy states - RAID with failed devices triggers critical alert - RAID resync triggers rebuilding alert - Existing RAID alert not duplicated (preserves start time) - Override thresholds applied correctly - Multiple disks handling - Offline alert cleared when host comes online - Tags included in metadata Alerts package coverage: 78.6%→80.0%	2025-12-02 11:34:20 +00:00
rcourtman	53a2c2a587	fix: Prevent agent type badge flapping in UnifiedAgents view ... Track previously seen host types and preserve them when one data source temporarily has no entry for a hostname. This prevents the "Host" or "Docker" type badge from disappearing and reappearing when websocket updates cause momentary state inconsistencies. The fix only preserves types if the corresponding source array has any data at all, ensuring that intentional host removal (both arrays empty for that host) still works correctly. Related to #773	2025-12-02 11:29:03 +00:00
rcourtman	f4e3f625e7	test: Add CheckGuest tests (41.4%→97.4%) ... Cover all CheckGuest branches: - Early return when alerts disabled - Early return when all guests disabled - VM and Container type handling - Unsupported guest type returns early - pulse-no-alerts tag suppresses alerts - Stopped guest triggers powered-off check - DisableAllGuestsOffline clears tracking - Paused guest clears powered-off alert - Non-running guest clears metric alerts - Running guest clears powered-off alert - Disabled thresholds clear existing alerts - CPU, memory, disk metric checks - Individual disk checks (mountpoint, device, index fallback) - Skips disk with zero total or negative usage - I/O metrics (diskRead, diskWrite, networkIn, networkOut) - pulse-relaxed tag applies relaxed thresholds Alerts package coverage: 76.0%→78.6%	2025-12-02 11:27:32 +00:00
rcourtman	4ceb4f9a35	test: Add CheckNode tests (31%→100%) ... Cover all CheckNode branches: - Early return when alerts disabled - DisableAllNodes clears existing alerts - DisableNodesOffline clears tracking - Offline/connection error/failed triggers offline check - Online node clears offline alert - Online node triggers metric checks - Offline node skips metric checks - Override thresholds applied correctly - Temperature with package temp and max fallback - Temperature skipped when unavailable/nil/no threshold - Memory and disk metric checks Alerts package coverage: 75.2%→76.0%	2025-12-02 11:24:04 +00:00
rcourtman	9791fc07cb	test: Add suppressGuestAlerts and guestHasMonitorOnlyAlerts tests ... Coverage improvements: - suppressGuestAlerts: 37% -> 96.3% - guestHasMonitorOnlyAlerts: 40% -> 90% Tests cover: - No alerts returns false - Exact ResourceID match clears - Prefix match (e.g., "vm100/disk1") clears - All auxiliary maps cleared (pending, recent, suppressed, rateLimit) - Multiple alerts cleared - Monitor-only detection via metadata (bool and string types)	2025-12-02 11:14:30 +00:00
rcourtman	f661c5a6a8	test: Add applyThresholdOverride tests ... Coverage for applyThresholdOverride: 50% -> 93.2% Tests cover: - Empty override returns base unchanged - Disabled/DisableConnectivity flag overrides - Modern CPU threshold override - Legacy CPU threshold conversion - Modern takes precedence over legacy - Multiple metrics override - Note override, clearing, trimming - All legacy metric types (Memory, Disk, etc.) - Temperature and Usage override - ensureHysteresisThreshold Clear value filling	2025-12-02 11:08:58 +00:00
rcourtman	ed118c973f	test: Add ClearActiveAlerts test with existing alerts ... Coverage for ClearActiveAlerts: 16% -> 92% Tests verify all internal maps are properly cleared when alerts exist: - activeAlerts, pendingAlerts, recentAlerts - suppressedUntil, alertRateLimit - nodeOfflineCount, offlineConfirmations - dockerOfflineCount, dockerStateConfirm - ackState, recentlyResolved	2025-12-02 11:01:54 +00:00
rcourtman	219c568649	test: Add CheckDiskHealth normal path tests ... Coverage for CheckDiskHealth: 51% -> 98% Tests cover: - Healthy disk (PASSED/OK) creates no alert - Failed non-Samsung disk creates critical alert - Alert cleared when disk health recovers - Low wearout (<10%) creates warning alert - Wearout alert updates on subsequent checks - Wearout alert cleared when wearout >= 10% - Empty/UNKNOWN health creates no alert	2025-12-02 10:59:48 +00:00
rcourtman	c04d559700	test: Add Docker container restart loop alert tests ... Coverage for checkDockerContainerRestartLoop: 53.5% -> 95.3% Tests cover: - First check initializes tracking without alert - Stable restart count doesn't alert - Restarts under threshold (<=3) don't alert - Restart loop threshold (>3) triggers critical alert - Recovery after window expires clears alert - Incremental restart accumulation - Alert StartTime preservation on updates	2025-12-02 10:54:51 +00:00
rcourtman	b6624e32cf	test: Add Docker container health and OOM kill alert tests ... Coverage improvements: - checkDockerContainerHealth: 21.1% -> 94.7% - checkDockerContainerOOMKill: 19.2% -> 96.2% Tests cover: - Health states (healthy, empty, none, starting, unhealthy, degraded) - Health alert recovery when container becomes healthy - OOM kill detection (exit code 137) - OOM alert deduplication (repeated 137 doesn't re-alert) - OOM alert clearing when container recovers or exits with different code	2025-12-02 10:49:42 +00:00
rcourtman	1ed8b18c12	fix: Deadlock in CancelByAlertIDs and add tests ... Fixed deadlock where CancelByAlertIDs held nq.mu.Lock() and then called UpdateStatus() which also tried to acquire the same lock. Now uses direct SQL while holding the lock. Tests added for CancelByAlertIDs: - No matching notifications (notification stays pending) - Matching notification cancelled - Multiple alerts with partial match (any match cancels) Coverage: CancelByAlertIDs 65.7% -> 81.1%	2025-12-02 10:40:07 +00:00
rcourtman	5ef4587767	test: Add queue IncrementAttempt and GetQueueStats tests ... Coverage improvements: - IncrementAttempt: 0% -> 85.7% - GetQueueStats: 0% -> 87.5% Tests verify attempt counter increments correctly and queue stats aggregate notification counts by status.	2025-12-02 10:31:00 +00:00
rcourtman	e27717f1a2	test: Add secure webhook client tests for redirect handling ... Tests SSRF protection in webhook client: - Redirect limit enforcement (max 3) - Blocking redirects to private networks (10.x, 192.168.x, 172.16.x) - Blocking redirects to link-local addresses (169.254.x) - Allowing valid redirects to allowlisted servers Coverage: createSecureWebhookClient 18.2% -> 100%	2025-12-02 10:26:34 +00:00
rcourtman	9118344355	fix: Isolate alerts tests with temp directories to prevent flaky failures ... Tests using NewManager() were sharing /etc/pulse/alerts, causing race conditions when running in parallel. Added newTestManager(t) helper that creates isolated temp directories for each test.	2025-12-02 10:21:03 +00:00
rcourtman	350d21c80d	test: Add diagnostics function tests for error handling ... Add comprehensive tests for untested diagnostics functions: - fingerprintPublicKey: 14 test cases covering empty/whitespace input, invalid key formats, truncated/malformed keys, and valid ED25519 keys - countLegacySSHKeys: 8 test cases covering non-existent directories, empty directories, files without id_ prefix, multiple key types, and directory filtering (subdirectories not counted) - resolveUserName: 4 test cases covering UID 0 (root), current user, non-existent UID fallback, and max uint32 boundary - resolveGroupName: 4 test cases covering GID 0 (root/wheel), current group, non-existent GID fallback, and max uint32 boundary Coverage: fingerprintPublicKey 0% -> 100%, countLegacySSHKeys 0% -> 100%, resolveUserName 0% -> 100%, resolveGroupName 0% -> 100%	2025-12-02 03:39:52 +00:00
rcourtman	b053a2848b	fix: Update TestPublicURLDetectionUsesForwardedHeaders for proxy hardening ... The test was failing after commit d6cbfc23 added security hardening that requires authentication and trusted proxy configuration for X-Forwarded-* headers to be read during public URL detection. - Add API token authentication to the test request - Configure 127.0.0.1 as trusted proxy for the test - Add export_test.go with ResetTrustedProxyConfigForTests() to allow external tests to reset the trusted proxy configuration	2025-12-02 03:16:52 +00:00
rcourtman	201f613ac3	test: Add sendNotificationsDirect email and apprise tests ... Test email enabled and apprise enabled code paths. Coverage: 66.7% → 100.0%	2025-12-02 03:08:35 +00:00
rcourtman	37ec6c3a93	test: Add scanNotification DLQ timestamp test ... Test scanNotification with CompletedAt and LastAttempt populated via DLQ path. Coverage: 61.9% → 81.0%	2025-12-02 03:04:37 +00:00
rcourtman	99a6debd3a	fix: Update Channel setting not persisting after save ... The Update Channel dropdown reverted to "stable" after saving because the frontend was overwriting the user's saved preference with the running version's channel. Now the saved setting takes priority over the detected channel. Related to #738	2025-12-02 03:03:51 +00:00
rcourtman	ae54cfad8c	test: Add processNotification tests for all code paths ... Test cancelled notification, no processor, success, and failure paths. Coverage: 50.0% → 80.0%	2025-12-02 03:01:17 +00:00
rcourtman	ca7da7c18f	test: Add CancelByAlertIDs empty input and no-match tests ... Test early return for empty alertIDs and happy path with empty queue. Coverage: 62.9% → 65.7%	2025-12-02 02:58:10 +00:00
rcourtman	7a1c9ff53f	test: Add SaveNodesConfigAllowEmpty test and document deadlock ... Add test for SaveNodesConfigAllowEmpty which permits explicit deletion of all nodes. Document deadlock bug in saveNodesConfig where empty config protection tries to call LoadNodesConfig while holding write lock.	2025-12-02 02:54:49 +00:00
rcourtman	d0fc62d45f	test: Add LoadNodesConfig PBS/PMG migration tests ... Test PBS and PMG token clearing and host normalization migrations. Coverage: 61.4% → 76.3%	2025-12-02 02:46:47 +00:00
rcourtman	6d1eb44f7b	test: Add LoadEmailConfig encrypted round-trip test ... Test Save+Load with encryption enabled to cover success path after decryption. Coverage: 58.8% → 88.2%	2025-12-02 02:43:49 +00:00
rcourtman	3c1ae26166	test: Add LoadWebhooks migration and error path tests ... Cover unencrypted .enc file migration fallback and legacy file with invalid JSON graceful handling. Coverage: 67.9% → 75.0%	2025-12-02 02:39:04 +00:00
rcourtman	9eb7c59a4d	test: Add SaveAlertConfig host defaults normalization tests ... Cover nil HostDefaults initialization (CPU/Memory/Disk) and clear threshold computation when clear=0 but trigger is set. Coverage: 68.2% → 75.3%	2025-12-02 02:37:01 +00:00