940 commits

Author	SHA1	Message	Date
rcourtman	1073c511b3	test: Add RequireAdmin tests for API package ... Add comprehensive tests for the RequireAdmin middleware covering: - No auth configured (allows access by design) - API-only mode (rejects requests without token) - Basic auth with invalid credentials - Proxy auth with admin role (allowed) - Proxy auth with non-admin role (forbidden) - Proxy auth with invalid secret (unauthorized) - Proxy auth without role header (defaults to admin) - Proxy auth with custom role separator - Proxy auth with spaces in roles (trimmed) - Basic auth authenticated users (allowed as admin) - JSON vs plain text error responses based on path/Accept header Also improves CheckProxyAuth coverage as a side effect. Coverage: RequireAdmin 20.8% → 87.5% Coverage: CheckProxyAuth 0.0% → 89.3% Coverage: API package 30.9% → 31.9%	2025-12-02 13:06:06 +00:00
rcourtman	71e15886ed	test: Add isRequestAuthenticated tests for API package ... Add comprehensive tests for the isRequestAuthenticated function covering: - Nil inputs (config, request, both) - Basic auth (valid, invalid password, invalid username, malformed base64, missing colon) - API token via X-API-Token header - API token via Bearer authorization header (case insensitive) - Invalid/empty/whitespace API tokens - No auth configured scenarios - Empty session cookie handling Coverage: isRequestAuthenticated 26.1% → 82.6% Coverage: API package 30.7% → 30.9%	2025-12-02 12:59:18 +00:00
rcourtman	cf6149e884	test: Add CheckCSRF tests for API package ... Add comprehensive tests for the CheckCSRF function covering: - Safe methods (GET, HEAD, OPTIONS) bypass - API token authentication bypass - Basic auth bypass - No session cookie handling - Missing CSRF token rejection with new token issuance - Invalid CSRF token rejection with new token issuance - CSRF token from FormValue - Unsafe methods (POST, PUT, DELETE, PATCH) enforcement Coverage: CheckCSRF 32.0% → 96.0% Coverage: API package 30.5% → 30.7%	2025-12-02 12:53:32 +00:00
rcourtman	5deca850d4	test: Add saveHistoryWithRetry tests for alerts package ... Add comprehensive tests for the saveHistoryWithRetry function covering: - Backup file creation from existing history - Empty history serialization - Single retry success - Read-only directory failure with retries - Concurrent saves with serialization via saveMu - Snapshot isolation during save Coverage: saveHistoryWithRetry 58.6% → 86.2% Coverage: alerts package 87.4% → 87.8%	2025-12-02 12:49:27 +00:00
rcourtman	cd33c577f8	test: Add resolvePublicURL tests for API package ... Add comprehensive tests for the resolvePublicURL function covering: - Configured PublicURL (simple, trailing slashes, ports, whitespace) - Request-derived URL (HTTP, HTTPS via TLS, X-Forwarded-Proto) - No host fallback (with/without frontend port) - Nil request handling Coverage: resolvePublicURL 12.5% → 100% Coverage: API package 30.3% → 30.5%	2025-12-02 12:45:04 +00:00
rcourtman	80739cce94	test: Add rescheduleTask tests for monitoring package ... Add comprehensive tests for the rescheduleTask function covering: - Nil taskQueue handling (early return) - Successful task outcome (regular rescheduling) - Transient failure with backoff - Non-transient failure routing to dead letter queue - Exceeded retry attempts routing to dead letter queue - No outcome uses default interval - PBS and PMG instance type intervals - Adaptive polling max interval capping - Existing interval preservation Coverage: rescheduleTask 32.1% → 58.9% Coverage: monitoring package 52.8% → 53.5%	2025-12-02 12:38:50 +00:00
rcourtman	2842dded28	test: Add getGuestThresholds tests for alerts package ... Add comprehensive tests for the getGuestThresholds function covering: - Default threshold application - Guest-specific overrides - Custom rule filter matching - Override precedence over custom rules - Priority-based rule selection - Disabled rules handling - Disabled override handling - DisableConnectivity propagation from overrides and rules - Legacy CPU threshold conversion - Legacy ID migration (clustered and standalone VMs) - Container type support - All metric thresholds application Coverage: getGuestThresholds 40.2% → 77.6%	2025-12-02 12:35:07 +00:00
rcourtman	a4e3fe65b8	test: Add preserveAlertState, checkPMGQuarantineBacklog, LoadActiveAlerts tests ... Add comprehensive tests for three low-coverage functions: - preserveAlertState: nil handling, state preservation from existing alerts, ackState fallback, new alert handling - checkPMGQuarantineBacklog: nil quarantine handling, warning/critical thresholds, growth rate alerts, alert updates, virus quarantine - LoadActiveAlerts: missing file, valid file loading, old alert filtering, old acknowledged alert filtering, ack state restoration, invalid JSON, duplicate alert handling Coverage improvements: - preserveAlertState: 63.6% → 100% - checkPMGQuarantineBacklog: 12.9% → 100% - checkQuarantineMetric: 0% → 93.1% - LoadActiveAlerts: 26.2% → 80.0% - Alerts package: 83.5% → 86.6%	2025-12-02 12:22:14 +00:00
rcourtman	2133b25bb7	test: Add performCleanup tests for notifications queue ... Add 4 tests covering the performCleanup function: - cleanup removes old completed entries (>7 days) - cleanup removes old DLQ entries (>30 days) - cleanup removes old audit logs (>30 days) - cleanup with empty database (no panic) performCleanup coverage: 0% → 87.0% Notifications package: 57.3% → 58.3%	2025-12-02 12:16:55 +00:00
rcourtman	a6f4fc7bc0	test: Add GetQueue, addWebhookDelivery, GetWebhookHistory tests ... Tests for NotificationManager accessor and helper functions. Covers queue retrieval, webhook delivery tracking, history trimming to max 100 entries, and copy-on-read semantics. Notifications 56.6%→57.3%.	2025-12-02 12:10:29 +00:00
rcourtman	f184174f2b	test: Add HistoryManager tests for alerts package ... New history_test.go with 24 tests covering GetStats, getFileSize, AddAlert, GetHistory, GetAllHistory, RemoveAlert, ClearAllHistory, cleanOldEntries, saveHistory, loadHistory. Alerts package 83.6%→84.0%.	2025-12-02 12:06:53 +00:00
rcourtman	fc96ba7b69	test: Add WaitNext and key() tests for TaskQueue ... Tests cover context cancellation, immediately due tasks, waiting for future tasks, empty queue timeout, and multiple task priority ordering. WaitNext coverage 0%→92.3%, key() 0%→100%. Monitoring package 52.3%→52.9%.	2025-12-02 12:02:13 +00:00
rcourtman	e63c297ca3	test: Add BuildPlan, FilterDue, DispatchDue, LastScheduled tests ... Comprehensive tests for AdaptiveScheduler methods covering empty inventory, single/multiple instances, priority ordering, interval clamping, task caching, nil receiver handling, and task filtering. Monitoring package 51.4%→52.3%.	2025-12-02 11:59:37 +00:00
rcourtman	ea120b78d7	test: Add RecordNodeResult, RecordQueueWait, SetQueueDepth tests ... Improves metrics.go coverage to 100%. Added comprehensive tests for node-level poll metrics, queue wait time recording, and queue depth setting with edge cases (nil receiver, negative values, label normalization).	2025-12-02 11:57:05 +00:00
rcourtman	47d0fb5a44	test: Add dispatchAlert tests (55.6%→77.8%) ... Add TestDispatchAlert with 8 test cases covering: - Returns false when onAlert callback is nil - Returns false when alert is nil - Returns false when activation state is pending - Returns false when activation state is snoozed - Returns false for monitor-only alerts - Dispatches synchronously when async is false - Dispatches asynchronously when async is true - Clones alert before dispatch Alerts package coverage: 83.4%→83.5%	2025-12-02 11:47:24 +00:00
rcourtman	b3bf63d3c7	test: Add CheckStorage tests (52.4%→92.9%) ... Add comprehensive TestCheckStorageComprehensive with 11 test cases covering: - Returns early when alerts disabled - DisableAllStorage clears existing usage and offline alerts - Override with Disabled clears alerts - Usage threshold checking - Override threshold applied correctly - Skips usage check when offline/unavailable/zero usage - Offline status creates alert after confirmations - Unavailable status creates alert - Clears offline alert when back online Alerts package coverage: 82.4%→83.4%	2025-12-02 11:43:56 +00:00
rcourtman	9127b27f4c	test: Add CheckPMG tests (0%→100%) ... Add comprehensive TestCheckPMGComprehensive with 9 test cases covering: - Returns early when alerts disabled - DisableAllPMG clears all PMG alert types (queue-total, queue-deferred, queue-hold, oldest-message, offline) - Override with Disabled clears alerts - DisableAllPMGOffline clears offline alert - Offline status creates alert after confirmations - Connection health error triggers offline alert - Connection health unhealthy triggers offline alert - Clears offline alert when back online - Skips metrics when PMG is offline Alerts package coverage: 81.5%→82.4%	2025-12-02 11:40:53 +00:00
rcourtman	073d5ffa55	fix: Use --ctid instead of --standalone --http-mode in quick-setup command ... The quick-setup command for temperature monitoring was generating --standalone --http-mode which is meant for Docker deployments. This confused users trying to set up multi-server Proxmox monitoring. Now uses --ctid which works for both local and remote Proxmox hosts. The installer detects when the container doesn't exist locally and installs in "host monitoring only" mode automatically. If we can determine the actual CTID from the host proxy summary, we use it; otherwise we show <PULSE_CTID> for the user to replace. Related to #785	2025-12-02 11:38:47 +00:00
rcourtman	9f174be20b	test: Add CheckPBS tests (0%→98.3%) ... Add comprehensive TestCheckPBSComprehensive with 12 test cases covering: - Returns early when alerts disabled - DisableAllPBS clears existing CPU/memory/offline alerts - Override with Disabled clears alerts - DisableAllPBSOffline clears offline alert - CPU threshold checking when online - Memory threshold checking when online - Skips metrics when PBS is offline - Override thresholds applied correctly - Offline status creates alert after confirmations - Connection health error triggers offline alert - Connection health unhealthy triggers offline alert - Clears offline alert when back online Alerts package coverage: 80.0%→81.5%	2025-12-02 11:38:36 +00:00
rcourtman	13f5ca4018	test: Add CheckHost tests (49.6%→98.3%) ... Add comprehensive TestCheckHostComprehensive with 17 test cases covering: - Empty host ID early return - Alerts disabled early return - DisableAllHosts clears existing alerts - Override with Disabled clears alerts - CPU/Memory/Disk threshold nil clears alerts - RAID degraded/rebuilding/healthy states - RAID with failed devices triggers critical alert - RAID resync triggers rebuilding alert - Existing RAID alert not duplicated (preserves start time) - Override thresholds applied correctly - Multiple disks handling - Offline alert cleared when host comes online - Tags included in metadata Alerts package coverage: 78.6%→80.0%	2025-12-02 11:34:20 +00:00
rcourtman	f4e3f625e7	test: Add CheckGuest tests (41.4%→97.4%) ... Cover all CheckGuest branches: - Early return when alerts disabled - Early return when all guests disabled - VM and Container type handling - Unsupported guest type returns early - pulse-no-alerts tag suppresses alerts - Stopped guest triggers powered-off check - DisableAllGuestsOffline clears tracking - Paused guest clears powered-off alert - Non-running guest clears metric alerts - Running guest clears powered-off alert - Disabled thresholds clear existing alerts - CPU, memory, disk metric checks - Individual disk checks (mountpoint, device, index fallback) - Skips disk with zero total or negative usage - I/O metrics (diskRead, diskWrite, networkIn, networkOut) - pulse-relaxed tag applies relaxed thresholds Alerts package coverage: 76.0%→78.6%	2025-12-02 11:27:32 +00:00
rcourtman	4ceb4f9a35	test: Add CheckNode tests (31%→100%) ... Cover all CheckNode branches: - Early return when alerts disabled - DisableAllNodes clears existing alerts - DisableNodesOffline clears tracking - Offline/connection error/failed triggers offline check - Online node clears offline alert - Online node triggers metric checks - Offline node skips metric checks - Override thresholds applied correctly - Temperature with package temp and max fallback - Temperature skipped when unavailable/nil/no threshold - Memory and disk metric checks Alerts package coverage: 75.2%→76.0%	2025-12-02 11:24:04 +00:00
rcourtman	9791fc07cb	test: Add suppressGuestAlerts and guestHasMonitorOnlyAlerts tests ... Coverage improvements: - suppressGuestAlerts: 37% -> 96.3% - guestHasMonitorOnlyAlerts: 40% -> 90% Tests cover: - No alerts returns false - Exact ResourceID match clears - Prefix match (e.g., "vm100/disk1") clears - All auxiliary maps cleared (pending, recent, suppressed, rateLimit) - Multiple alerts cleared - Monitor-only detection via metadata (bool and string types)	2025-12-02 11:14:30 +00:00
rcourtman	f661c5a6a8	test: Add applyThresholdOverride tests ... Coverage for applyThresholdOverride: 50% -> 93.2% Tests cover: - Empty override returns base unchanged - Disabled/DisableConnectivity flag overrides - Modern CPU threshold override - Legacy CPU threshold conversion - Modern takes precedence over legacy - Multiple metrics override - Note override, clearing, trimming - All legacy metric types (Memory, Disk, etc.) - Temperature and Usage override - ensureHysteresisThreshold Clear value filling	2025-12-02 11:08:58 +00:00
rcourtman	ed118c973f	test: Add ClearActiveAlerts test with existing alerts ... Coverage for ClearActiveAlerts: 16% -> 92% Tests verify all internal maps are properly cleared when alerts exist: - activeAlerts, pendingAlerts, recentAlerts - suppressedUntil, alertRateLimit - nodeOfflineCount, offlineConfirmations - dockerOfflineCount, dockerStateConfirm - ackState, recentlyResolved	2025-12-02 11:01:54 +00:00
rcourtman	219c568649	test: Add CheckDiskHealth normal path tests ... Coverage for CheckDiskHealth: 51% -> 98% Tests cover: - Healthy disk (PASSED/OK) creates no alert - Failed non-Samsung disk creates critical alert - Alert cleared when disk health recovers - Low wearout (<10%) creates warning alert - Wearout alert updates on subsequent checks - Wearout alert cleared when wearout >= 10% - Empty/UNKNOWN health creates no alert	2025-12-02 10:59:48 +00:00
rcourtman	c04d559700	test: Add Docker container restart loop alert tests ... Coverage for checkDockerContainerRestartLoop: 53.5% -> 95.3% Tests cover: - First check initializes tracking without alert - Stable restart count doesn't alert - Restarts under threshold (<=3) don't alert - Restart loop threshold (>3) triggers critical alert - Recovery after window expires clears alert - Incremental restart accumulation - Alert StartTime preservation on updates	2025-12-02 10:54:51 +00:00
rcourtman	b6624e32cf	test: Add Docker container health and OOM kill alert tests ... Coverage improvements: - checkDockerContainerHealth: 21.1% -> 94.7% - checkDockerContainerOOMKill: 19.2% -> 96.2% Tests cover: - Health states (healthy, empty, none, starting, unhealthy, degraded) - Health alert recovery when container becomes healthy - OOM kill detection (exit code 137) - OOM alert deduplication (repeated 137 doesn't re-alert) - OOM alert clearing when container recovers or exits with different code	2025-12-02 10:49:42 +00:00
rcourtman	1ed8b18c12	fix: Deadlock in CancelByAlertIDs and add tests ... Fixed deadlock where CancelByAlertIDs held nq.mu.Lock() and then called UpdateStatus() which also tried to acquire the same lock. Now uses direct SQL while holding the lock. Tests added for CancelByAlertIDs: - No matching notifications (notification stays pending) - Matching notification cancelled - Multiple alerts with partial match (any match cancels) Coverage: CancelByAlertIDs 65.7% -> 81.1%	2025-12-02 10:40:07 +00:00
rcourtman	5ef4587767	test: Add queue IncrementAttempt and GetQueueStats tests ... Coverage improvements: - IncrementAttempt: 0% -> 85.7% - GetQueueStats: 0% -> 87.5% Tests verify attempt counter increments correctly and queue stats aggregate notification counts by status.	2025-12-02 10:31:00 +00:00
rcourtman	e27717f1a2	test: Add secure webhook client tests for redirect handling ... Tests SSRF protection in webhook client: - Redirect limit enforcement (max 3) - Blocking redirects to private networks (10.x, 192.168.x, 172.16.x) - Blocking redirects to link-local addresses (169.254.x) - Allowing valid redirects to allowlisted servers Coverage: createSecureWebhookClient 18.2% -> 100%	2025-12-02 10:26:34 +00:00
rcourtman	9118344355	fix: Isolate alerts tests with temp directories to prevent flaky failures ... Tests using NewManager() were sharing /etc/pulse/alerts, causing race conditions when running in parallel. Added newTestManager(t) helper that creates isolated temp directories for each test.	2025-12-02 10:21:03 +00:00
rcourtman	350d21c80d	test: Add diagnostics function tests for error handling ... Add comprehensive tests for untested diagnostics functions: - fingerprintPublicKey: 14 test cases covering empty/whitespace input, invalid key formats, truncated/malformed keys, and valid ED25519 keys - countLegacySSHKeys: 8 test cases covering non-existent directories, empty directories, files without id_ prefix, multiple key types, and directory filtering (subdirectories not counted) - resolveUserName: 4 test cases covering UID 0 (root), current user, non-existent UID fallback, and max uint32 boundary - resolveGroupName: 4 test cases covering GID 0 (root/wheel), current group, non-existent GID fallback, and max uint32 boundary Coverage: fingerprintPublicKey 0% -> 100%, countLegacySSHKeys 0% -> 100%, resolveUserName 0% -> 100%, resolveGroupName 0% -> 100%	2025-12-02 03:39:52 +00:00
rcourtman	b053a2848b	fix: Update TestPublicURLDetectionUsesForwardedHeaders for proxy hardening ... The test was failing after commit d6cbfc23 added security hardening that requires authentication and trusted proxy configuration for X-Forwarded-* headers to be read during public URL detection. - Add API token authentication to the test request - Configure 127.0.0.1 as trusted proxy for the test - Add export_test.go with ResetTrustedProxyConfigForTests() to allow external tests to reset the trusted proxy configuration	2025-12-02 03:16:52 +00:00
rcourtman	201f613ac3	test: Add sendNotificationsDirect email and apprise tests ... Test email enabled and apprise enabled code paths. Coverage: 66.7% → 100.0%	2025-12-02 03:08:35 +00:00
rcourtman	37ec6c3a93	test: Add scanNotification DLQ timestamp test ... Test scanNotification with CompletedAt and LastAttempt populated via DLQ path. Coverage: 61.9% → 81.0%	2025-12-02 03:04:37 +00:00
rcourtman	ae54cfad8c	test: Add processNotification tests for all code paths ... Test cancelled notification, no processor, success, and failure paths. Coverage: 50.0% → 80.0%	2025-12-02 03:01:17 +00:00
rcourtman	ca7da7c18f	test: Add CancelByAlertIDs empty input and no-match tests ... Test early return for empty alertIDs and happy path with empty queue. Coverage: 62.9% → 65.7%	2025-12-02 02:58:10 +00:00
rcourtman	7a1c9ff53f	test: Add SaveNodesConfigAllowEmpty test and document deadlock ... Add test for SaveNodesConfigAllowEmpty which permits explicit deletion of all nodes. Document deadlock bug in saveNodesConfig where empty config protection tries to call LoadNodesConfig while holding write lock.	2025-12-02 02:54:49 +00:00
rcourtman	d0fc62d45f	test: Add LoadNodesConfig PBS/PMG migration tests ... Test PBS and PMG token clearing and host normalization migrations. Coverage: 61.4% → 76.3%	2025-12-02 02:46:47 +00:00
rcourtman	6d1eb44f7b	test: Add LoadEmailConfig encrypted round-trip test ... Test Save+Load with encryption enabled to cover success path after decryption. Coverage: 58.8% → 88.2%	2025-12-02 02:43:49 +00:00
rcourtman	3c1ae26166	test: Add LoadWebhooks migration and error path tests ... Cover unencrypted .enc file migration fallback and legacy file with invalid JSON graceful handling. Coverage: 67.9% → 75.0%	2025-12-02 02:39:04 +00:00
rcourtman	9eb7c59a4d	test: Add SaveAlertConfig host defaults normalization tests ... Cover nil HostDefaults initialization (CPU/Memory/Disk) and clear threshold computation when clear=0 but trigger is set. Coverage: 68.2% → 75.3%	2025-12-02 02:37:01 +00:00
rcourtman	9027ab359b	test: Add StageFile transaction tests ... Cover success path, already committed error, replacing existing staged file, and empty basename edge case.	2025-12-02 02:34:20 +00:00
rcourtman	6cb12bd048	test: Add ImportConfig error path tests ... Cover empty passphrase, invalid base64, wrong passphrase decryption failure, and invalid JSON content error paths. Coverage: 66.7% → 73.7%	2025-12-02 02:32:06 +00:00
rcourtman	0d482f9d63	test: Add DiscoveryConfig UnmarshalJSON tests ... Cover invalid JSON error path, modern field parsing, legacy field parsing, and empty object default handling. Coverage: 60% → 88.9%	2025-12-02 02:29:38 +00:00
rcourtman	071ccc44ec	test: Add ProcessQueuedNotification error path tests ... Cover invalid config JSON for email, webhook, and apprise types, plus unknown notification type handling. Coverage: 63.3% → 83.3%	2025-12-02 02:26:25 +00:00
rcourtman	7a63cf3be9	test: Add sendNotificationsDirect tests ... Cover disabled paths: all channels disabled, webhook disabled, multiple webhooks with mixed enabled state. Coverage: 44.4% → 66.7%	2025-12-02 02:21:46 +00:00
rcourtman	ea04e4faae	test: Add sendHTMLEmailWithError tests ... Cover email sending paths: empty To uses From as recipient, nil email manager creates new one, existing manager config updates. Coverage: 57.9% → 89.5%	2025-12-02 02:19:49 +00:00
rcourtman	9768316e07	test: Add sendGroupedApprise error path tests ... Add 3 tests for Apprise notification error handling: - No alerts returns error - Not enabled returns error - Empty payload (all nil alerts) returns error Coverage: 56.2% → 75.0%	2025-12-02 02:14:13 +00:00
rcourtman	42e7359506	test: Add describeInstancesForScheduler tests ... Add 6 tests for instance descriptor generation: - No clients returns nil - PVE only with sorted order - PBS only - PMG only - All types combined - Nil scheduler/stalenessTracker safety Coverage: 60.7% → 62.5%	2025-12-02 02:11:14 +00:00
rcourtman	de90519b21	test: Add handleHealth method tests ... Add 2 tests for health endpoint: - POST/PUT/DELETE/PATCH return 405 Method Not Allowed - HEAD is allowed (same as GET) Coverage: 50% → 83.3%	2025-12-02 02:09:04 +00:00
rcourtman	2d09c28129	test: Add recordTaskResult tests ... Add 6 tests for polling task result recording: - Nil monitor safety check - Success case resets counters - Failure case increments counters - Consecutive failures tracking - Success resets failure state - Nil internal maps don't panic Coverage: 53.7% → 97.6%	2025-12-02 02:06:08 +00:00
rcourtman	67d322c456	test: Add ApplyHostReport error path tests ... Add 4 tests for error and edge cases: - Missing hostname returns error - Whitespace-only hostname returns error - Nil hostTokenBindings map is initialized - Fallback identifier generation Coverage: 63.7% → 70.8%	2025-12-02 02:03:03 +00:00
rcourtman	7c94f3001e	test: Add ApplyDockerReport error path tests ... Add 4 tests for error conditions: - Missing identifier (no agent ID or hostname) - Removed host rejection - Token bound to different agent - Missing hostname Coverage: 63.0% → 69.5%	2025-12-02 02:00:06 +00:00
rcourtman	781f72c953	test: Add RemoveHostAgent error path tests ... Add 4 tests for uncovered branches: - Empty/whitespace hostID returns error - Host not found returns synthetic host - No token binding (token exists but not bound) - Nil alertManager doesn't panic Coverage: 64.3% → 78.6%	2025-12-02 01:56:50 +00:00
rcourtman	5ff69a7e35	test: Add adminBypassEnabled tests ... Add 5 tests to cover all branches: - Not requested (ALLOW_ADMIN_BYPASS != "1") - Enabled with PULSE_DEV=true - Enabled with NODE_ENV=development - Case-insensitive NODE_ENV check - Declined when outside dev mode Coverage: 40% → 100%	2025-12-02 01:53:55 +00:00
rcourtman	7ed8ef2074	test: Add loadTrustedProxyCIDRs tests ... Cover invalid CIDR, invalid IP, IPv6, and empty entry handling (48% to 100%)	2025-12-02 01:48:41 +00:00
rcourtman	24fbce1281	test: Add LogAuditEvent tests ... Cover success and failure logging branches (66.7% to 100%)	2025-12-02 01:46:27 +00:00
rcourtman	8f42156781	test: Add SecurityHeadersWithConfig tests ... Cover all CSP/X-Frame-Options embedding configurations (57.1% to 100%)	2025-12-02 01:44:22 +00:00
rcourtman	07997b3516	test: Add filesystem error tests for SessionStore ... Cover saveUnsafe (57.9% to 89.5%) and load (55.6% to 74.1%) error paths	2025-12-02 01:40:54 +00:00
rcourtman	21b69607f0	test: Add filesystem error tests for CSRFTokenStore ... Cover saveUnsafe (57.9% to 89.5%) and load (50.0% to 67.9%) error paths	2025-12-02 01:38:49 +00:00
rcourtman	999f19beed	test: Add filesystem error tests for RecoveryTokenStore.saveUnsafe ... Cover MkdirAll, WriteFile, and Rename error paths (46.7% to 86.7%)	2025-12-02 01:36:21 +00:00
rcourtman	b3f88d7a8c	test: Add edge case tests for HandleSetupScript ... Tests method not allowed, missing type parameter, and invalid host parameter error paths (71.4% to 79.2% coverage).	2025-12-02 01:11:57 +00:00
rcourtman	c080a6beb6	test: Add DNS resolution failure test for ValidateWebhookURL ... Tests the error path when webhook hostname cannot be resolved (78.1% to 81.2% coverage).	2025-12-02 01:09:03 +00:00
rcourtman	7d3de1bbcc	test: Add invalid PEM data test for newOIDCHTTPClient ... Tests the error path when a CA bundle file contains non-PEM data (81.8% to 86.4% coverage).	2025-12-02 01:00:06 +00:00
rcourtman	1a595b3b2e	test: Add edge cases for UniversalRateLimitMiddleware ... Cover nil config initialization and static asset bypass paths. Coverage: UniversalRateLimitMiddleware 87.5% -> 100%	2025-12-02 00:54:37 +00:00
rcourtman	c57c07f827	test: Add edge case for initializeBootstrapToken error path ... Cover loadOrCreateBootstrapToken failure path. Coverage: initializeBootstrapToken 92% -> 100%	2025-12-02 00:51:44 +00:00
rcourtman	a5f0482d97	test: Add edge cases for HandleLookup error paths ... Cover method-not-allowed and missing lookup parameter paths. Coverage: HandleLookup 88.4% -> 97.7%	2025-12-02 00:49:16 +00:00
rcourtman	44b835ad15	test: Add critical-only grouped alert template case ... Test multiple critical alerts without warnings to cover the "critical > 0" only branch in subject line generation. Coverage: 97.7% → 100%	2025-12-02 00:40:02 +00:00
rcourtman	96bf0b0ca6	test: Add edge cases for buildApprisePayload ... - Test nil alerts in list are filtered out - Test all-nil alert list returns empty - Test multiple alerts changes title format Coverage: 88.9% → 100%	2025-12-02 00:37:28 +00:00
rcourtman	296a520d81	test: Add edge case for extractTelegramChatID URL parse error ... Test URL with control characters triggers url.Parse error path. Coverage: 92.9% → 100%	2025-12-02 00:31:50 +00:00
rcourtman	890a2f792d	test: Add edge case for NormalizeAppriseConfig low timeout ... Test TimeoutSeconds value between 1-4 clamps to minimum of 5. Coverage: 97.4% → 100%	2025-12-02 00:29:12 +00:00
rcourtman	6777257a7a	test: Add edge cases for normalizeRequestedScopes ... - Test blank scope identifier returns error - Test wildcard-only input returns wildcard scope Coverage: 89.7% → 96.6% (remaining 3.4% is defensive unreachable code path)	2025-12-02 00:19:20 +00:00
rcourtman	e07bd834b6	Filter virtual/system filesystems from host disk display ... Host disk bars were showing virtual filesystems like tmpfs, /dev, /run, /sys, and Docker overlay mounts. These clutter the UI and don't represent meaningful disk usage. Changed from `shouldIgnoreReadOnlyFilesystem` (read-only only) to the full `fsfilters.ShouldSkipFilesystem` which also excludes: - Virtual FS types: tmpfs, devtmpfs, sysfs, proc, cgroup, etc. - Special mountpoints: /dev, /proc, /sys, /run, /var/lib/docker, /snap - Network filesystems: fuse, nfs, cifs, etc. Related to #790	2025-12-02 00:16:39 +00:00
rcourtman	b5d42f6e2e	test: Add edge case for ensureSettingsWriteScope valid scope ... Tests the code path when an API token has the settings:write scope, which allows the operation to proceed.	2025-12-02 00:13:32 +00:00
rcourtman	8597eca010	Fix backup indicator being reset when VMs/Containers are re-polled ... UpdateVMsForInstance and UpdateContainersForInstance were replacing guest data without preserving the LastBackup field that was populated by SyncGuestBackupTimes. This caused backup indicators to always show "no backup found" since the LastBackup would be wiped every time guests were polled (which happens more frequently than backup polling). Now both functions preserve LastBackup from existing data when the incoming guest data has a zero value. Related to #762	2025-12-02 00:12:31 +00:00
rcourtman	9baf99d32a	test: Add edge cases for isTrustedProxyIP and GetClientIP ... Tests empty string, invalid IP, and IP not matching CIDR for isTrustedProxyIP. Also adds tests for GetClientIP empty RemoteAddr and X-Real-IP fallback paths.	2025-12-02 00:09:23 +00:00
rcourtman	02419827b6	test: Add tests for hostAgentSearchCandidates parameter variants ... Tests all code paths: strict mode (both params), platform only, and no params (generic paths).	2025-12-02 00:03:19 +00:00
rcourtman	7407447bbf	test: Add edge case for handleServerInfo method not allowed ... Tests that POST requests to /api/server/info return 405.	2025-12-02 00:01:17 +00:00
rcourtman	4751f57187	test: Add edge case for capturePublicURLFromRequest nil inputs ... Tests the early return paths when router, request, or config are nil.	2025-12-01 23:59:17 +00:00
rcourtman	b9f9077496	test: Add edge case for canCapturePublicURL nil inputs ... Tests the early return paths when config or request are nil.	2025-12-01 23:56:59 +00:00
rcourtman	f0688db9af	test: Add edge case for recovery token load read error ... Tests the error logging path when os.ReadFile fails with an error other than ErrNotExist. Uses a directory in place of the file.	2025-12-01 23:54:42 +00:00
rcourtman	347d6b1cbb	test: Add edge case for writeErrorResponse encode failure ... Tests the error logging path when json.Encode fails due to a write error on the ResponseWriter.	2025-12-01 23:52:21 +00:00
rcourtman	90d81f2217	test: Add edge cases for markAutoRegistered empty inputs ... Tests the early return paths when nodeType or nodeName are empty.	2025-12-01 23:50:10 +00:00
rcourtman	3280fad5ae	test: Add edge case for clearBootstrapToken remove failure ... Tests the warning log path when os.Remove fails with an error other than ErrNotExist. Uses a directory with contents to trigger ENOTEMPTY.	2025-12-01 23:47:58 +00:00
rcourtman	678c5aac5f	test: Add edge cases for initializeBootstrapToken ... - Nil router and nil config handling (no panic) - OIDC enabled clears bootstrap token Coverage: 80% to 92%.	2025-12-01 23:40:22 +00:00
rcourtman	8c40c7faa3	test: Add panic recovery test for ErrorHandler ... Tests that panics in handlers are recovered and return 500. Coverage: 91.7% to 100%.	2025-12-01 23:37:50 +00:00
rcourtman	d0c2524353	test: Add edge case for handleValidateBootstrapToken invalid JSON ... Tests invalid JSON body triggers json.Decode error and returns 400. Coverage: 90.5% to 100%.	2025-12-01 23:35:40 +00:00
rcourtman	890178acb0	test: Add edge case for RequireScope empty scope ... Empty scope should allow all requests through without checking token. Coverage: 84.6% to 100%.	2025-12-01 23:33:11 +00:00
rcourtman	0fa717a78a	test: Add edge case for normalizeNodeHost URL parse error ... Control character (null byte) triggers url.Parse error, covering the 'invalid host format' error branch. Coverage: 96.3% to 100%.	2025-12-01 23:28:32 +00:00
rcourtman	08765c7b59	test: Add edge case for DemoModeMiddleware WebSocket POST upgrade ... Tests WebSocket upgrade with POST method in demo mode, ensuring the websocket check branch is exercised after the GET/HEAD/OPTIONS check. Coverage: 90% to 100%.	2025-12-01 23:24:06 +00:00
rcourtman	a5369ba2cd	test: Add test for ErrorHandler empty URL path normalization ... Covers the fix for issue #334 where empty path is normalized to '/'. Coverage: 87.5% to 91.7%.	2025-12-01 23:21:07 +00:00
rcourtman	1fdb15c779	test: Add edge case tests for auth helper functions ... - respondMissingScope: nil writer handling (80% to 100%) - attachAPITokenRecord: nil record handling (80% to 100%) - getAPITokenRecordFromRequest: wrong type and missing value (87.5% to 100%)	2025-12-01 23:15:04 +00:00
rcourtman	c71fb694bb	test: Add edge case test for addQueryParam URL parse error ... Add test case for URL containing control character (null byte) which triggers url.Parse error and returns path unchanged. Coverage improved from 88.9% to 100%.	2025-12-01 23:08:36 +00:00
rcourtman	37cc97952f	test: Add comprehensive test cases for isPrivateIP function ... Expand test coverage from 5 cases to 26 cases: - Public IPv4/IPv6 addresses - All RFC1918 private ranges (10.x, 172.16-31.x, 192.168.x) - Loopback addresses (127.x.x.x, ::1) - Link-local addresses (169.254.x.x, fe80::) - Link-local multicast (224.0.0.x, ff02::) - Unique local IPv6 (fc00::/7, fd00::) - Edge cases: empty string, invalid IP, invalid format - Addresses with port numbers Coverage unchanged at 93.8% (remaining 6.2% is defensive error handling for hardcoded valid CIDRs).	2025-12-01 22:54:56 +00:00
rcourtman	ef380df362	test: Add edge case tests for normalizeNodeHost function ... Add 6 new test cases covering previously untested branches: - Empty host returns error - Whitespace-only host returns error - Unknown node type keeps host without port - Docker node type keeps host without port - IPv4 address gets default port - IPv4 with custom port preserved Coverage improved from 92.6% to 96.3%.	2025-12-01 22:49:29 +00:00
rcourtman	7c27a74c42	test: Add comprehensive tests for PBS snapshot conversion ... Add 13 test cases for convertPBSSnapshots covering: - Empty/nil input handling - Basic snapshot field mapping - Files as string array - Files as object array with filename field - Invalid file objects ignored gracefully - Verification status as string ("ok" vs other) - Verification status as object with state field - Verification object without state field - Multiple snapshots with unique IDs - Empty namespace handling in ID generation - Container (ct) backup type Coverage: convertPBSSnapshots 0% -> 100%	2025-12-01 22:23:47 +00:00
rcourtman	4019b3006b	test: Add tests for instance lookup and setup token validation ... - Add TestFindInstanceNameByHost (12 test cases): - PVE instance lookup by host - PBS instance lookup by host - Unknown node types return empty - Empty config handling - Add TestValidateSetupToken (8 test cases): - Empty token returns false - Valid/expired/used setup codes - Valid/expired recent setup tokens - Non-existent token handling - Precedence of setup codes over recent tokens Both functions now have 100% coverage of their logic paths.	2025-12-01 22:19:30 +00:00
rcourtman	b403cdd7b7	test: Add comprehensive tests for convertDockerTasks function ... - Test nil input returns nil - Test empty slice returns nil - Test single task with all fields populated - Test task with error state (failed tasks) - Test multiple tasks conversion - Test nil time pointers preserved as nil - Test zero time values converted to nil (defensive handling) - Test all optional time fields (UpdatedAt, StartedAt, CompletedAt) Improves monitoring package coverage for Docker Swarm task handling.	2025-12-01 22:13:43 +00:00
rcourtman	67a351fbd9	test: Add tests for webhook template generation and bootstrap token functions ... - Add comprehensive tests for generatePayloadFromTemplateWithService covering: - Valid JSON template rendering - Invalid template syntax error handling - Template execution errors - ntfy service (plain text, skips JSON validation) - Various services (discord, telegram, pagerduty) JSON validation - Template function usage (upper, title) - Numeric and boolean values in templates - Special characters and empty template edge cases - Add tests for bootstrapTokenValid covering: - Nil router handling - Empty hash and empty token cases - Valid token validation - Invalid token rejection - Whitespace trimming - Add tests for clearBootstrapToken covering: - Nil router safety - Token file deletion - Missing file handling - Empty path handling	2025-12-01 22:07:40 +00:00
rcourtman	cb683597c6	test: Add tests for GPU temperature parsing functions ... - parseGPUTemps: AMD GPU edge/junction/mem temperatures, sensor mapping - parseNouveauGPUTemps: NVIDIA nouveau GPU core temperature parsing - Case insensitive sensor name matching - Invalid/zero/negative temperature handling - Append behavior for multiple GPUs	2025-12-01 21:56:33 +00:00
rcourtman	3233c48986	test: Add tests for API helper functions ... - isRecentlyAutoRegistered: expiry logic, cleanup behavior - clearAutoRegistered: key deletion, empty input handling - normalizeDockerAgentArch: all arch variants, case handling, trimming	2025-12-01 21:33:45 +00:00
rcourtman	80702a51bf	test: Add tests for prepareWebhookData function ... Covers webhook payload data preparation: - publicURL handling with trailing slash trimming - alert.Instance URL detection (http/https) - Metadata extraction and copying - Value/Threshold rounding to 1 decimal - AckTime formatting - CustomFields passthrough	2025-12-01 21:27:29 +00:00
rcourtman	833ec0933f	test: Add tests for notification rate limiting and content building ... - checkWebhookRateLimit: rate limit window, counter, per-URL isolation - buildResolvedNotificationContent: single/multiple alerts, nil filtering, HTML escaping, timestamp handling, optional fields	2025-12-01 21:25:02 +00:00
rcourtman	334cffb1c7	test: Add tests for monitor helper and metrics functions ... - clearGuestMetadataCache: nil safety, cache clearing, key isolation - shouldRunBackupPoll: interval-based, cycle-based, config validation - storeNodeLastSuccess/lastNodeSuccessFor: store/retrieve, overwrite, missing keys Improves coverage for backup polling logic and node metrics tracking.	2025-12-01 21:18:33 +00:00
rcourtman	8198e1d839	test: Add comprehensive tests for guest metadata functions ... Tests for rate limiting, retry, and slot management: - retryGuestAgentCall: timeout retry, non-timeout break, context cancellation - acquireGuestMetadataSlot: nil safety, slot acquisition, context cancellation - releaseGuestMetadataSlot: nil safety, non-blocking release - tryReserveGuestMetadataFetch: reservation logic, default hold duration - scheduleNextGuestMetadataFetch: interval, jitter, RNG handling - deferGuestMetadataRetry: backoff logic, defaults Covers error handling and edge cases in guest agent metadata fetching.	2025-12-01 21:10:28 +00:00
rcourtman	a3eb81778f	test: Add table-driven tests for parseSensorsJSON ... Comprehensive coverage for temperature sensor JSON parsing: - Empty/whitespace input handling - Invalid JSON error handling - Legacy and wrapper format support - Multiple chip types: coretemp, k10temp, acpitz, nvme, amdgpu, nouveau, zenpower, nct6795, it87, rp1_adc - Edge cases: non-map chip data, CPUMax calculation from cores	2025-12-01 21:00:46 +00:00
rcourtman	1af38e3f99	test: Add tests for parseContainerMountMetadata, convertContainerDiskInfo, StalenessScore ... - parseContainerMountMetadata: parts without equals, mountpoint key variant, whitespace handling, single source value (96.4% -> 100%) - convertContainerDiskInfo: nil metadata, device from metadata, negative free clamping, whitespace label handling (95.1% -> 97.6%, remaining is dead code) - StalenessScore: negative maxStale default, metrics lookup failure, score clamping edge cases (95.7% - remaining is defensive dead code)	2025-12-01 20:44:00 +00:00
rcourtman	ed0644035f	test: Add tests for sanitizeGuestAddressStrings, parseContainerConfigNetworks, mergeNVMeTempsIntoDisks ... - sanitizeGuestAddressStrings: IPv6 loopback with CIDR (::1/128) edge case (96.2% -> 100%) - parseContainerConfigNetworks: parts without equals, mac/ips/ip6addr/ip6prefix key variants, whitespace-only values, all-empty results (97.2% -> 100%) - mergeNVMeTempsIntoDisks: NVMe disk with no legacy temps (continue branch), more disks than temps (break branch) (97% -> 100%)	2025-12-01 20:34:48 +00:00
rcourtman	4e33b396e0	test: Add tests for normalizeEndpointHost, SelectInterval, generateDockerHostIdentifier ... - normalizeEndpointHost: port-only URL host (parsed.Host fallback), edge cases for URL parsing (94.4% -> 100%) - SelectInterval: negative penalty, instance key derivation, clamping edge cases (96% - remaining is unreachable dead code guards) - generateDockerHostIdentifier: empty base fallbacks, suffix candidates, hash suffix, numeric suffix increments (91.7% -> 100%)	2025-12-01 20:26:21 +00:00
rcourtman	4c91dce2f8	test: Add tests for allow, ensureContainerRootDiskEntry; remove dead code ... - allow (circuitBreaker): all states including unknown/default branch, open→half-open transition, half-open window timing (93.8% -> 100%) - ensureContainerRootDiskEntry: nil container, existing disks, used>total clamping, negative free clamping, usage calculation (92.3% -> 100%) - convertPoolInfoToModel: removed unreachable nil check (dead code since ConvertToModelZFSPool only returns nil for nil receiver) (88.9% -> 100%)	2025-12-01 20:15:32 +00:00
rcourtman	0a9177f161	test: Add tests for lookupClusterEndpointLabel, GetNodeMetrics, stateDetails ... - lookupClusterEndpointLabel: nil instance, no match, Host vs IP fallback, case-insensitive NodeName, whitespace handling (84.6% -> 100%) - GetNodeMetrics: unknown metric types, empty nodeID, zero duration, empty metrics data, disk type (94.1% -> 100%) - stateDetails: all breaker states including unknown/invalid state, retryAt calculations, timestamps (90% -> 100%)	2025-12-01 20:07:22 +00:00
rcourtman	2fdc051c11	fix: Make parseNVMeTemps deterministic by checking Composite before Sensor 1 ... Go map iteration order is non-deterministic, causing flaky test failures. This fix ensures "Composite" sensor is always preferred over "Sensor 1" by checking them in separate loops rather than relying on iteration order.	2025-12-01 20:03:05 +00:00
rcourtman	f79d20296b	test: Add tests for GetGuestMetrics, mergeSnapshot, getDockerCommandPayload ... - GetGuestMetrics: all metric types, duration filtering, guest not found, unknown metric type, empty data (81% -> 100%) - mergeSnapshot: timestamp merging for LastSuccess/LastError/LastMutated, ChangeHash preservation (86.7% -> 100%) - getDockerCommandPayload: empty hostID, whitespace normalization, host not found, expired command cleanup, queued->dispatched marking, already-dispatched preservation (91.3% -> 100%)	2025-12-01 19:58:43 +00:00
rcourtman	196389853e	test: Add tests for StalenessScore, parseCPUTemps, queueDockerStopCommand ... - StalenessScore: 78.3%→95.7% (4 cases for metrics, future timestamp, defaults) - parseCPUTemps: 98.1%→100% (core temp exceeding package case) - queueDockerStopCommand: 76.9%→100% (12 cases for validation, status checks)	2025-12-01 19:50:42 +00:00
rcourtman	2594a6c124	test: Add tests for handleProxyHostFailure, recordNodeSnapshot, evaluateHostAgents ... - handleProxyHostFailure: 76.5%→100% (9 cases for per-host failure tracking) - recordNodeSnapshot: 75%→100% (6 cases for diagnostic snapshot storage) - evaluateHostAgents: 87%→100% (10 cases for host health evaluation)	2025-12-01 19:40:32 +00:00
rcourtman	c6a34c4412	test: Add tests for handleProxyFailure, parseRPiTemperature, RecordResult ... - handleProxyFailure: 86.7%→100% (6 cases for proxy disable threshold logic) - parseRPiTemperature: 77.8%→100% (7 cases for RPi temp parsing edge cases) - RecordResult: 95.8%→100% (negative staleness clamping case)	2025-12-01 19:33:06 +00:00
rcourtman	1f380eaaf3	test: Add tests for isProxyEnabled, taskHeap.Pop, NewAdaptiveScheduler ... - isProxyEnabled: 94.4%→100% (7 cases for proxy cooldown/restore logic) - taskHeap.Pop: 87.5%→100% (3 cases for empty/single/multi-element heap) - NewAdaptiveScheduler: 84.6%→100% (14 cases for default value handling)	2025-12-01 19:26:37 +00:00
rcourtman	0ed84f3179	test: Add tests for disableLegacySSHOnAuthFailure, parseNVMeTemps, updateDeadLetterMetrics ... - disableLegacySSHOnAuthFailure: 87.5%→100% (13 cases for auth error detection) - parseNVMeTemps: 88.9%→100% (16 cases for NVMe temp parsing) - updateDeadLetterMetrics: 75%→100% (6 cases for nil handling, queue states)	2025-12-01 19:20:09 +00:00
rcourtman	7bab2f86af	test: Add tests for AllowDockerHostReenroll, SelectInterval, ensureBreaker ... - AllowDockerHostReenroll: 95%→100% (7 cases for empty/blocked/cleanup paths) - ensureBreaker: 94.4%→100% (6 cases for nil map, existing, custom config) - SelectInterval: 94%→96% (20+ cases for edge cases, remaining guards unreachable)	2025-12-01 19:13:40 +00:00
rcourtman	e7bc06033a	test: Add tests for convertDockerSwarmInfo, namespacePathsForDatastore, preserveFailedStorageBackups ... - convertDockerSwarmInfo: 66.7%→100% (4 cases for nil, empty, populated structs) - namespacePathsForDatastore: 92.3%→100% (removed unreachable dead code) - preserveFailedStorageBackups: 91.3%→100% (6 cases for filtering, deduplication)	2025-12-01 19:04:23 +00:00
rcourtman	0bfc9ed447	test: Add tests for storageNamesForNode, GetDockerHost, and SchedulerHealth edge cases ... - storageNamesForNode: 83.3%→100% (8 cases for filtering logic) - GetDockerHost: 75%→100% (5 cases for lookup and whitespace handling) - SchedulerHealth: 85.3%→89.1% (13 cases for nil handling, breaker key parsing)	2025-12-01 18:57:09 +00:00
rcourtman	2d775e9409	test: Add tests for polling interval, proxy success handlers, and failed instance removal ... - effectivePVEPollingInterval: 80%→100% (6 cases for nil/clamping) - handleProxySuccess: 80%→100% (3 cases for nil client, reset) - handleProxyHostSuccess: →100% (6 cases for empty/whitespace/removal) - removeFailedPBSNode: 75%→100% (5 cases for removal, backups, health) - removeFailedPMGInstance: 75%→100% (5 cases for removal, backups, health)	2025-12-01 18:49:09 +00:00
rcourtman	acb7f4cf3a	test: Add tests for normalizeEndpointHost, taskExecutionTimeout, decrementPending ... - normalizeEndpointHost: 89%→94.4% (19 cases covering schemes, ports, paths, edge cases) - taskExecutionTimeout: 83%→100% (4 cases covering defaults and custom timeouts) - decrementPending: 88%→100% (5 cases covering decrement logic and no-op scenarios)	2025-12-01 18:42:57 +00:00
rcourtman	6183727368	test: Add tests for getNodeDisplayName, lookupClusterEndpointLabel, extractSnapshotName ... - getNodeDisplayName: 71%→100% (12 tests covering cluster/non-cluster fallbacks) - lookupClusterEndpointLabel: 77%→85% (14 tests covering endpoint matching) - extractSnapshotName: 78%→100% (8 tests covering volid parsing) Monitoring package 46.2%→46.4%	2025-12-01 18:37:27 +00:00
rcourtman	330cec7829	test: Add tests for clampUint64ToInt64 and resetAuthFailures ... - clampUint64ToInt64: 67%→100% (5 tests covering boundary conditions) - resetAuthFailures: 67%→100% (6 tests covering map cleanup logic) Note: cloneStringFloatMap and cloneStringMap tests already existed.	2025-12-01 18:31:34 +00:00
rcourtman	7672cad174	test: Add tests for SetBreakerState, RecordResult, ResetQueueDepth, IncInFlight, DecInFlight ... - SetBreakerState: 67%→100% (8 tests covering state conversion, retryAt clamping) - RecordResult: 75%→96% (11 tests covering success/failure paths, staleness) - ResetQueueDepth: 75%→100% (4 tests covering negative clamping) - IncInFlight/DecInFlight: 67%→100% (4 tests) Monitoring package 45.9%→46.2%	2025-12-01 18:27:05 +00:00
rcourtman	44b6745741	test: Add tests for recordAuthFailure, shouldSkipProxyHost, recoverFromPanic ... - recordAuthFailure: 53%→100% (8 tests covering failure counting, node removal) - shouldSkipProxyHost: 44%→100% (9 tests covering cooldown logic, state cleanup) - recoverFromPanic: 50%→100% (7 tests covering various panic value types) Monitoring package 45.3%→45.9%	2025-12-01 18:20:12 +00:00
rcourtman	b4fb5d2a6a	test: Add tests for mergeNVMeTempsIntoDisks, UpdateQueueSnapshot, UpdateDeadLetterCounts, templateFuncMap ... - mergeNVMeTempsIntoDisks: 57%→97% (14 tests covering WWN/serial/path matching, NVMe fallback) - UpdateQueueSnapshot: 57%→100% (5 tests covering nil, gauges, stale key cleanup) - UpdateDeadLetterCounts: 52%→100% (7 tests covering aggregation, normalization) - templateFuncMap: 20%→100% (8 tests covering all template helper functions) Monitoring 44.6%→45.3%, notifications 45.7%→45.9%	2025-12-01 18:14:43 +00:00
rcourtman	0803951854	test: Add tests for getInstanceConfig, baseIntervalForInstanceType, LoadOIDCConfig ... - getInstanceConfig: 33%→100% (nil handling, case-insensitive matching) - baseIntervalForInstanceType: 50%→100% (all instance types, clamping) - LoadOIDCConfig: 35%→94% (file not exist, read errors, decryption)	2025-12-01 18:06:15 +00:00
rcourtman	4defced1a6	test: Add monitoring tests for parseDurationEnv, parseIntEnv, markFailed, logNodeMemorySource ... Add comprehensive test coverage for: - parseDurationEnv: empty/unset env, valid durations, invalid inputs - parseIntEnv: empty/unset env, valid integers, invalid inputs - markFailed: status setting, timestamps, failure reason - logNodeMemorySource: nil handling, source change detection, log levels All four functions now at 100% coverage (up from 0-78%).	2025-12-01 17:59:20 +00:00
rcourtman	7314510280	test: Add tests for SSH knownhosts error and path methods ... - HostKeyChangeError.Error(): message formatting - HostKeyChangeError.Unwrap(): error chain verification - manager.Path(): path retrieval - HostFieldMatches(): host matching patterns ssh/knownhosts coverage: 72.2% → 75.0%	2025-12-01 17:50:13 +00:00
rcourtman	5d592bf4e6	test: Add tests for diagnostic snapshot recording and retrieval ... - recordGuestSnapshot: nil handling, field setting, map initialization - GetDiagnosticSnapshots: nil/empty handling, sorting verification Both functions now at 100% coverage.	2025-12-01 17:48:36 +00:00
rcourtman	3de1eafd65	test: Add error path tests for config persistence functions ... - LoadAPITokens: invalid JSON, empty file, file not exist - LoadEmailConfig: invalid JSON, file not exist - LoadWebhooks: invalid JSON, legacy migration - LoadNodesConfig: empty arrays, missing fields, corruption recovery - cleanupOldBackups: non-existent dir, multiple files cleanup - Bonus: LoadAppriseConfig, LoadAlertConfig, LoadSystemSettings error paths config package coverage: 46.3% → 48.2%	2025-12-01 17:45:50 +00:00
rcourtman	2158c14cce	test: Add comprehensive tests for API token management ... - Clone: deep copy verification for pointers and slices - NewAPITokenRecord/NewHashedAPITokenRecord: creation and validation - Config methods: HasAPITokens, APITokenCount, ActiveAPITokenHashes - Config methods: HasAPITokenHash, PrimaryAPITokenHash, PrimaryAPITokenHint - Config methods: ValidateAPIToken, UpsertAPIToken, RemoveAPIToken, SortAPITokens config package coverage: 43.5% → 46.3%	2025-12-01 17:37:27 +00:00
rcourtman	d6359276ed	test: Add tests for monitoring and notifications functions ... - buildCephClusterModel: 0% → 100% (11 test cases) - collectContainerRootUsage: 0% → 100% (18 test cases) - NotificationManager getters/setters: 8 functions now tested Overall coverage: 45.5% → 45.8%	2025-12-01 17:33:36 +00:00
rcourtman	caa33b3140	test: Add tests for checkPMGNodeQueues ... - 12 test cases covering per-node queue monitoring - Tests total/deferred/hold queue thresholds at warning/critical levels - Tests oldest message age per node - Tests outlier detection, threshold clearing, existing alert updates - Tests empty nodes and nil QueueStatus handling Coverage: checkPMGNodeQueues 0%→85.1% Package coverage: 70.3%→72.3%	2025-12-01 17:16:32 +00:00
rcourtman	5f85f4e5ac	test: Add tests for checkZFSPoolHealth ... - 14 test cases covering pool state alerts (ONLINE, DEGRADED, FAULTED, UNAVAIL), pool error tracking, device-level alerts, state transitions - Tests pool state clearing on recovery, error count updates, SPARE device handling, FAULTED device critical alerts Coverage: checkZFSPoolHealth 0%→100% Package coverage: 68.6%→70.3%	2025-12-01 17:14:12 +00:00
rcourtman	e3b8a00fe4	test: Add tests for checkEscalations and CleanupAlertsForNodes ... - checkEscalations: 6 test cases covering disabled/enabled states, acknowledged alerts, threshold timing, multi-level escalation - CleanupAlertsForNodes: 7 test cases covering node removal, Docker/PBS alert preservation, empty node handling, nil safety Coverage: checkEscalations 0%→100%, CleanupAlertsForNodes 0%→92% Package coverage: 67.6%→68.6%	2025-12-01 17:11:47 +00:00
rcourtman	1aa5eeb0cb	test: Add tests for Cleanup and convertLegacyThreshold ... - Cleanup: 16 test cases covering auto-acknowledge, TTL cleanup, rate limit entries, suppressions, pending alerts, flapping history, Docker restart tracking, PMG anomaly trackers, quarantine history - convertLegacyThreshold: 5 test cases covering nil/zero/negative input, default margin, custom margin Coverage: Cleanup 0%→97.6%, convertLegacyThreshold 0%→83.3% Package coverage: 65.4%→67.6%	2025-12-01 17:08:45 +00:00
rcourtman	24c44c8e5a	test: Add tests for checkStorageOffline and checkGuestPoweredOff ... - checkStorageOffline: 5 test cases covering confirmation polling, alert creation, LastSeen updates, disabled storage handling - checkGuestPoweredOff: 9 test cases covering confirmation polling, alert creation, severity overrides, disabled guests, monitorOnly flag Coverage: checkStorageOffline 0%→100%, checkGuestPoweredOff 0%→100% Package coverage: 63.4%→65.4% Note: Pre-existing test failure in suite related to /etc/pulse file access - not caused by these changes.	2025-12-01 17:05:15 +00:00
rcourtman	6806512ef1	test: Add tests for checkPMGQueueDepths and checkPMGOldestMessage ... - checkPMGQueueDepths: 10 test cases covering total/deferred/hold queues at warning/critical levels, existing alert updates, threshold clearing - checkPMGOldestMessage: 8 test cases covering threshold logic, multi-node oldest detection, alert creation/updates/clearing Coverage: checkPMGQueueDepths 0%→88.1%, checkPMGOldestMessage 0%→100% Package coverage: 61.3%→63.4%	2025-12-01 16:59:59 +00:00
rcourtman	b7c08ca6e1	test: Add tests for calculateTrimmedBaseline and createOrUpdateNodeAlert ... - calculateTrimmedBaseline: 8 test cases covering sample count thresholds, trimmed mean calculation, median fallback logic, odd-length arrays - createOrUpdateNodeAlert: 2 test cases for new alert creation and existing alert updates Coverage: calculateTrimmedBaseline 0%→96.9%, createOrUpdateNodeAlert 0%→100% Package coverage: 59.6%→61.3%	2025-12-01 16:56:14 +00:00
rcourtman	34b4a0d50c	test: Add tests for checkPBSOffline and checkPMGOffline functions ... checkPBSOffline (0%→100%): - Override Disabled clears alert and returns - Override DisableConnectivity clears alert and returns - Insufficient confirmations waits - Creates alert after 3 confirmations - Existing alert updates LastSeen checkPMGOffline (0%→100%): - Override Disabled clears alert and returns - Override DisableConnectivity clears alert and returns - Insufficient confirmations waits - Creates alert after 3 confirmations - Existing alert updates LastSeen Coverage: 58.6% → 59.6%	2025-12-01 16:50:18 +00:00
rcourtman	42ded0dd23	test: Add tests for checkNodeOffline function ... checkNodeOffline (0%→100%): - Override DisableConnectivity clears alert and returns - Existing alert updates StartTime - Insufficient confirmations waits (1, 2 confirmations) - Creates alert after 3 confirmations with correct metadata - Alert added to history Coverage: 58.5% → 58.6%	2025-12-01 16:48:13 +00:00
rcourtman	785a03ea77	test: Add tests for offline alert clearing functions ... clearNodeOfflineAlert (0%→100%): - No alert and no count is no-op - Resets offline count when node comes online - Clears existing alert and adds to resolved clearPBSOfflineAlert (0%→100%): - No alert and no count is no-op - Resets offline confirmation count - Clears existing alert and adds to resolved clearPMGOfflineAlert (0%→100%): - No alert and no count is no-op - Resets offline confirmation count - Clears existing alert and adds to resolved Coverage: 57.4% → 58.5%	2025-12-01 16:45:51 +00:00
rcourtman	b9e49a26c4	test: Add tests for alert utility functions ... SetMetricHooks (0%→100%): - Sets all four hooks correctly - Nil hooks are safely handled - Properly saves/restores state to avoid test pollution NotifyExistingAlert (0%→100%): - Non-existent alert is no-op - Existing alert dispatches async notification GetResolvedAlert (0%→100%): - Returns nil for non-existent alert - Returns nil for nil resolved entry - Returns nil when Alert is nil - Returns cloned alert with resolved time GetAlertHistory/GetAlertHistorySince (0%→100%): - Returns history from history manager - Respects limit parameter - Zero time returns all history - Filters by time correctly ClearAlertHistory (0%→100%): - Clears all history entries Coverage: 56.9% → 57.4%	2025-12-01 16:43:04 +00:00
rcourtman	5c584b9eee	test: Add comprehensive tests for HandleDockerHostOffline ... HandleDockerHostOffline (0%→100%): - Empty host ID is no-op - Disabled alerts is no-op - DisableAllDockerHostsOffline clears tracking and alert - Override DisableConnectivity clears tracking and alert - Existing alert updates LastSeen - Requires 3 confirmations before alert - Alert has correct metadata (resourceType, hostId, agentId) Coverage: 55.6% → 56.9%	2025-12-01 16:39:10 +00:00
rcourtman	7bac96d60b	test: Add comprehensive tests for HandleHostRemoved, ReevaluateGuestAlert ... HandleHostRemoved (0%→100%): - Empty host ID is no-op - Clears host offline alert and confirmations - Clears host metric alerts (CPU, memory) - Clears host disk alerts - Clears all alert types together ReevaluateGuestAlert (0%→100%): - No active alerts is no-op - Clears alert when threshold disabled (nil) - Clears alert when trigger is zero - Clears alert when value below clear threshold - Clears alert when value below trigger threshold - Keeps alert when value above both thresholds - Processes all metric types (7 types) - Clears pending alert when threshold disabled - Uses clear equals trigger when clear is zero - Ignores alerts for different guests NormalizeMetricTimeThresholds (0%→100%): - Updated existing test to call public wrapper instead of internal function Coverage: 54.6% → 55.6%	2025-12-01 16:36:48 +00:00
rcourtman	65e5eb84ae	test: Add comprehensive tests for reevaluateActiveAlertsLocked ... Tests major branches for alert re-evaluation on config change: - Empty alerts map (no-op) - Alert ID with insufficient parts (skipped) - DisableAllPMG resolves PMG queue alerts - DisableAllHosts resolves Host alerts via resourceType metadata - Docker host offline alerts are skipped (not threshold-based) - DisableAllDockerHosts resolves dockerhost metric alerts - DisableAllNodes resolves Node alerts via Instance field - DisableAllStorage resolves Storage alerts - DisableAllPBS resolves PBS alerts - DisableAllGuests resolves Guest alerts - Disabled override resolves alert - Alert below clear threshold is resolved - Alert between clear and trigger is resolved on config change Coverage improvement: - reevaluateActiveAlertsLocked: 59.8% → 81.2% - alerts package: 54.0% → 54.6%	2025-12-01 16:31:05 +00:00
rcourtman	46eccd561a	test: Add comprehensive tests for HandleHostOffline function ... Tests all branches: - Empty host ID returns early - Alerts disabled returns early - DisableAllHostsOffline clears alert and confirmation tracking - Override DisableConnectivity clears alert and returns - Override Disabled clears alert and returns - Existing alert updates LastSeen only - Insufficient confirmations waits for more - Sufficient confirmations (3) creates alert with metadata Coverage improvement: - HandleHostOffline: 64.0% → 100% - alerts package: 53.5% → 54.0%	2025-12-01 16:26:56 +00:00
rcourtman	1647b232db	test: Add comprehensive tests for applyGlobalOfflineSettingsLocked ... Tests all 7 disable settings branches: - DisableAllNodesOffline: clears node-offline-* alerts and nodeOfflineCount - DisableAllPBSOffline: clears pbs-offline-* alerts and offlineConfirmations - DisableAllGuestsOffline: clears guest-powered-off-* alerts and offlineConfirmations - DisableAllDockerHostsOffline: clears docker-host-offline-* alerts and dockerOfflineCount - DisableAllDockerContainers: clears docker-container-* alerts and tracking state - DisableAllDockerServices: clears docker-service-* alerts - No settings enabled: verifies no-op behavior Coverage improvement: - applyGlobalOfflineSettingsLocked: 57.1% → 100% - alerts package: 53.0% → 53.5%	2025-12-01 16:23:45 +00:00
rcourtman	a4008f914f	test: Add comprehensive tests for alert clearing functions ... - TestClearBackupAlertsLocked: tests backup-age alert clearing with nil handling - TestClearBackupAlerts: tests public wrapper function - TestClearSnapshotAlertsForInstanceLocked: tests instance-specific snapshot clearing - TestClearSnapshotAlertsForInstance: tests public wrapper function Coverage improvement: - clearBackupAlertsLocked: 75% → 100% - clearBackupAlerts: 0% → 100% - clearSnapshotAlertsForInstanceLocked: 50% → 100% - clearSnapshotAlertsForInstance: 0% → 100% - alerts package: 52.8% → 53.0%	2025-12-01 16:20:49 +00:00
rcourtman	876d81ea12	test: Add edge case tests for ClearActiveAlerts and sanitizeAlertKey ... - TestClearActiveAlertsEmptyMaps: tests early return when both maps empty - sanitizeAlertKey: test for input with only slashes/backslashes -> root Coverage improvement: - sanitizeAlertKey: 96.4% → 100% - alerts package: 52.8%	2025-12-01 16:15:50 +00:00
rcourtman	6e779742d8	test: Add comprehensive tests for AcknowledgeAlert and UnacknowledgeAlert functions ... - TestAcknowledgeAlertNotFound: tests error path when alert doesn't exist - TestUnacknowledgeAlertNotFound: tests error path when alert doesn't exist - TestUnacknowledgeAlertSuccess: tests successful unacknowledgement with state verification Coverage improvement: - AcknowledgeAlert: 92.3% → 100% - UnacknowledgeAlert: 41.7% → 100% - alerts package: 52.6% → 52.8%	2025-12-01 16:12:50 +00:00
rcourtman	edf0cae4f9	test: Add edge case tests for matchesDockerIgnoredPrefix function ... - skips empty prefix in list - all empty prefixes returns false - empty name/id edge cases - matchesDockerIgnoredPrefix 92.3%→100%	2025-12-01 16:08:21 +00:00
rcourtman	9052e48245	test: Add comprehensive tests for HandleHostOnline function ... - clears offline alert and confirmation tracking - clears confirmation even without alert - empty host ID is noop - HandleHostOnline 90%→100%	2025-12-01 16:06:06 +00:00
rcourtman	9229cf86be	test: Add comprehensive tests for safeCallResolvedCallback function ... - calls callback synchronously with alert ID - calls callback asynchronously - noop when callback is nil - recovers from panic in sync and async callbacks - safeCallResolvedCallback 90%→100%	2025-12-01 16:04:25 +00:00
rcourtman	9f1a5c2183	test: Add comprehensive tests for safeCallEscalateCallback function ... - calls callback with alert and level - noop when callback is nil - recovers from panic in callback - clones alert to prevent concurrent modification - safeCallEscalateCallback 0%→100%	2025-12-01 16:02:19 +00:00
rcourtman	d7360c7b22	test: Add comprehensive tests for cleanupDockerContainerAlerts function ... - clears alerts and state tracking not in seen set - skips alerts from other hosts - handles empty seen set (clears all) - cleanupDockerContainerAlerts 75%→100%	2025-12-01 15:59:49 +00:00
rcourtman	b5a8817ee4	test: Add comprehensive tests for HandleDockerHostOnline function ... - clears offline alert and tracking - clears tracking even when no alert exists - empty host ID is noop - HandleDockerHostOnline 88.9%→100%	2025-12-01 15:57:44 +00:00
rcourtman	e7cf40c2c6	test: Add empty ID test for HandleDockerHostRemoved function ... - empty host ID is noop (preserves existing alerts/tracking) - HandleDockerHostRemoved 75%→100%	2025-12-01 15:56:11 +00:00
rcourtman	7580d0b3d5	test: Add comprehensive tests for cleanupHostDiskAlerts function ... - clears alerts not in seen set (stale disk alerts) - empty host ID is noop - skips nil alerts without panic - skips non-matching prefix (non-disk alerts) - cleanupHostDiskAlerts 76.9%→100%	2025-12-01 15:54:33 +00:00
rcourtman	39a856aaf8	test: Add comprehensive tests for clearHostDiskAlerts function ... - clears all disk alerts for specified host - empty hostID is noop - skips nil alerts without panic - noop when no matching alerts - clearHostDiskAlerts 72.7%→100%	2025-12-01 15:52:39 +00:00
rcourtman	32b346b8ce	test: Add comprehensive tests for clearHostMetricAlerts function ... - clears specified metrics from host - defaults to cpu and memory when no metrics specified - empty hostID is noop - clearHostMetricAlerts 85.7%→100%	2025-12-01 15:50:59 +00:00
rcourtman	a3aef773ec	test: Add comprehensive tests for clearStorageOfflineAlert function ... - clears existing offline alert and confirmation - triggers resolved callback - noop when no alert exists - clears offline confirmation even without alert - clearStorageOfflineAlert 50%→100%	2025-12-01 15:48:32 +00:00
rcourtman	2fbf9cbe7b	test: Add comprehensive tests for dockerServiceResourceID function ... - with/without host ID (prefix selection) - derives ID from service name with sanitization - special chars replaced with dashes - preserves alphanumeric, underscore, hyphen - trims leading/trailing dashes/underscores - truncates long IDs to 32 chars - fallback to 'service' when empty - dockerServiceResourceID 23.8%→100%	2025-12-01 15:46:34 +00:00
rcourtman	884d04ae61	test: Add comprehensive tests for dockerServiceDisplayName function ... - returns name when present - returns trimmed name - returns truncated ID when name empty (first 12 chars) - returns full short ID when < 12 chars - returns 'service' when both empty/whitespace - prefers name over ID - dockerServiceDisplayName 33.3%→100%	2025-12-01 15:44:40 +00:00
rcourtman	a97a4a022c	test: Add comprehensive tests for shouldNotifyAfterCooldown function ... - cooldown disabled (0) allows notification - negative cooldown allows notification - first notification allowed when never notified - notification blocked during cooldown period - notification allowed after cooldown expires - boundary condition (exact cooldown time) - shouldNotifyAfterCooldown 42.9%→100%	2025-12-01 15:42:35 +00:00
rcourtman	46f0632c53	test: Add comprehensive tests for applyRelaxedGuestThresholds function ... - nil thresholds get defaults (CPU 95, Memory 92, Disk 95) - low thresholds raised to minimum relaxed values - high thresholds unchanged - clear adjusted when too close to trigger - original config unchanged (no mutation) - alerts package coverage improvement: applyRelaxedGuestThresholds 75%→93.8%	2025-12-01 15:40:19 +00:00
rcourtman	10498a0d54	test: Add comprehensive tests for checkRateLimit function ... Cover all branches: disabled rate limit (zero/negative MaxAlertsHour), under limit, at limit blocking, separate limits per alertID, old entry cleanup, and mixed old/recent entries. Coverage improved from 71.4% to 100%.	2025-12-01 15:35:19 +00:00
rcourtman	c488956001	test: Add comprehensive tests for getMetricTimeThreshold function ... Cover all branches: empty config, empty/whitespace metricType, direct match, canonical key matching (vm→guest, container→guest), fallback chain (default, _default, wildcard), precedence, and no-match scenarios. Coverage improved from 77.8% to 100%.	2025-12-01 15:32:33 +00:00
rcourtman	a9fe80e1cd	test: Add comprehensive tests for EmailTemplate function ... Cover both branches: single alert template (isSingle=true with 1 alert) and grouped alert template (isSingle=false or multiple alerts). Tests verify subject format, HTML structure, and text body generation. Coverage improved from 66.7% to 100%.	2025-12-01 15:29:31 +00:00
rcourtman	844b9e5637	test: Add comprehensive tests for getBaseTimeThreshold function ... Cover all branches: nil/empty TimeThresholds, direct match, canonical key matching (vm→guest, container→guest), "all" fallback, specific match precedence, and global threshold fallback. Coverage improved from 85.7% to 100%.	2025-12-01 15:25:18 +00:00
rcourtman	22abeea3a9	test: Add comprehensive tests for CreateProxmoxConfigFromFields function ... Cover all branches: user without realm gets @pam appended, user with realm unchanged, token auth skips user modification, empty user handling, and fingerprint/verifySSL preservation. Coverage improved from 66.7% to 100%.	2025-12-01 15:22:50 +00:00
rcourtman	6ae187c954	test: Add comprehensive tests for hasExpired function ... Cover all branches: nil ExpiresAt, future expiry, past expiry, and exact expiry time edge case. Coverage improved from 66.7% to 100%.	2025-12-01 15:20:11 +00:00
rcourtman	fecab94dc8	test: Add comprehensive tests for getGlobalMetricTimeThreshold function ... Cover all branches: empty config, missing 'all' key, empty perType map, empty/whitespace metricType, direct match, case insensitivity, default fallback, _default fallback, wildcard fallback, and no-match scenarios. Coverage improved from 58.8% to 100%.	2025-12-01 15:17:12 +00:00
rcourtman	7c0ea6a07b	test: Add comprehensive tests for isInQuietHours function ... Cover all branches: disabled state, invalid timezone fallback, day not enabled, invalid start/end time parsing, overnight window spanning midnight, and normal daytime window. Coverage improved from 61.5% to 96.2%.	2025-12-01 15:14:44 +00:00
rcourtman	606764f931	test: Add comprehensive tests for checkFlapping function ... Cover all branches of flapping detection: disabled state, below/at/above threshold, already-flapping state (no suppression update), and window expiry pruning. Coverage improved from 61.9% to 95.2%.	2025-12-01 15:11:11 +00:00
rcourtman	c7d832c8d9	test: Add comprehensive tests for BuildGuestKey function ... - Test different instance and node (full format) - Test same instance and node (short format) - Test empty instance defaults to node - Test whitespace trimming - Improves BuildGuestKey coverage from 71.4% to 100%	2025-12-01 15:04:37 +00:00
rcourtman	50843d3013	test: Add LoadAPITokens error path tests ... - Test nonexistent file returns empty slice (not error) - Test empty file returns empty slice - Test invalid JSON returns error - Improves LoadAPITokens coverage from 80% to 93.3%	2025-12-01 15:00:56 +00:00
rcourtman	9461afc0be	test: Add renderWebhookURL URL parsing error test ... Add test case for malformed IPv6 URL that triggers url.Parse error. Improves coverage from 90% to 95%. The remaining 5% is a template Execute error path that's effectively unreachable with current types.	2025-12-01 14:57:25 +00:00
rcourtman	e774feb8ba	test: Add HasScope edge case tests for API tokens ... - Test empty scope always returns true - Test explicit wildcard scope in list grants any scope - Improves coverage from 85.7% to 100%	2025-12-01 14:51:58 +00:00
rcourtman	4973eb4c8a	test: Improve coverage for cluster config handler functions ... - deriveSchemeAndPort: 87.5% → 100% - Empty/whitespace string handling - Invalid URL parsing fallback - Host without port - ensureHostHasPort: 91.7% → 100% - Empty port returns host unchanged - Protocol-relative URL handling (//host)	2025-12-01 14:46:00 +00:00
rcourtman	c6030d1b13	test: Add tests for ResetRateLimitForIP function ... - Test nil globalRateLimitConfig early return (no panic) - Test actual rate limit reset clears IP from limiter - Improves coverage from 80% to 100%	2025-12-01 14:38:26 +00:00
rcourtman	5431ad2595	test: Add taskHeap.Less tiebreaker test case ... When tasks have identical NextRun and Priority, the Less function falls back to comparing InstanceName alphabetically. Add test to cover this edge case branch, improving Less coverage to 100%.	2025-12-01 14:36:32 +00:00
rcourtman	737c02983f	test: Improve coverage for security utility functions ... - Add fmt.Stringer test cases for isEmptyInterface (80% -> 100%) - Expand isTrustedNetwork tests with edge cases (80% -> 100%) - Empty/invalid IP strings - Invalid CIDR handling - Whitespace trimming in CIDRs - Multiple network matching	2025-12-01 14:33:31 +00:00
rcourtman	17512e076a	test: Add tests for updates package utility functions ... - TestNormalizeGitDescribeVersion: Git describe format parsing - TestSanitizeError: Error message length truncation - TestStatusDelayForStage: Update stage delay logic Coverage: updates 41.5% → 41.6%	2025-12-01 14:18:54 +00:00
rcourtman	2947c3dce1	test: Add tests for monitoring helper and normalize functions ... - TestCloneStringFloatMap: Deep copy verification for float maps - TestCloneStringMap: Deep copy verification for string maps - TestNormalizeAgentVersion: Version prefix normalization - TestNormalizePBSNamespacePath: PBS namespace path handling - TestNamespacePathsForDatastore: Datastore namespace extraction - TestNormalizeDockerHostID: Docker host ID normalization Coverage: monitoring 42.2% → 42.5%	2025-12-01 14:14:48 +00:00
rcourtman	b863b2473d	test: Add tests for config handler utility functions ... - TestSanitizeErrorMessage: All operation types and error hiding - TestFindExistingGuestURL: Node matching and edge cases - TestMatchInstanceNameByHost: Host normalization and matching Coverage: api 27.7% → 28.0%	2025-12-01 14:09:35 +00:00
rcourtman	4058e575f7	test: Add tests for metric threshold lookup functions ... - normalizeMetricTimeThresholds: key normalization, invalid value filtering - getThresholdForMetric: all metric types, empty config, case sensitivity - getThresholdForMetricFromConfig: hysteresis application, all metric types Coverage: alerts 49.0% → 49.9%	2025-12-01 14:01:25 +00:00
rcourtman	be5a6eb97e	test: Add tests for OIDC handler utility functions ... - sanitizeOIDCReturnTo: path validation, protocol-relative URL rejection - addQueryParam: URL building, encoding, fragment preservation - extractStringClaim: type handling (string, []string, []interface{}) - extractStringSliceClaim: slice extraction with comma/space splitting - matchesValue: case-insensitive value matching - matchesDomain: email domain validation with @ handling - intersects: set intersection with case normalization - buildRedirectURL: proxy header handling (X-Forwarded-Proto/Host) Coverage: api 26.7% → 27.7%	2025-12-01 13:56:38 +00:00
rcourtman	23794987f0	test: Add tests for alerts clone functions and parsePulseTags ... - cloneThreshold: nil handling, value copying, pointer independence - cloneStringPtr: nil handling, string copying, pointer independence - cloneThresholdConfig: full config deep copy verification - ensureHysteresisThreshold: default clear calculation, edge cases - parsePulseTags: tag parsing, case insensitivity, whitespace handling Coverage: alerts 48.9% → 49.0%	2025-12-01 13:52:09 +00:00
rcourtman	03d41fb71b	test: Add tests for notification config copy functions ... Tests for defensive copy functions that ensure data isolation: - copyEmailConfig: copies email config with slice independence - copyWebhookConfigs: deep copies webhooks including maps - copyAppriseConfig: copies apprise config with slice independence - buildNotificationTestAlert: validates test alert structure Tests verify that modifying copies doesn't affect originals, critical for concurrent access safety.	2025-12-01 13:43:52 +00:00
rcourtman	447478785b	test: Add unit tests for filter_evaluation.go functions ... Tests for alert filter evaluation logic: - evaluateVMCondition: metric/text/raw conditions for VMs - evaluateContainerCondition: same for containers - evaluateFilterStack: AND/OR logic with multiple conditions - evaluateFilterCondition: type dispatch 74 test cases covering: - All metric types (cpu, memory, disk, diskread, diskwrite, network) - All comparison operators (>, <, >=, <=, =, ==) - Text search fields (name, node, vmid) with case insensitivity - Raw text search across multiple fields - Value type conversions (int to float64) - Edge cases (zero, empty, invalid types) Coverage improved from 46.8% to 48.9%.	2025-12-01 13:34:23 +00:00
rcourtman	93ea641791	test: Add unit tests for container_parsing.go pure functions ... Tests for LXC container config parsing functions: - sanitizeRootFSDevice: rootfs device extraction - collectIPsFromInterface: recursive IP extraction from various types - parseContainerRawIPs: JSON IP parsing - parseContainerConfigNetworks: network interface parsing with MAC normalization, CIDR stripping, sorting - parseContainerMountMetadata: mount point metadata parsing - extractContainerRootDeviceFromConfig: root device extraction - mergeContainerNetworkInterface: interface merging by name/MAC - convertContainerDiskInfo: Proxmox disk info conversion - ensureContainerRootDiskEntry: root disk entry creation 91+ test cases covering edge cases, invalid data, and complex scenarios. Coverage improved from 40.6% to 42.2%.	2025-12-01 13:28:39 +00:00
rcourtman	611e606513	test: Add unit tests for docker_host_identity.go pure functions ... Tests for all 9 functions handling Docker host identification: - uniqueNonEmptyStrings: dedupe with order preservation - sanitizeDockerHostSuffix: string cleaning for IDs - tokenHintFromRecord: redacted token hints - dockerHostIDExists: ID existence check - dockerHostSuffixCandidates: candidate suffix generation - fallbackDockerHostID: hash-based ID generation - findMatchingDockerHost: host matching by various criteria - generateDockerHostIdentifier: unique ID generation with suffixes - resolveDockerHostIdentifier: main resolver orchestration 86 test cases covering edge cases (nil, empty, whitespace), Unicode handling, and complex matching scenarios.	2025-12-01 13:20:30 +00:00
rcourtman	19bc5f7977	test: Add unit tests for convertDockerServices ... Tests cover nil/empty inputs, basic field copying, time fields (CreatedAt/UpdatedAt with nil and zero value handling), update status conversion, endpoint ports, and labels cloning.	2025-12-01 13:15:29 +00:00
rcourtman	c2de40d696	test: Add error path tests for loadOrCreateBootstrapToken ... Cover all error branches in bootstrap token loading: - Empty/whitespace dataPath validation - os.MkdirAll failure (directory creation blocked by file) - os.WriteFile failure (read-only directory) - os.ReadFile failure (permission denied on existing file) - Empty file contents after read - Whitespace-only file contents Also adds test for generateBootstrapToken helper function.	2025-12-01 13:00:27 +00:00
rcourtman	e6b9bd501d	test: Add error path tests for renderWebhookURL and UpdateAllowedPrivateCIDRs ... Add comprehensive error handling tests for two pure functions: renderWebhookURL (8 new test cases): - Empty/whitespace URL template validation - Invalid template syntax (unclosed braces, undefined functions) - Template producing empty URL - Missing scheme or host in rendered URL UpdateAllowedPrivateCIDRs (expanded from 8 to 29 cases): - Invalid IP addresses (garbage, out of range, malformed) - Invalid CIDR notation (prefix too large, negative, non-numeric) - Malformed strings (double slash, invalid IP with valid prefix) - Success cases for valid IPv4/IPv6 CIDRs and bare IPs	2025-12-01 12:58:15 +00:00
rcourtman	e2df1d0ed4	test: Add unit tests for api_tokens.go pure functions ... Add comprehensive tests for tokenPrefix, tokenSuffix, normalizeScopes, and IsKnownScope functions. Coverage increased 42.7% -> 43.3%.	2025-12-01 12:32:37 +00:00
rcourtman	2990864f66	test: Add unit tests for guest_metadata.go pure functions ... Add comprehensive tests for: - guestMetadataCacheKey: cache key generation with edge cases - cloneStringSlice: nil/empty handling, deep copy verification - cloneGuestNetworkInterfaces: nil/empty, deep address copy - processGuestNetworkInterfaces: IP filtering (loopback, link-local), deduplication, sorting, whitespace trimming, traffic-only interfaces Increases monitoring package coverage from 38.9% to 39.6%.	2025-12-01 12:18:59 +00:00
rcourtman	845b096240	test: Add error path tests for acknowledgeDockerCommand ... - Use public API AcknowledgeDockerHostCommand instead of private function - Use strings.Contains instead of custom helper functions - Add test case for empty hostID (skips validation, succeeds)	2025-12-01 12:08:16 +00:00
rcourtman	46a72a7600	Fix outdated error message path for removed Docker hosts ... The error message referenced "Settings -> Docker -> Removed hosts" but that UI path no longer exists. The correct path is now "Settings -> Agents -> Removed Docker Hosts". Related to #778	2025-12-01 12:03:05 +00:00
rcourtman	827a8b4d37	test: Add unit tests for email_enhanced.go error handling ... Add comprehensive tests for EnhancedEmailManager covering: - Rate limiting (exceeds limit, resets after minute, concurrency, negative values) - Provider username defaults (SendGrid, SparkPost, Resend, Postmark) - TLS routing (TLS, StartTLS, plain connections) - Retry logic (retries on failure, rate limit prevents retry) - Connection error handling for sendTLS, sendStartTLS, sendPlain This is the first test file for email_enhanced.go which previously had 0% coverage on sendTLS, sendStartTLS, and TestConnection functions.	2025-12-01 11:46:44 +00:00
rcourtman	f02a340d72	refactor: Extract filter evaluation functions to separate file ... Move guest threshold resolution and filter evaluation logic from alerts.go to filter_evaluation.go for better code organization. Extracted functions: - evaluateFilterCondition - evaluateVMCondition - evaluateContainerCondition - evaluateFilterStack - getGuestThresholds This reduces alerts.go by ~370 lines and isolates the rule evaluation engine that determines which thresholds apply to guests.	2025-12-01 11:28:43 +00:00
rcourtman	72420a616a	ADA changes (auto-committed by cron safety check)	2025-12-01 11:20:57 +00:00
rcourtman	22b429a1c9	test: Add unit tests for validateIPAddress, validatePort, defaultPortForNodeType ... Cover API validation functions that were previously untested: - validateIPAddress: IPv4/IPv6 validation with edge cases - validatePort: Port range validation (1-65535) - defaultPortForNodeType: Proxmox node type to default port mapping	2025-12-01 11:06:50 +00:00
rcourtman	56726f15e0	refactor: Extract guest metadata functions to separate file ... Move 17 guest-metadata-related functions from monitor.go to new guest_metadata.go file. This includes: - Guest agent API call retry logic - Guest metadata caching (fetch, reserve, schedule, clear) - Network interface processing and cloning - OS info extraction - Type conversion utilities (stringValue, anyToInt64) Reduces monitor.go by 541 lines (8932 → 8391).	2025-12-01 10:53:41 +00:00
rcourtman	0b2485b26b	refactor: Extract container parsing functions to separate file ... Move 13 related container parsing functions from monitor.go (9359 lines) to container_parsing.go (451 lines). Reduces monitor.go by 427 lines. Functions extracted: - ensureContainerRootDiskEntry - convertContainerDiskInfo - sanitizeRootFSDevice - parseContainerRawIPs - collectIPsFromInterface - sanitizeGuestAddressStrings - dedupeStringsPreserveOrder - containerNetworkDetails struct - containerMountMetadata struct - parseContainerConfigNetworks - parseContainerMountMetadata - mergeContainerNetworkInterface - extractContainerRootDeviceFromConfig	2025-12-01 10:40:48 +00:00
rcourtman	82c7925895	refactor: Remove dead HandleTestExistingNode function ... This function was superseded by HandleTestNode which is wired to the router at /api/config/nodes/{id}/test. The old function was not registered in the router and served no purpose. Removes 121 lines of unused code.	2025-12-01 10:21:50 +00:00
rcourtman	5a4bc3b053	refactor: Extract Docker host identifier functions to separate file ... Move 9 related pure functions from monitor.go (9616 lines) to docker_host_identity.go (281 lines). Reduces monitor.go by 257 lines. Functions extracted: - tokenHintFromRecord - resolveDockerHostIdentifier - findMatchingDockerHost - dockerHostIDExists - generateDockerHostIdentifier - dockerHostSuffixCandidates - sanitizeDockerHostSuffix - fallbackDockerHostID - uniqueNonEmptyStrings	2025-12-01 10:03:47 +00:00
rcourtman	8ebc8fc892	ADA changes (auto-committed by cron safety check)	2025-12-01 09:51:17 +00:00
rcourtman	f9abaf26f3	Add rp1_adc to CPU chip detection in sensors parser ... The host-agent's isCPUChip function was missing rp1_adc (Raspberry Pi RP1 ADC), which is already detected in the monitoring package. This sync ensures consistent CPU temperature chip detection across both code paths.	2025-12-01 09:45:39 +00:00
rcourtman	8b3d8d3e86	Add unit tests for websocket Hub.checkOrigin function ... Test coverage for CORS origin validation including: - No origin header (non-browser clients) - Same-origin requests with/without proxy headers - Wildcard and explicit allowed origins - Private network fallback (192.168.x, 10.x, localhost, .local, .lan) - Public IP/domain rejection - X-Forwarded-Proto/Host/Scheme header handling - WebSocket protocol normalization (ws->http, wss->https) Coverage: 37.3% → 48.6%	2025-12-01 09:33:40 +00:00
rcourtman	0d786d42c9	Add unit tests for notification utility functions ... Tests for annotateResolvedMetadata, resolveAppriseNotificationType, normalizeQueueType, and resolvedTimeFromAlerts (44 test cases). Coverage 38.0% → 39.0%.	2025-12-01 02:04:27 +00:00
rcourtman	0c50d9e6b7	Add unit tests for error classification functions in monitoring ... Add 56 test cases covering: - isTransientError: 13 cases for context errors, retryable MonitorErrors, and standard error types (nil, Canceled, DeadlineExceeded, Timeout, etc.) - shouldTryPortlessFallback: 14 cases for connection error patterns that trigger port fallback (refused, reset, no such host, timeout variants) - shouldAttemptFallback: 13 cases for timeout/deadline/canceled patterns used in storage polling fallback - classifyDLQReason: 8 cases for dead letter queue reason classification (max_retry_attempts vs permanent_failure) - Edge cases: 3 cases for overlapping error patterns and partial matches First test file for these error classification utilities used in retry and fallback decision logic.	2025-12-01 01:37:28 +00:00
rcourtman	5fcd4e9cb9	Add unit tests for extractHostAndPort utility function ... 27 test cases covering URL/host:port parsing for node configuration: - Scheme stripping (http://, https://) - Path removal from URLs - IPv4 addresses with and without ports - IPv6 addresses (bracketed with port, unbracketed) - Edge cases (empty string, localhost, port-only) - Error cases (malformed brackets) Documents current behavior: bracketed IPv6 without port returns error (net.SplitHostPort limitation).	2025-12-01 01:19:10 +00:00
rcourtman	a21dd8c3d2	Add unit tests for system_settings.go map utility functions ... 52 test cases covering: - firstValueForKeys: 18 cases for multi-key lookup with priority ordering - hasAnyKey: 15 cases for key existence checking - discoveryConfigMap: 19 cases for nested config extraction with camelCase/snake_case support Tests verify edge cases including nil maps, empty key slices, type assertion failures, and priority ordering for field name variants used in configuration parsing.	2025-12-01 01:05:07 +00:00
rcourtman	fb240c2d40	Add unit tests for monitor.go type conversion utilities ... Add 97 test cases for four utility functions in monitor.go: - stringValue (30 cases): Type-to-string conversion for various Go types including string, int types, float types, json.Number, fmt.Stringer - anyToInt64 (34 cases): Interface-to-int64 conversion with overflow handling, string parsing, and json.Number support - parseInterfaceStat (15 cases): Interface stat map parsing for network interface statistics - extractGuestOSInfo (18 cases): QEMU guest agent OS info extraction with fallback logic for various Linux distros, Windows, FreeBSD Coverage for these functions: 0% → 100% Package coverage: 37.5% → 38.5%	2025-12-01 00:51:20 +00:00
rcourtman	0198eaf6c8	Add unit tests for monitoring utility functions ... Added comprehensive tests for 6 previously untested pure utility functions: - sortContent: sorts comma-separated storage content values - formatSeconds: converts total seconds to HH:MM:SS format - dedupeStringsPreserveOrder: deduplicates strings while preserving order - sanitizeGuestAddressStrings: validates and filters IP addresses - copyFloatPointer: creates independent copy of float64 pointer - clampInterval: clamps time.Duration to specified bounds Tests cover edge cases including empty inputs, boundary conditions, special values (DHCP, loopback addresses), and various separators. Coverage increased from 36.8% to 37.5%.	2025-12-01 00:37:24 +00:00
rcourtman	51671d2a56	Add unit tests for RecoveryTokenStore ... 20 test cases covering: - Token generation (uniqueness, expiry durations, format) - Token validation (valid, invalid, expired, used, empty store) - Concurrent use protection (replay attack prevention) - Cleanup routine (expired tokens, used tokens, stop signal) - Persistence (save, load, filter expired on load) - Edge cases (missing file, invalid JSON)	2025-12-01 00:06:32 +00:00
rcourtman	990a00c5be	Add unit tests for normalizePVEUser and shouldSkipClusterAutoDetection	2025-11-30 23:53:41 +00:00
rcourtman	6ff3f57ac7	Add unit tests for security lockout and session management functions ... Tests for internal/api/security.go: - RecordFailedLogin: increments counts, triggers lockout at max attempts - ClearFailedLogins: clears count and lockout state - GetLockoutInfo: returns correct attempts/lockout status - ResetLockout: admin lockout reset functionality - TrackUserSession: user/session tracking - GetSessionUsername: session lookup - clearCSRFCookie: nil safety, cookie attributes - issueNewCSRFCookie: nil safety, empty session handling - FailedLogin/AuditEvent struct field validation 30 test cases covering lockout, session tracking, and CSRF functions.	2025-11-30 23:33:51 +00:00
rcourtman	314669d584	Add unit tests for SessionStore (internal/api) ... Coverage for sessionHash, CreateSession, ValidateSession, ValidateAndExtendSession, DeleteSession, persistence, and cleanup. 21 test cases covering session lifecycle, expiration handling, and disk persistence. Coverage 25.0% → 25.3%.	2025-11-30 23:18:34 +00:00
rcourtman	554d44aba0	Add unit tests for auth helper functions (internal/api) ... Tests for detectProxy, isConnectionSecure, getCookieSettings, and generateSessionToken functions. Covers proxy detection for various headers including X-Forwarded-For, CF-Ray, Forwarded (RFC 7239), and secure connection detection via TLS and proxy headers.	2025-11-30 23:04:44 +00:00
rcourtman	3378814a05	Add unit tests for bootstrap token functions (internal/api) ... 20 test cases covering: - generateBootstrapToken: uniqueness, format, hex encoding - loadOrCreateBootstrapToken: new token creation, existing token loading, empty/whitespace paths, empty token files, directory creation, file permissions - bootstrapTokenValid: nil router safety, empty hash/token handling - clearBootstrapToken: nil safety, file deletion, state clearing First test file for bootstrap_token.go security utilities.	2025-11-30 22:54:28 +00:00
rcourtman	0538e8f013	Add unit tests for diagnostic snapshot key generation functions ... 32 test cases covering makeNodeSnapshotKey and makeGuestSnapshotKey utility functions used for diagnostic memory snapshot storage. Tests cover simple inputs, edge cases (empty strings, negative VMIDs), special characters, and key uniqueness verification. Also includes struct field tests for NodeMemoryRaw and VMMemoryRaw. First test file for diagnostic_snapshots.go. Coverage 36.7% → 36.8%.	2025-11-30 22:34:09 +00:00
rcourtman	d99f5b067f	Add unit tests for UpdaterRegistry (internal/updates) ... 27 test cases covering: - NewUpdaterRegistry initialization - Register and Get operations - Overwrite behavior when re-registering - Error handling for unregistered deployment types - Multiple deployment types - UpdateRequest, UpdatePlan, UpdateProgress struct fields - Mock updater interface compliance Coverage 41.1% → 41.5%.	2025-11-30 22:19:06 +00:00
rcourtman	54fab46bd6	Fix backup status indicator not showing for guests ... The backup status indicator feature was incomplete - it added the UI component but never populated VM/Container LastBackup from actual backup data. Now SyncGuestBackupTimes() is called after storage backups and PBS backups are polled, matching each guest's VMID to its most recent backup timestamp. Fixes #786	2025-11-30 22:13:46 +00:00
rcourtman	a7b1cf2ae9	Add unit tests for isRetryableWebhookError (internal/notifications) ... 47 test cases covering webhook retry logic classification: - Network errors: timeout, connection refused/reset, DNS lookup, network unreachable - HTTP 5xx server errors: all status codes 500-599 (retryable) - HTTP 4xx client errors: all status codes 400-499 except 429 (not retryable) - HTTP 429 rate limiting: special case (retryable) - Case insensitivity verification - Real-world error message patterns from Go net/http - All status code boundary tests Coverage 37.4% -> 38.0%.	2025-11-30 22:03:26 +00:00
rcourtman	ece30e9345	Add unit tests for State methods (internal/models) ... 51 test cases covering Docker host and generic Host state management: - UpsertDockerHost, RemoveDockerHost, GetDockerHosts - SetDockerHostStatus, SetDockerHostHidden, SetDockerHostPendingUninstall - SetDockerHostCommand, SetDockerHostCustomDisplayName - TouchDockerHost, RemoveStaleDockerHosts - AddRemovedDockerHost, RemoveRemovedDockerHost, GetRemovedDockerHosts - UpsertHost, GetHosts, RemoveHost, SetHostStatus, TouchHost - UpdateRecentlyResolved Coverage 44.0% → 68.3%.	2025-11-30 21:49:43 +00:00
rcourtman	fe8ee86f4e	Add unit tests for MetricsHistory (internal/monitoring) ... 58 test cases covering: - NewMetricsHistory: constructor and initialization (4 cases) - appendMetric: time-series append with retention and max limits (5 cases) - cleanupMetrics: old point removal with cutoff time (5 cases) - AddGuestMetric: all 7 metric types + unknown type handling (8 cases) - AddNodeMetric: cpu/memory/disk + unknown type (4 cases) - AddStorageMetric: usage/used/total/avail + unknown type (5 cases) - GetGuestMetrics: duration filtering, nonexistent, zero duration (6 cases) - GetNodeMetrics: duration filtering and edge cases (5 cases) - GetAllGuestMetrics: multi-metric retrieval (3 cases) - GetAllStorageMetrics: storage metric retrieval (2 cases) - Cleanup: retention enforcement across all metric types (1 case) - Multiple guests isolation: verify metrics don't leak (1 case) - MaxDataPoints enforcement: oldest points dropped (1 case) - RetentionTime enforcement: old points removed on append (1 case) First comprehensive unit test file for metrics_history.go core functions. Existing concurrency test in separate file.	2025-11-30 21:34:07 +00:00
rcourtman	dadbc180e3	Add unit tests for HTTPClient (internal/tempproxy) ... 23 test cases covering NewHTTPClient, IsAvailable, GetTemperature, and HealthCheck including success paths, error handling (401, 403, 429, 5xx), JSON parsing, URL encoding, retry behavior, and connection errors. Coverage: 22.4% → 47.6%	2025-11-30 21:18:14 +00:00
rcourtman	94952577e2	Add unit tests for importTransaction (internal/config) ... 24 test cases covering transaction lifecycle: staging, commit, rollback, and cleanup. Tests include atomic commit behavior, backup/restore on failure, directory creation, permission handling, and idempotent cleanup. First test file for import_transaction.go. Coverage 42.4% → 42.7%.	2025-11-30 21:04:41 +00:00
rcourtman	0eb0824c0a	Add unit tests for GuestMetadataStore (internal/config) ... 22 test cases covering CRUD operations (Get, GetAll, Set, Delete, ReplaceAll), persistence (Load, save with atomic write, directory creation), legacy ID migration (GetWithLegacyMigration for clustered and standalone formats), round-trip verification, and concurrency. First test file for guest_metadata.go, complementing the similar docker_metadata_test.go added in previous run.	2025-11-30 20:48:05 +00:00
rcourtman	f8c7a30d28	Fix cluster proxy token collision - store per-node control tokens ... When multiple cluster nodes register sensor-proxy, each registration was overwriting the previous node's control token on the shared PVEInstance. This caused "Proxy token not recognized" errors on all but the last-registered node. Changes: - Add TemperatureProxyControlToken field to ClusterEndpoint struct - Store control tokens per-endpoint for cluster registrations - Check both instance-level and endpoint-level tokens when validating Related to #738	2025-11-30 20:37:58 +00:00
rcourtman	db56cb7d0d	Add unit tests for UpdateHistory (internal/updates) ... 47 test cases covering: - NewUpdateHistory: directory creation, loading existing entries - CreateEntry: event ID generation, timestamp handling, persistence - UpdateEntry: updates, persistence verification, error handling - GetEntry: retrieval by ID, non-existent entry errors - ListEntries: filtering by status/action/deployment type, limits - GetLatestSuccessful: finding recent successful entries - Cache management: trimming when exceeding max size - LoadCache: malformed JSON handling, empty lines - Type definitions and constant validation	2025-11-30 20:34:40 +00:00
rcourtman	2e884f4a71	Add unit tests for DockerMetadataStore (internal/config) ... 22 test cases covering: - Get/GetAll: retrieval of container/service metadata - GetHostMetadata/GetAllHostMetadata: retrieval of host metadata - Set: add/update metadata with persistence - SetHostMetadata: add/update/delete host metadata - Delete: remove container metadata - ReplaceAll: bulk replace with nil entry handling - Load: versioned format, legacy format, nonexistent file, invalid JSON - Save: directory creation, atomic write - Round-trip: full persistence cycle verification - Concurrent access safety First test file for docker_metadata.go.	2025-11-30 17:20:46 +00:00
rcourtman	6bda5e4d4a	Add unit tests for mdadm parseDetail function	2025-11-30 16:42:12 +00:00
rcourtman	ee066d086a	Add unit tests for OIDC configuration helpers ... Test coverage for internal/config/oidc.go functions: - normaliseList: 8 cases for deduplication, trimming, empty handling - parseDelimited: 8 cases for comma/space separation - DefaultRedirectURL: 7 cases for URL construction - OIDCConfig.Clone: 2 cases for deep copy behavior - OIDCConfig.ApplyDefaults: 9 cases for defaults and normalization - OIDCConfig.Validate: 9 cases for validation rules - OIDCConfig.MergeFromEnv: 5 cases for environment variable merging - NewOIDCConfig: constructor verification Total: 56 new test cases (583 lines).	2025-11-30 16:22:43 +00:00
rcourtman	2620aa5db5	Add unit tests for security.go IP parsing utilities ... - extractRemoteIP: 17 test cases for remote address parsing (IPv4/IPv6 with/without ports, bracketed notation, edge cases) - firstValidForwardedIP: 21 test cases for X-Forwarded-For parsing (single/multiple IPs, invalid entries, IPv4/IPv6 mixed) - isPrivateIPExtended: 33 test cases extending existing coverage (RFC 1918 boundaries, loopback range, IPv6 private/local, ports) Total: 71 new test cases for IP address handling utilities.	2025-11-30 15:48:45 +00:00
rcourtman	2c26054d57	Add unit tests for router.go proxy header utility functions (api) ... Add 77 test cases for 4 previously untested utility functions: - firstForwardedValue: 14 cases for X-Forwarded-For header parsing - sanitizeForwardedHost: 27 cases for host sanitization with scheme/port handling - isLoopbackHost: 20 cases for loopback detection (localhost, 127.x, ::1) - shouldAppendForwardedPort: 16 cases for port appending decisions Key edge cases covered: - IPv6 address bracket handling in sanitizeForwardedHost - Case-insensitive localhost detection - Full 127.0.0.0/8 loopback range validation - strconv.Atoi accepts negative port strings (documented as current behavior)	2025-11-30 15:34:32 +00:00
rcourtman	930e003519	Add unit tests for normalizeUnifiedAgentArch and getClientIP (api) ... Tests for unified_agent.go: - normalizeUnifiedAgentArch: 51 test cases covering all supported architectures (linux/darwin/windows), case insensitivity, whitespace handling, and invalid inputs Tests for updates.go: - getClientIP: 18 test cases covering X-Forwarded-For priority, X-Real-IP fallback, RemoteAddr extraction, IPv4/IPv6 support, nil header safety, and case insensitivity	2025-11-30 15:05:37 +00:00
rcourtman	04d4b6606a	Add unit tests for CSRF token store (api)	2025-11-30 14:55:47 +00:00
rcourtman	fe3f32ebcc	Add unit tests for responseWriter middleware wrapper (api) ... Tests for the responseWriter struct in middleware.go: - APIError.Error() interface implementation (3 cases) - WriteHeader once-only semantics (4 cases) - Write with implicit WriteHeader (3 cases) - StatusCode nil safety (4 cases) - Hijack support detection (2 cases) - Flush support detection (3 cases) - Full flow integration and edge cases (4 cases) First test file for middleware.go. 22 test cases total covering HTTP response wrapper behavior used by ErrorHandler middleware.	2025-11-30 14:33:38 +00:00
rcourtman	39d02d62a3	Add unit tests for temperature proxy utility functions (api) ... - extractHostPart: 22 test cases covering URL parsing, hostname extraction - buildAuthorizedNodeList: 8 test cases for PVE instance node list building - generateSecureToken: 5 test cases for cryptographic token generation - proxySyncState: 6 test cases for sync status tracking and snapshots First test file for temperature_proxy.go utility functions.	2025-11-30 14:07:04 +00:00
rcourtman	07587ec818	Add unit tests for GetRateLimiterForEndpoint (api) ... 37 test cases covering endpoint routing to rate limiters: - Authentication endpoints (login, logout, change-password, auth/*) - Recovery endpoints (security/recovery) - Export/Import endpoints (config/export, config/import) - Configuration write operations (POST/PUT/DELETE to config/*) - Configuration read operations (GET to config/*, discover, security/status) - Update endpoints (updates/*) - WebSocket endpoints (/ws/*) - Public endpoints (health, version, metrics, etc.) - General API fallback - Case insensitivity (uppercase paths) - Lazy initialization when globalRateLimitConfig is nil - Priority ordering tests for overlapping patterns	2025-11-30 13:48:23 +00:00
rcourtman	aee687bb03	Add unit tests for DemoModeMiddleware (api) ... 26 test cases covering: - Demo mode disabled (all requests pass through) - Demo mode enabled with read-only methods (GET/HEAD/OPTIONS allowed) - WebSocket upgrade handling (case-insensitive) - Auth endpoint allowlist (login, OIDC, logout) - Modification request blocking (POST/PUT/DELETE/PATCH) - Partial path match rejection (security) - Response format verification (JSON error response) First test file for demo_middleware.go. Tests verify correct header setting (X-Demo-Mode) and error response structure.	2025-11-30 13:34:08 +00:00