danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix install.sh missing from GitHub releases (addresses #642)

Browse source 
Root cause: install.sh was not being copied to the release directory
during build-release.sh execution, so it was never uploaded as a
release asset. This caused the download URL to return "Not Found",
which bash attempted to execute as a command.

Changes:
- Copy install.sh to release/ directory in build-release.sh
- Include install.sh in checksums generation

Note: RELEASE_CHECKLIST.md also updated locally to verify install.sh
presence in Phase 3 and Phase 5, but that file is gitignored.
This commit is contained in:
rcourtman 2025-11-06 14:10:46 +00:00
parent fa3b0db243
commit e4378602c1
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scripts/build-release.sh
View file

@ -260,10 +260,14 @@ if [ "${SKIP_HELM_PACKAGE:-0}" != "1" ]; then
fi fi
fi fi
# Generate checksums (include tarballs, helm chart, and standalone binaries) # Copy install.sh to release directory (required for GitHub releases)
echo "Copying install.sh to release directory..."
cp install.sh "$RELEASE_DIR/"
# Generate checksums (include tarballs, helm chart, standalone binaries, and install.sh)
cd "$RELEASE_DIR" cd "$RELEASE_DIR"
shopt -s nullglob shopt -s nullglob
checksum_files=( *.tar.gz pulse-sensor-proxy-* ) checksum_files=( *.tar.gz pulse-sensor-proxy-* install.sh )
if compgen -G "pulse-*.tgz" > /dev/null; then if compgen -G "pulse-*.tgz" > /dev/null; then
checksum_files+=( pulse-*.tgz ) checksum_files+=( pulse-*.tgz )
fi fi