From e4378602c1e51a2b09e6a7e5017f755390629ad8 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Thu, 6 Nov 2025 14:10:46 +0000 Subject: [PATCH] Fix install.sh missing from GitHub releases (addresses #642) Root cause: install.sh was not being copied to the release directory during build-release.sh execution, so it was never uploaded as a release asset. This caused the download URL to return "Not Found", which bash attempted to execute as a command. Changes: - Copy install.sh to release/ directory in build-release.sh - Include install.sh in checksums generation Note: RELEASE_CHECKLIST.md also updated locally to verify install.sh presence in Phase 3 and Phase 5, but that file is gitignored. --- scripts/build-release.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/build-release.sh b/scripts/build-release.sh index e5f65b0..1852e60 100755 --- a/scripts/build-release.sh +++ b/scripts/build-release.sh @@ -260,10 +260,14 @@ if [ "${SKIP_HELM_PACKAGE:-0}" != "1" ]; then fi fi -# Generate checksums (include tarballs, helm chart, and standalone binaries) +# Copy install.sh to release directory (required for GitHub releases) +echo "Copying install.sh to release directory..." +cp install.sh "$RELEASE_DIR/" + +# Generate checksums (include tarballs, helm chart, standalone binaries, and install.sh) cd "$RELEASE_DIR" shopt -s nullglob -checksum_files=( *.tar.gz pulse-sensor-proxy-* ) +checksum_files=( *.tar.gz pulse-sensor-proxy-* install.sh ) if compgen -G "pulse-*.tgz" > /dev/null; then checksum_files+=( pulse-*.tgz ) fi