danvics/Pulse
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: Remove unreachable dead code branches

Browse source 
- parseDetail: Remove len(parts) != 2 check after SplitN(line, ":", 2)
  when we already verified line contains ":" (SplitN always returns 2)

Function improved from 96.4% to 98.1% coverage.
This commit is contained in:
rcourtman 2025-12-02 15:00:26 +00:00
parent a0a473ada8
commit be23624592
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
internal/mdadm/mdadm.go
View file

@ -157,10 +157,8 @@ func parseDetail(device, output string) (host.RAIDArray, error) {
// Parse key-value pairs // Parse key-value pairs
if strings.Contains(line, ":") { if strings.Contains(line, ":") {
// SplitN with n=2 always returns 2 elements when ":" exists
parts := strings.SplitN(line, ":", 2) parts := strings.SplitN(line, ":", 2)
if len(parts) != 2 {
continue
}
key := strings.TrimSpace(parts[0]) key := strings.TrimSpace(parts[0])
value := strings.TrimSpace(parts[1]) value := strings.TrimSpace(parts[1])