From be23624592d9df6ef9210fa352726e5861adb965 Mon Sep 17 00:00:00 2001 From: rcourtman Date: Tue, 2 Dec 2025 15:00:26 +0000 Subject: [PATCH] refactor: Remove unreachable dead code branches - parseDetail: Remove len(parts) != 2 check after SplitN(line, ":", 2) when we already verified line contains ":" (SplitN always returns 2) Function improved from 96.4% to 98.1% coverage. --- internal/mdadm/mdadm.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/mdadm/mdadm.go b/internal/mdadm/mdadm.go index 6e47d73..decf203 100644 --- a/internal/mdadm/mdadm.go +++ b/internal/mdadm/mdadm.go @@ -157,10 +157,8 @@ func parseDetail(device, output string) (host.RAIDArray, error) { // Parse key-value pairs if strings.Contains(line, ":") { + // SplitN with n=2 always returns 2 elements when ":" exists parts := strings.SplitN(line, ":", 2) - if len(parts) != 2 { - continue - } key := strings.TrimSpace(parts[0]) value := strings.TrimSpace(parts[1])