danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: pr feedbacks

Browse source
This commit is contained in:
Nicolas Meienberger 2026-02-10 20:05:11 +01:00
parent 4a2f857a2f
commit f1b6156b75
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/client/components/snapshots-table.tsx
View file

@ -29,7 +29,7 @@ import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "~
import { formatDuration } from "~/utils/utils"; import { formatDuration } from "~/utils/utils";
import { formatDateTime } from "~/client/lib/datetime"; import { formatDateTime } from "~/client/lib/datetime";
import { deleteSnapshotsMutation, tagSnapshotsMutation } from "~/client/api-client/@tanstack/react-query.gen"; import { deleteSnapshotsMutation, tagSnapshotsMutation } from "~/client/api-client/@tanstack/react-query.gen";
import { handleRepositoryError } from "~/client/lib/errors"; import { parseError } from "~/client/lib/errors";
import type { BackupSchedule, Snapshot } from "../lib/types"; import type { BackupSchedule, Snapshot } from "../lib/types";
import { cn } from "../lib/utils"; import { cn } from "../lib/utils";
@ -91,7 +91,7 @@ export const SnapshotsTable = ({ snapshots, repositoryId, backups }: Props) => {
{ {
loading: `Deleting ${selectedIds.size} snapshots...`, loading: `Deleting ${selectedIds.size} snapshots...`,
success: "Snapshots deleted successfully", success: "Snapshots deleted successfully",
error: (error) => handleRepositoryError("Failed to delete snapshots", error, repositoryId), error: (error) => parseError(error)?.message || "Failed to delete snapshots",
}, },
); );
}; };
@ -111,7 +111,7 @@ export const SnapshotsTable = ({ snapshots, repositoryId, backups }: Props) => {
{ {
loading: `Re-tagging ${selectedIds.size} snapshots...`, loading: `Re-tagging ${selectedIds.size} snapshots...`,
success: `Snapshots re-tagged to ${schedule.name}`, success: `Snapshots re-tagged to ${schedule.name}`,
error: (error) => handleRepositoryError("Failed to re-tag snapshots", error, repositoryId), error: (error) => parseError(error)?.message || "Failed to re-tag snapshots",
}, },
); );
}; };

1
app/client/lib/errors.tsx
View file

@ -62,6 +62,7 @@ export const showLockErrorToast = (repositoryId: string, title: string) => {
export const handleRepositoryError = (title: string, error: unknown, repositoryId: string) => { export const handleRepositoryError = (title: string, error: unknown, repositoryId: string) => {
if (isLockError(error)) { if (isLockError(error)) {
showLockErrorToast(repositoryId, title); showLockErrorToast(repositoryId, title);
return null;
} }
toast.error(parseError(error)?.message || "An unexpected error occurred"); toast.error(parseError(error)?.message || "An unexpected error occurred");

2
app/client/modules/backups/routes/backup-details.tsx
View file

@ -219,7 +219,7 @@ export default function ScheduleDetailsPage({ params, loaderData }: Route.Compon
{ {
loading: "Deleting snapshot...", loading: "Deleting snapshot...",
success: "Snapshot deleted successfully", success: "Snapshot deleted successfully",
error: (error) => handleRepositoryError("Failed to delete snapshot", error, schedule.repository.shortId), error: (error) => parseError(error)?.message || "Failed to delete snapshot",
}, },
); );
} }