From e48f1f209abe2832c6b5e9190d6b64113b5616ba Mon Sep 17 00:00:00 2001
From: Nicolas Meienberger <github@thisprops.com>
Date: Thu, 9 Apr 2026 19:43:13 +0200
Subject: [PATCH] fix: pr feedbacks

---
 app/server/modules/agents/controller/server.ts | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/app/server/modules/agents/controller/server.ts b/app/server/modules/agents/controller/server.ts
index 67a2e808..3bb025d7 100644
--- a/app/server/modules/agents/controller/server.ts
+++ b/app/server/modules/agents/controller/server.ts
@@ -166,7 +166,11 @@ export function createAgentManagerRuntime() {
 							return;
 						}
 
-						Effect.runSync(session.handleMessage(data));
+						void Effect.runPromise(session.handleMessage(data)).catch((error) => {
+							logger.error(
+								`Failed to handle message from agent ${ws.data.agentId} on ${ws.data.id}: ${toMessage(error)}`,
+							);
+						});
 					},
 					close: (ws) => {
 						removeSession(ws.data.agentId, ws.data.id);
@@ -222,7 +226,7 @@ export function createAgentManagerRuntime() {
 
 	return {
 		start,
-		sendBackup: (agentId: string, payload: BackupRunPayload) => {
+		sendBackup: async (agentId: string, payload: BackupRunPayload) => {
 			const session = getSession(agentId);
 
 			if (!session) {
@@ -235,7 +239,7 @@ export function createAgentManagerRuntime() {
 				return false;
 			}
 
-			if (!Effect.runSync(session.sendBackup(payload))) {
+			if (!(await Effect.runPromise(session.sendBackup(payload)))) {
 				logger.warn(`Cannot send backup command. Agent ${agentId} is no longer accepting commands.`);
 				return false;
 			}
@@ -243,7 +247,7 @@ export function createAgentManagerRuntime() {
 			logger.info(`Sent backup command ${payload.jobId} to agent ${agentId} for schedule ${payload.scheduleId}`);
 			return true;
 		},
-		cancelBackup: (agentId: string, payload: BackupCancelPayload) => {
+		cancelBackup: async (agentId: string, payload: BackupCancelPayload) => {
 			const session = getSession(agentId);
 
 			if (!session) {
@@ -251,7 +255,7 @@ export function createAgentManagerRuntime() {
 				return false;
 			}
 
-			if (!Effect.runSync(session.sendBackupCancel(payload))) {
+			if (!(await Effect.runPromise(session.sendBackupCancel(payload)))) {
 				logger.warn(`Cannot cancel backup command. Agent ${agentId} is no longer accepting commands.`);
 				return false;
 			}