From d535f02536539c491c117edf82de62238f0b142f Mon Sep 17 00:00:00 2001
From: Nicolas Meienberger <github@thisprops.com>
Date: Fri, 2 Jan 2026 14:23:21 +0100
Subject: [PATCH] refactor: code readability

---
 .../components/create-notification-form.tsx      |  4 +++-
 .../modules/notifications/builders/ntfy.ts       | 16 ++++++++++------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/app/client/modules/notifications/components/create-notification-form.tsx b/app/client/modules/notifications/components/create-notification-form.tsx
index 453ffaca..63697c13 100644
--- a/app/client/modules/notifications/components/create-notification-form.tsx
+++ b/app/client/modules/notifications/components/create-notification-form.tsx
@@ -527,7 +527,9 @@ export const CreateNotificationForm = ({ onSubmit, mode = "create", initialValue
 									<FormControl>
 										<SecretInput {...field} placeholder="••••••••" />
 									</FormControl>
-									<FormDescription>Access token for server authentication, if required.</FormDescription>
+									<FormDescription>
+										Access token for server authentication. Will take precedence over username/password if set.
+									</FormDescription>
 									<FormMessage />
 								</FormItem>
 							)}
diff --git a/app/server/modules/notifications/builders/ntfy.ts b/app/server/modules/notifications/builders/ntfy.ts
index 14ef9fbe..41120456 100644
--- a/app/server/modules/notifications/builders/ntfy.ts
+++ b/app/server/modules/notifications/builders/ntfy.ts
@@ -4,13 +4,17 @@ export function buildNtfyShoutrrrUrl(config: Extract<NotificationConfig, { type:
 	let shoutrrrUrl: string;
 
 	const params = new URLSearchParams();
+	const { username, password, accessToken } = config;
 
-	const auth =
-		config.accessToken
-			? `:${encodeURIComponent(config.accessToken)}@`
-			: config.username && config.password
-				? `${encodeURIComponent(config.username)}:${encodeURIComponent(config.password)}@`
-				: "";
+	let auth = "";
+
+	if (username && password) {
+		auth = `${encodeURIComponent(username)}:${encodeURIComponent(password)}@`;
+	}
+
+	if (accessToken) {
+		auth = `:${encodeURIComponent(accessToken)}@`;
+	}
 
 	if (config.serverUrl) {
 		const url = new URL(config.serverUrl);