danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(backup): removed useless null checks

Browse source
This commit is contained in:
DerPenz 2026-04-09 14:21:31 +02:00 committed by Nico
parent 0476dcebb8
commit b2728cb09a
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/server/modules/backups/helpers/backup-lifecycle.ts
View file

@ -240,13 +240,13 @@ export async function handleBackupFailure(
const delayMinutes = Math.round((schedule.retryDelay / (60 * 1000)) * 10) / 10; const delayMinutes = Math.round((schedule.retryDelay / (60 * 1000)) * 10) / 10;
logger.warn( logger.warn(
`Backup ${schedule?.name} failed. Scheduling retry ${currentRetryCount + 1}/${maxRetries} for ${delayMinutes} minutes from now: ${errorMessage}`, `Backup ${schedule.name} failed. Scheduling retry ${currentRetryCount + 1}/${maxRetries} for ${delayMinutes} minutes from now: ${errorMessage}`,
); );
if (partialContext?.volume && partialContext?.repository) { if (partialContext?.volume && partialContext?.repository) {
serverEvents.emit("backup:completed", { serverEvents.emit("backup:completed", {
organizationId, organizationId,
scheduleId: schedule!.shortId, scheduleId: schedule.shortId,
volumeName: partialContext.volume.name, volumeName: partialContext.volume.name,
repositoryName: partialContext.repository.name, repositoryName: partialContext.repository.name,
status: "error", status: "error",
@ -256,7 +256,7 @@ export async function handleBackupFailure(
.sendBackupNotification(scheduleId, "failure", { .sendBackupNotification(scheduleId, "failure", {
volumeName: partialContext.volume.name, volumeName: partialContext.volume.name,
repositoryName: partialContext.repository.name, repositoryName: partialContext.repository.name,
scheduleName: schedule!.name, scheduleName: schedule.name,
error: `${errorDetails}\n\nRetrying in ${delayMinutes} minutes (attempt ${currentRetryCount + 1}/${maxRetries})`, error: `${errorDetails}\n\nRetrying in ${delayMinutes} minutes (attempt ${currentRetryCount + 1}/${maxRetries})`,
}) })
.catch((notifError) => { .catch((notifError) => {
@ -270,7 +270,7 @@ export async function handleBackupFailure(
const { volume, repository } = partialContext; const { volume, repository } = partialContext;
logger.error( logger.error(
`Backup ${schedule?.name} failed after ${maxRetries} retries for volume ${volume.name} to repository ${repository.name}: ${errorMessage}`, `Backup ${schedule.name} failed after ${maxRetries} retries for volume ${volume.name} to repository ${repository.name}: ${errorMessage}`,
); );
serverEvents.emit("backup:completed", { serverEvents.emit("backup:completed", {