From a16681a096d1993996e6b36ba98bc515928d2b93 Mon Sep 17 00:00:00 2001
From: Nicolas Meienberger <github@thisprops.com>
Date: Fri, 2 Jan 2026 14:42:08 +0100
Subject: [PATCH] chore: pr feedbacks

---
 .../components/create-notification-form.tsx              | 9 +++++++--
 .../modules/notifications/notifications.service.ts       | 5 +----
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/app/client/modules/notifications/components/create-notification-form.tsx b/app/client/modules/notifications/components/create-notification-form.tsx
index 4bd952bd..8b913664 100644
--- a/app/client/modules/notifications/components/create-notification-form.tsx
+++ b/app/client/modules/notifications/components/create-notification-form.tsx
@@ -57,6 +57,9 @@ const defaultValuesForType = {
 	slack: {
 		type: "slack" as const,
 		webhookUrl: "",
+		channel: "",
+		username: "",
+		iconEmoji: "",
 	},
 	discord: {
 		type: "discord" as const,
@@ -103,7 +106,9 @@ const defaultValuesForType = {
 export const CreateNotificationForm = ({ onSubmit, mode = "create", initialValues, formId, className }: Props) => {
 	const form = useForm<NotificationFormValues>({
 		resolver: arktypeResolver(cleanSchema as unknown as typeof formSchema),
-		defaultValues: initialValues,
+		defaultValues: initialValues || {
+			name: "",
+		},
 		resetOptions: {
 			keepDefaultValues: true,
 			keepDirtyValues: false,
@@ -116,7 +121,7 @@ export const CreateNotificationForm = ({ onSubmit, mode = "create", initialValue
 	useEffect(() => {
 		if (!initialValues) {
 			form.reset({
-				name: form.getValues().name,
+				name: form.getValues().name || "",
 				...defaultValuesForType[watchedType as keyof typeof defaultValuesForType],
 			});
 		}
diff --git a/app/server/modules/notifications/notifications.service.ts b/app/server/modules/notifications/notifications.service.ts
index 469755f1..4992ba3e 100644
--- a/app/server/modules/notifications/notifications.service.ts
+++ b/app/server/modules/notifications/notifications.service.ts
@@ -121,10 +121,7 @@ async function decryptSensitiveFields(config: NotificationConfig): Promise<Notif
 				botToken: await cryptoUtils.resolveSecret(config.botToken),
 			};
 		case "generic":
-			return {
-				...config,
-				url: await cryptoUtils.resolveSecret(config.url),
-			};
+			return config;
 		case "custom":
 			return {
 				...config,