From 9d63f7cb2d8c8f088b7b55097b05564e74baddec Mon Sep 17 00:00:00 2001 From: Nicolas Meienberger Date: Wed, 3 Jun 2026 19:56:04 +0200 Subject: [PATCH] Revert "fix(volumes): decrypt values before testing connection (#939)" This reverts commit 885ea10f2a1db9ba424f2458addfe00aa9e3e6b1. --- .../volumes/__tests__/volumes.service.test.ts | 28 ------------------- app/server/modules/volumes/volume.service.ts | 6 ++-- 2 files changed, 2 insertions(+), 32 deletions(-) diff --git a/app/server/modules/volumes/__tests__/volumes.service.test.ts b/app/server/modules/volumes/__tests__/volumes.service.test.ts index 998c56e3..f401ba26 100644 --- a/app/server/modules/volumes/__tests__/volumes.service.test.ts +++ b/app/server/modules/volumes/__tests__/volumes.service.test.ts @@ -16,7 +16,6 @@ import { withContext } from "~/server/core/request-context"; import { asShortId } from "~/server/utils/branded"; import { createTestVolume } from "~/test/helpers/volume"; import { config } from "~/server/core/config"; -import { cryptoUtils } from "~/server/utils/crypto"; afterEach(() => { config.flags.enableLocalAgent = false; @@ -287,31 +286,4 @@ describe("volumeService.testConnection", () => { expect.objectContaining({ name: "volume.testConnection" }), ); }); - - test("decrypts encrypted config values before testing the connection", async () => { - config.flags.enableLocalAgent = true; - agentManagerMock.runVolumeCommand.mockResolvedValue({ - name: "volume.testConnection", - result: { success: true, message: "Connection successful" }, - }); - const encryptedPassword = await cryptoUtils.sealSecret("plain-password"); - - await volumeService.testConnection({ - backend: "smb", - server: "127.0.0.1", - share: "backup", - username: "backup-user", - password: encryptedPassword, - domain: "", - vers: "3.0", - port: 445, - mapToContainerUidGid: false, - readOnly: false, - }); - - expect(agentManagerMock.runVolumeCommand).toHaveBeenCalledWith("local", { - name: "volume.testConnection", - backendConfig: expect.objectContaining({ password: "plain-password" }), - }); - }); }); diff --git a/app/server/modules/volumes/volume.service.ts b/app/server/modules/volumes/volume.service.ts index 01d08506..bdb843ed 100644 --- a/app/server/modules/volumes/volume.service.ts +++ b/app/server/modules/volumes/volume.service.ts @@ -285,13 +285,11 @@ const updateVolume = async (shortId: ShortId, volumeData: UpdateVolumeBody) => { }; const testConnection = async (backendConfig: BackendConfig) => { - const resolvedConfig = await decryptVolumeConfig(backendConfig); - if (!config.flags.enableLocalAgent) { - return Effect.runPromise(testVolumeConnection(resolvedConfig)); + return Effect.runPromise(testVolumeConnection(backendConfig)); } - const command = await runVolumeCommand(LOCAL_AGENT_ID, { name: "volume.testConnection", backendConfig: resolvedConfig }); + const command = await runVolumeCommand(LOCAL_AGENT_ID, { name: "volume.testConnection", backendConfig }); return command.result; };