danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: throttle repository lock cleanup during polling

Browse source
This commit is contained in:
Nicolas Meienberger 2026-05-19 17:33:39 +02:00
parent a662fe4d2c
commit 8cf73fac12
No known key found for this signature in database
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/server/core/repository-mutex.ts
View file

@ -31,10 +31,12 @@ type QueueAttempt = { status: "acquired"; lock: AcquiredLock } | { status: "wait
const LOCK_LEASE_MS = 30_000; const LOCK_LEASE_MS = 30_000;
const LOCK_HEARTBEAT_MS = 5_000; const LOCK_HEARTBEAT_MS = 5_000;
const LOCK_POLL_MS = 250; const LOCK_POLL_MS = 250;
const LOCK_POLL_CLEANUP_MS = 5_000;
class RepositoryMutex { class RepositoryMutex {
private ownerId = `owner_${Bun.randomUUIDv7()}`; private ownerId = `owner_${Bun.randomUUIDv7()}`;
private heartbeatTimers = new Map<string, ReturnType<typeof setInterval>>(); private heartbeatTimers = new Map<string, ReturnType<typeof setInterval>>();
private nextPollCleanupAt = 0;
private generateLockId(): string { private generateLockId(): string {
return `lock_${Bun.randomUUIDv7()}`; return `lock_${Bun.randomUUIDv7()}`;
@ -89,6 +91,13 @@ class RepositoryMutex {
tx.delete(repositoryLockWaitersTable).where(lte(repositoryLockWaitersTable.expiresAt, now)).run(); tx.delete(repositoryLockWaitersTable).where(lte(repositoryLockWaitersTable.expiresAt, now)).run();
} }
private cleanupExpiredDuringPolling(tx: RepositoryMutexTransaction, now: number) {
if (now < this.nextPollCleanupAt) return;
this.cleanupExpired(tx, now);
this.nextPollCleanupAt = now + LOCK_POLL_CLEANUP_MS;
}
private getActiveLocks(tx: RepositoryMutexTransaction, repositoryId: string, now: number) { private getActiveLocks(tx: RepositoryMutexTransaction, repositoryId: string, now: number) {
return tx.query.repositoryLocksTable return tx.query.repositoryLocksTable
.findMany({ .findMany({
@ -235,7 +244,7 @@ class RepositoryMutex {
const now = Date.now(); const now = Date.now();
return db.transaction((tx) => { return db.transaction((tx) => {
this.cleanupExpired(tx, now); this.cleanupExpiredDuringPolling(tx, now);
const activeLock = this.getActiveLockById(tx, waiterId, now); const activeLock = this.getActiveLockById(tx, waiterId, now);
if (activeLock) { if (activeLock) {