danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: run forget commands in the background
Some checks failed
Release Workflow / determine-release-type (push) Has been cancelled
Details
Release Workflow / build-images (push) Has been cancelled
Details
Release Workflow / publish-release (push) Has been cancelled
Details

Browse source
This commit is contained in:
Nicolas Meienberger 2025-12-01 20:22:43 +01:00
parent 33e6f3773b
commit 7ff38f0128
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/server/modules/backups/backups.service.ts
View file

@ -263,12 +263,7 @@ const executeBackup = async (scheduleId: number, manual = false) => {
} }
if (schedule.retentionPolicy) { if (schedule.retentionPolicy) {
const releaseForgetLock = await repoMutex.acquireExclusive(repository.id, `forget:${volume.name}`); void runForget(schedule.id);
try {
await restic.forget(repository.config, schedule.retentionPolicy, { tag: schedule.id.toString() });
} finally {
releaseForgetLock();
}
} }
const nextBackupAt = calculateNextRun(schedule.cronExpression); const nextBackupAt = calculateNextRun(schedule.cronExpression);
@ -415,7 +410,7 @@ const runForget = async (scheduleId: number) => {
throw new NotFoundError("Repository not found"); throw new NotFoundError("Repository not found");
} }
logger.info(`Manually running retention policy (forget) for schedule ${scheduleId}`); logger.info(`running retention policy (forget) for schedule ${scheduleId}`);
const releaseLock = await repoMutex.acquireExclusive(repository.id, `forget:manual:${scheduleId}`); const releaseLock = await repoMutex.acquireExclusive(repository.id, `forget:manual:${scheduleId}`);
try { try {
await restic.forget(repository.config, schedule.retentionPolicy, { tag: schedule.id.toString() }); await restic.forget(repository.config, schedule.retentionPolicy, { tag: schedule.id.toString() });