danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: address PR review feedback

Browse source 
- Use consistent schema syntax (string? instead of key?)
- Remove config tests per maintainer request
This commit is contained in:
James Brink 2025-12-29 12:29:01 -07:00 committed by Nico
parent a6818762af
commit 5fd9768a80
2 changed files with 1 additions and 75 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

74
app/server/core/__tests__/config.test.ts
View file

@ -1,74 +0,0 @@
import { test, describe, expect } from "bun:test";
import { type } from "arktype";
// Re-create the schema to test in isolation (avoids side effects from importing config)
const createEnvSchema = () =>
type({
NODE_ENV: type.enumerated("development", "production", "test").default("production"),
SERVER_IP: 'string = "localhost"',
SERVER_IDLE_TIMEOUT: 'string.integer.parse = "60"',
RESTIC_HOSTNAME: "string = 'zerobyte'",
PORT: 'string.integer.parse = "4096"',
"MIGRATIONS_PATH?": "string",
}).pipe((s) => ({
__prod__: s.NODE_ENV === "production",
environment: s.NODE_ENV,
serverIp: s.SERVER_IP,
serverIdleTimeout: s.SERVER_IDLE_TIMEOUT,
resticHostname: s.RESTIC_HOSTNAME,
port: s.PORT,
migrationsPath: s.MIGRATIONS_PATH,
}));
describe("config", () => {
describe("PORT", () => {
test("should default to 4096 when not set", () => {
const schema = createEnvSchema();
const result = schema({});
expect(result).not.toBeInstanceOf(type.errors);
if (!(result instanceof type.errors)) {
expect(result.port).toBe(4096);
}
});
test("should parse PORT as integer", () => {
const schema = createEnvSchema();
const result = schema({ PORT: "8080" });
expect(result).not.toBeInstanceOf(type.errors);
if (!(result instanceof type.errors)) {
expect(result.port).toBe(8080);
}
});
test("should reject non-integer PORT", () => {
const schema = createEnvSchema();
const result = schema({ PORT: "not-a-number" });
expect(result).toBeInstanceOf(type.errors);
});
});
describe("MIGRATIONS_PATH", () => {
test("should be undefined when not set", () => {
const schema = createEnvSchema();
const result = schema({});
expect(result).not.toBeInstanceOf(type.errors);
if (!(result instanceof type.errors)) {
expect(result.migrationsPath).toBeUndefined();
}
});
test("should accept a valid path", () => {
const schema = createEnvSchema();
const result = schema({ MIGRATIONS_PATH: "/custom/migrations" });
expect(result).not.toBeInstanceOf(type.errors);
if (!(result instanceof type.errors)) {
expect(result.migrationsPath).toBe("/custom/migrations");
}
});
});
});

2
app/server/core/config.ts
View file

@ -7,7 +7,7 @@ const envSchema = type({
SERVER_IDLE_TIMEOUT: 'string.integer.parse = "60"',
RESTIC_HOSTNAME: "string = 'zerobyte'",
PORT: 'string.integer.parse = "4096"',
"MIGRATIONS_PATH?": "string",
MIGRATIONS_PATH: "string?",
}).pipe((s) => ({
__prod__: s.NODE_ENV === "production",
environment: s.NODE_ENV,