From 4e2f8f0160f3bf248088e78b0fa611d0f67ac87b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Tr=C3=A1vn=C3=ADk?= Date: Fri, 19 Dec 2025 14:39:57 +0100 Subject: [PATCH] implement copilot and rabbitai suggestions --- examples/directory-bind-mount/README.md | 4 ++-- examples/directory-bind-mount/docker-compose.yml | 2 +- examples/rclone-config-mount/README.md | 4 ++-- examples/secrets-placeholders/.gitignore | 5 +++++ examples/secrets-placeholders/README.md | 6 ++++-- examples/tailscale-sidecar/docker-compose.yml | 5 +++++ 6 files changed, 19 insertions(+), 7 deletions(-) create mode 100644 examples/secrets-placeholders/.gitignore diff --git a/examples/directory-bind-mount/README.md b/examples/directory-bind-mount/README.md index 25bfac9d..51d500f7 100644 --- a/examples/directory-bind-mount/README.md +++ b/examples/directory-bind-mount/README.md @@ -16,9 +16,9 @@ It uses the simplified setup (no remote mounts). cp .env.example .env ``` -1. Edit `.env` and set `HOST_DATA_DIR` to the directory you want to back up. +2. Edit `.env` and set `HOST_DATA_DIR` to the directory you want to back up. -1. Start the stack: +3. Start the stack: ```bash docker compose up -d diff --git a/examples/directory-bind-mount/docker-compose.yml b/examples/directory-bind-mount/docker-compose.yml index bcb8f1ca..e050d4c1 100644 --- a/examples/directory-bind-mount/docker-compose.yml +++ b/examples/directory-bind-mount/docker-compose.yml @@ -10,4 +10,4 @@ services: volumes: - /etc/localtime:/etc/localtime:ro - /var/lib/zerobyte:/var/lib/zerobyte - - ${HOST_DATA_DIR}:/mydata + - ${HOST_DATA_DIR:?HOST_DATA_DIR must be set}:/mydata diff --git a/examples/rclone-config-mount/README.md b/examples/rclone-config-mount/README.md index ebfdb2bc..e1c86790 100644 --- a/examples/rclone-config-mount/README.md +++ b/examples/rclone-config-mount/README.md @@ -23,9 +23,9 @@ rclone config cp .env.example .env ``` -1. Edit `.env` and set `RCLONE_CONFIG_DIR` to the absolute path of your host rclone config directory. +2. Edit `.env` and set `RCLONE_CONFIG_DIR` to the absolute path of your host rclone config directory. -1. Start the stack: +3. Start the stack: ```bash docker compose up -d diff --git a/examples/secrets-placeholders/.gitignore b/examples/secrets-placeholders/.gitignore new file mode 100644 index 00000000..55d6353f --- /dev/null +++ b/examples/secrets-placeholders/.gitignore @@ -0,0 +1,5 @@ +# Secret files - do not commit +smb-password.txt +*-password.txt +*.secret +*.key diff --git a/examples/secrets-placeholders/README.md b/examples/secrets-placeholders/README.md index 93441708..dac55772 100644 --- a/examples/secrets-placeholders/README.md +++ b/examples/secrets-placeholders/README.md @@ -27,13 +27,15 @@ This example includes `SYS_ADMIN` and `/dev/fuse` because it’s intended for SM cp .env.example .env ``` -1. Create a Docker secret file (this file is not meant to be committed): +2. Create a Docker secret file. + + ⚠️ **Important**: never commit real credentials. This folder includes a `.gitignore` to help prevent accidentally committing secret files. ```bash printf "your-smb-password" > smb-password.txt ``` -1. Start Zerobyte: +3. Start Zerobyte: ```bash docker compose up -d diff --git a/examples/tailscale-sidecar/docker-compose.yml b/examples/tailscale-sidecar/docker-compose.yml index eccf001b..40f4cfd1 100644 --- a/examples/tailscale-sidecar/docker-compose.yml +++ b/examples/tailscale-sidecar/docker-compose.yml @@ -35,6 +35,11 @@ services: image: ghcr.io/nicotsx/zerobyte:latest container_name: zerobyte restart: unless-stopped + # Uncomment if you need to mount NFS/SMB/WebDAV volumes: + # cap_add: + # - SYS_ADMIN + # devices: + # - /dev/fuse:/dev/fuse # Share the Tailscale network namespace (sidecar pattern) network_mode: service:tailscale depends_on: