danvics/zerobyte
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: only lock shared tasks if an exclusive is running
Some checks failed
Release Workflow / determine-release-type (push) Has been cancelled
Details
Release Workflow / build-images (push) Has been cancelled
Details
Release Workflow / publish-release (push) Has been cancelled
Details

Browse source
This commit is contained in:
Nicolas Meienberger 2025-12-01 20:07:30 +01:00
parent a91dede086
commit 33e6f3773b
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/server/core/repository-mutex.ts
View file

@ -49,8 +49,7 @@ class RepositoryMutex {
async acquireShared(repositoryId: string, operation: string): Promise<() => void> { async acquireShared(repositoryId: string, operation: string): Promise<() => void> {
const state = this.getOrCreateState(repositoryId); const state = this.getOrCreateState(repositoryId);
const hasExclusiveWaiter = state.waitQueue.some((w) => w.type === "exclusive"); if (!state.exclusiveHolder) {
if (!state.exclusiveHolder && !hasExclusiveWaiter) {
const lockId = this.generateLockId(); const lockId = this.generateLockId();
state.sharedHolders.set(lockId, { state.sharedHolders.set(lockId, {
id: lockId, id: lockId,
@ -60,7 +59,9 @@ class RepositoryMutex {
return () => this.releaseShared(repositoryId, lockId); return () => this.releaseShared(repositoryId, lockId);
} }
logger.debug(`[Mutex] Waiting for shared lock on repo ${repositoryId}: ${operation}`); logger.debug(
`[Mutex] Waiting for shared lock on repo ${repositoryId}: ${operation} (exclusive held by: ${state.exclusiveHolder.operation})`,
);
const lockId = await new Promise<string>((resolve) => { const lockId = await new Promise<string>((resolve) => {
state.waitQueue.push({ type: "shared", operation, resolve }); state.waitQueue.push({ type: "shared", operation, resolve });
}); });