From 273aa2b9acc08611dc5efed94b44f76c9d8fc821 Mon Sep 17 00:00:00 2001
From: Nico <47644445+nicotsx@users.noreply.github.com>
Date: Sun, 25 Jan 2026 10:20:23 +0100
Subject: [PATCH] feat: add a confirm dialog before stopping the backup (#409)

---
 .../backups/components/schedule-summary.tsx   | 34 ++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/app/client/modules/backups/components/schedule-summary.tsx b/app/client/modules/backups/components/schedule-summary.tsx
index 15aee695..338a7aa6 100644
--- a/app/client/modules/backups/components/schedule-summary.tsx
+++ b/app/client/modules/backups/components/schedule-summary.tsx
@@ -35,6 +35,7 @@ export const ScheduleSummary = (props: Props) => {
 		props;
 	const [showDeleteConfirm, setShowDeleteConfirm] = useState(false);
 	const [showForgetConfirm, setShowForgetConfirm] = useState(false);
+	const [showStopConfirm, setShowStopConfirm] = useState(false);
 
 	const runForget = useMutation({
 		...runForgetMutation(),
@@ -78,6 +79,12 @@ export const ScheduleSummary = (props: Props) => {
 		runForget.mutate({ path: { scheduleId: schedule.id.toString() } });
 	};
 
+	const handleConfirmStop = () => {
+		setShowStopConfirm(false);
+		if (schedule.lastBackupStatus !== "in_progress") return;
+		handleStopBackup();
+	};
+
 	return (
 		<div className="space-y-4">
 			<Card>
@@ -108,7 +115,12 @@ export const ScheduleSummary = (props: Props) => {
 					</div>
 					<div className="flex flex-col @lg:flex-row gap-2">
 						{schedule.lastBackupStatus === "in_progress" ? (
-							<Button variant="destructive" size="sm" onClick={handleStopBackup} className="w-full @md:w-auto">
+							<Button
+								variant="destructive"
+								size="sm"
+								onClick={() => setShowStopConfirm(true)}
+								className="w-full @md:w-auto"
+							>
 								<Square className="h-4 w-4 mr-2" />
 								<span>Stop backup</span>
 							</Button>
@@ -239,6 +251,26 @@ export const ScheduleSummary = (props: Props) => {
 					</div>
 				</AlertDialogContent>
 			</AlertDialog>
+
+			<AlertDialog open={showStopConfirm} onOpenChange={setShowStopConfirm}>
+				<AlertDialogContent>
+					<AlertDialogHeader>
+						<AlertDialogTitle>Stop running backup?</AlertDialogTitle>
+						<AlertDialogDescription>
+							Are you sure you want to stop the current backup for <strong>{schedule.name}</strong>?
+						</AlertDialogDescription>
+					</AlertDialogHeader>
+					<div className="flex gap-3 justify-end">
+						<AlertDialogCancel>Cancel</AlertDialogCancel>
+						<AlertDialogAction
+							onClick={handleConfirmStop}
+							className="bg-destructive text-destructive-foreground hover:bg-destructive/90"
+						>
+							Stop backup
+						</AlertDialogAction>
+					</div>
+				</AlertDialogContent>
+			</AlertDialog>
 		</div>
 	);
 };