From 19575257e8ca4d57ffeb40eb2d534f5ff43d9c6a Mon Sep 17 00:00:00 2001
From: Nicolas Meienberger <github@thisprops.com>
Date: Wed, 25 Feb 2026 18:57:46 +0100
Subject: [PATCH] chore: pr feedback

---
 .../__tests__/repositories.controller.test.ts | 26 +++++++++----------
 .../__tests__/repositories.service.test.ts    |  5 +---
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/app/server/modules/repositories/__tests__/repositories.controller.test.ts b/app/server/modules/repositories/__tests__/repositories.controller.test.ts
index 653935be..94210d52 100644
--- a/app/server/modules/repositories/__tests__/repositories.controller.test.ts
+++ b/app/server/modules/repositories/__tests__/repositories.controller.test.ts
@@ -1,4 +1,4 @@
-import { test, describe, expect } from "bun:test";
+import { test, describe, expect, spyOn } from "bun:test";
 import crypto from "node:crypto";
 import { createApp } from "~/server/app";
 import { db } from "~/server/db/db";
@@ -248,23 +248,23 @@ describe("repositories updates", () => {
 
 			const { restic } = await import("~/server/utils/restic");
 			const { ResticError } = await import("~/server/utils/errors");
-			const originalDeleteSnapshot = restic.deleteSnapshot;
 
-			// Mock it to throw an error
-			restic.deleteSnapshot = async () => {
+			const deleteSnapshotSpy = spyOn(restic, "deleteSnapshot").mockImplementation(async () => {
 				throw new ResticError(1, "Fatal: unexpected HTTP response (403): 403 Forbidden");
-			};
-
-			const res = await app.request(`/api/v1/repositories/${repository.shortId}/snapshots/snap123`, {
-				method: "DELETE",
-				headers: getAuthHeaders(token),
 			});
 
-			restic.deleteSnapshot = originalDeleteSnapshot;
+			try {
+				const res = await app.request(`/api/v1/repositories/${repository.shortId}/snapshots/snap123`, {
+					method: "DELETE",
+					headers: getAuthHeaders(token),
+				});
 
-			expect(res.status).toBe(500);
-			const body = await res.json();
-			expect(body.message).toContain("Command failed");
+				expect(res.status).toBe(500);
+				const body = await res.json();
+				expect(body.message).toContain("Command failed");
+			} finally {
+				deleteSnapshotSpy.mockRestore();
+			}
 		});
 	});
 });
diff --git a/app/server/modules/repositories/__tests__/repositories.service.test.ts b/app/server/modules/repositories/__tests__/repositories.service.test.ts
index 6ce8bf66..ef1e3c0e 100644
--- a/app/server/modules/repositories/__tests__/repositories.service.test.ts
+++ b/app/server/modules/repositories/__tests__/repositories.service.test.ts
@@ -401,8 +401,7 @@ describe("repositoriesService.deleteSnapshot", () => {
 		const { organizationId, user } = await createTestSession();
 		const repository = await createTestRepository(organizationId);
 
-		const originalDeleteSnapshot = restic.deleteSnapshot;
-		restic.deleteSnapshot = mock(async () => {
+		spyOn(restic, "deleteSnapshot").mockImplementation(async () => {
 			throw new ResticError(1, "Fatal: unexpected HTTP response (403): 403 Forbidden");
 		});
 
@@ -411,7 +410,5 @@ describe("repositoriesService.deleteSnapshot", () => {
 				repositoriesService.deleteSnapshot(repository.shortId, "snap123"),
 			),
 		).rejects.toThrow("Fatal: unexpected HTTP response");
-
-		restic.deleteSnapshot = originalDeleteSnapshot;
 	});
 });