From b1f110d027f54d45ca5be894caf06c4c78bb72b6 Mon Sep 17 00:00:00 2001
From: ArabCoders <admin@arabcoders.org>
Date: Sun, 14 Jan 2024 14:35:07 +0300
Subject: [PATCH] Made it more clear the download is a live stream.

---
 app/Download.py                              | 12 +++++++++---
 frontend/src/components/Page-Completed.vue   |  1 +
 frontend/src/components/Page-Downloading.vue | 18 +++++++++++++++---
 3 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/app/Download.py b/app/Download.py
index c82de486..dafccd35 100644
--- a/app/Download.py
+++ b/app/Download.py
@@ -152,11 +152,17 @@ class Download:
                         f'Invalid cookies: was provided for {self.info.title} - {str(e)}')
 
             if self.is_live or self.is_manifestless:
-                log.debug(
-                    f'Live stream or post manifestless mode detected, disabling options: {self.bad_live_options}')
+                hasDeletedOptions = False
+                deletedOpts: list = []
                 for opt in self.bad_live_options:
                     if opt in params:
-                        del params[opt]
+                        params.pop(opt, None)
+                        hasDeletedOptions = True
+                        deletedOpts.append(opt)
+
+                if hasDeletedOptions:
+                    log.warning(
+                        f'Live stream detected for [{self.info.title}], The following opts [{deletedOpts=}] have been deleted which are known to cause issues with live stream and post stream manifestless mode.')
 
             log.info(
                 f'Downloading {os.getpid()=} id="{self.info.id}" title="{self.info.title}".')
diff --git a/frontend/src/components/Page-Completed.vue b/frontend/src/components/Page-Completed.vue
index b90e5cf7..e2dca374 100644
--- a/frontend/src/components/Page-Completed.vue
+++ b/frontend/src/components/Page-Completed.vue
@@ -327,6 +327,7 @@ const clearFailed = () => {
 
   emits('deleteItem', 'completed', keys);
 }
+
 const setIcon = (item) => {
   if (item.status === 'finished' && item.is_live) {
     return 'fa-solid fa-globe';
diff --git a/frontend/src/components/Page-Downloading.vue b/frontend/src/components/Page-Downloading.vue
index ea6c1355..766293f9 100644
--- a/frontend/src/components/Page-Downloading.vue
+++ b/frontend/src/components/Page-Downloading.vue
@@ -53,10 +53,10 @@
               <div class="column is-half-mobile has-text-centered">
                 <span class="icon-text">
                   <span class="icon" :class="{ 'has-text-success': item.status == 'downloading' }">
-                    <font-awesome-icon
-                      :icon="item.status == 'downloading' ? 'fa-solid fa-download' : 'fa-solid fa-spinner fa-spin'" />
+                    <font-awesome-icon :icon="setIcon(item)" />
                   </span>
-                  <span>{{ capitalize(item.status) }}</span>
+                  <span v-if="item.status == 'downloading' && item.is_live">Streaming</span>
+                  <span v-else>{{ capitalize(item.status) }}</span>
                 </span>
               </div>
               <div class="column is-half-mobile has-text-centered">
@@ -157,6 +157,18 @@ const hasSelected = computed(() => selectedElms.value.length > 0)
 const hasQueuedItems = computed(() => Object.keys(props.queue)?.length > 0)
 const getTotal = computed(() => Object.keys(props.queue)?.length);
 
+const setIcon = (item) => {
+  if (item.status === 'downloading' && item.is_live) {
+    return 'fa-solid fa-globe';
+  }
+
+  if (item.status === 'downloading') {
+    return 'fa-solid fa-circle-check';
+  }
+
+  return 'fa-solid fa-spinner fa-spin';
+}
+
 const ETAPipe = value => {
   if (value === null || 0 === value) {
     return 'Live';