danvics/ytptube
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: replace notify with useNotification for error/success handling in composables

Browse source
This commit is contained in:
arabcoders 2026-02-20 23:27:54 +03:00
parent 633fc7d4d2
commit 764b837312
5 changed files with 25 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ui/app/composables/useConditions.ts
View file

@ -49,7 +49,6 @@ const throwInstead = ref(false);
/** /**
* Notification composable for showing success/error messages. * Notification composable for showing success/error messages.
*/ */
const notify = useNotification();
/** /**
* Sorts conditions by priority (descending - higher number first), then name (A-Z). * Sorts conditions by priority (descending - higher number first), then name (A-Z).
@ -102,7 +101,7 @@ const ensureSuccess = async (response: Response): Promise<void> => {
const handleError = (error: unknown): void => { const handleError = (error: unknown): void => {
const message = error instanceof Error ? error.message : 'Unexpected error occurred.'; const message = error instanceof Error ? error.message : 'Unexpected error occurred.';
lastError.value = message; lastError.value = message;
notify.error(message); useNotification().error(message);
}; };
/** /**
@ -212,7 +211,7 @@ const createCondition = async (
const created = await parse_api_response<Condition>(json); const created = await parse_api_response<Condition>(json);
updateConditions(created); updateConditions(created);
notify.success('Condition created.'); useNotification().success('Condition created.');
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -263,7 +262,7 @@ const updateCondition = async (
const updated = await parse_api_response<Condition>(json); const updated = await parse_api_response<Condition>(json);
updateConditions(updated); updateConditions(updated);
notify.success(`Condition '${updated.name}' updated.`); useNotification().success(`Condition '${updated.name}' updated.`);
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -314,7 +313,7 @@ const patchCondition = async (
const updated = await parse_api_response<Condition>(json); const updated = await parse_api_response<Condition>(json);
updateConditions(updated); updateConditions(updated);
notify.success(`Condition '${updated.name}' updated.`); useNotification().success(`Condition '${updated.name}' updated.`);
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -352,7 +351,7 @@ const deleteCondition = async (
await ensureSuccess(response); await ensureSuccess(response);
removeCondition(id); removeCondition(id);
notify.success('Condition deleted.'); useNotification().success('Condition deleted.');
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {

11
ui/app/composables/usePresets.ts
View file

@ -39,7 +39,6 @@ const throwInstead = ref(false);
/** /**
* Notification composable for showing success/error messages. * Notification composable for showing success/error messages.
*/ */
const notify = useNotification();
/** /**
* Sorts presets by priority (descending), then name (A-Z). * Sorts presets by priority (descending), then name (A-Z).
@ -92,7 +91,7 @@ const ensureSuccess = async (response: Response): Promise<void> => {
const handleError = (error: unknown): void => { const handleError = (error: unknown): void => {
const message = error instanceof Error ? error.message : 'Unexpected error occurred.'; const message = error instanceof Error ? error.message : 'Unexpected error occurred.';
lastError.value = message; lastError.value = message;
notify.error(message); useNotification().error(message);
}; };
/** /**
@ -199,7 +198,7 @@ const createPreset = async (
const created = await parse_api_response<Preset>(json); const created = await parse_api_response<Preset>(json);
updatePresets(created); updatePresets(created);
notify.success('Preset created.'); useNotification().success('Preset created.');
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -254,7 +253,7 @@ const updatePreset = async (
const updated = await parse_api_response<Preset>(json); const updated = await parse_api_response<Preset>(json);
updatePresets(updated); updatePresets(updated);
notify.success(`Preset '${updated.name}' updated.`); useNotification().success(`Preset '${updated.name}' updated.`);
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -309,7 +308,7 @@ const patchPreset = async (
const updated = await parse_api_response<Preset>(json); const updated = await parse_api_response<Preset>(json);
updatePresets(updated); updatePresets(updated);
notify.success(`Preset '${updated.name}' updated.`); useNotification().success(`Preset '${updated.name}' updated.`);
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -347,7 +346,7 @@ const deletePreset = async (
await ensureSuccess(response); await ensureSuccess(response);
removePreset(id); removePreset(id);
notify.success('Preset deleted.'); useNotification().success('Preset deleted.');
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {

11
ui/app/composables/useTaskDefinitions.ts
View file

@ -41,7 +41,6 @@ const throwInstead = ref(false);
/** /**
* Notification composable for showing success/error messages. * Notification composable for showing success/error messages.
*/ */
const notify = useNotification();
/** /**
* Sorts task definition summaries by priority (ascending), then name (A-Z). * Sorts task definition summaries by priority (ascending), then name (A-Z).
@ -83,7 +82,7 @@ const ensureSuccess = async (response: Response): Promise<void> => {
const handleError = (error: unknown): void => { const handleError = (error: unknown): void => {
const message = error instanceof Error ? error.message : 'Unexpected error occurred.'; const message = error instanceof Error ? error.message : 'Unexpected error occurred.';
lastError.value = message; lastError.value = message;
notify.error(message); useNotification().error(message);
}; };
/** /**
@ -194,7 +193,7 @@ const createDefinition = async (
updated_at: payload.updated_at, updated_at: payload.updated_at,
}); });
notify.success('Task definition created.'); useNotification().success('Task definition created.');
lastError.value = null; lastError.value = null;
return payload; return payload;
} catch (error) { } catch (error) {
@ -234,7 +233,7 @@ const updateDefinition = async (
updated_at: payload.updated_at, updated_at: payload.updated_at,
}); });
notify.success('Task definition updated.'); useNotification().success('Task definition updated.');
lastError.value = null; lastError.value = null;
return payload; return payload;
} catch (error) { } catch (error) {
@ -255,7 +254,7 @@ const deleteDefinition = async (id: number): Promise<boolean> => {
await ensureSuccess(response); await ensureSuccess(response);
removeSummary(id); removeSummary(id);
notify.success('Task definition deleted.'); useNotification().success('Task definition deleted.');
lastError.value = null; lastError.value = null;
return true; return true;
} catch (error) { } catch (error) {
@ -295,7 +294,7 @@ const toggleEnabled = async (
updated_at: payload.updated_at, updated_at: payload.updated_at,
}); });
notify.success(`Task definition ${enabled ? 'enabled' : 'disabled'}.`); useNotification().success(`Task definition ${enabled ? 'enabled' : 'disabled'}.`);
lastError.value = null; lastError.value = null;
return payload; return payload;
} catch (error) { } catch (error) {

19
ui/app/composables/useTasks.ts
View file

@ -48,7 +48,6 @@ const throwInstead = ref(false);
/** /**
* Notification composable for showing success/error messages. * Notification composable for showing success/error messages.
*/ */
const notify = useNotification();
/** /**
* Sorts tasks by name (A-Z). * Sorts tasks by name (A-Z).
@ -95,7 +94,7 @@ const ensureSuccess = async (response: Response): Promise<void> => {
const handleError = (error: unknown): void => { const handleError = (error: unknown): void => {
const message = error instanceof Error ? error.message : 'Unexpected error occurred.'; const message = error instanceof Error ? error.message : 'Unexpected error occurred.';
lastError.value = message; lastError.value = message;
notify.error(message); useNotification().error(message);
}; };
/** /**
@ -202,7 +201,7 @@ const createTask = async (
const created = await parse_api_response<Task | Array<Task>>(json); const created = await parse_api_response<Task | Array<Task>>(json);
if (Array.isArray(created)) { if (Array.isArray(created)) {
notify.success(`${created.length} tasks created.`); useNotification().success(`${created.length} tasks created.`);
created.forEach((t) => updateTasksList(t)); created.forEach((t) => updateTasksList(t));
lastError.value = null; lastError.value = null;
@ -214,7 +213,7 @@ const createTask = async (
} }
updateTasksList(created); updateTasksList(created);
notify.success('Task created.'); useNotification().success('Task created.');
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -264,7 +263,7 @@ const updateTask = async (
const updated = await parse_api_response<Task>(json); const updated = await parse_api_response<Task>(json);
updateTasksList(updated); updateTasksList(updated);
notify.success(`Task '${updated.name}' updated.`); useNotification().success(`Task '${updated.name}' updated.`);
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -311,7 +310,7 @@ const patchTask = async (
const updated = await parse_api_response<Task>(json); const updated = await parse_api_response<Task>(json);
updateTasksList(updated); updateTasksList(updated);
notify.success(`Task '${updated.name}' updated.`); useNotification().success(`Task '${updated.name}' updated.`);
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -349,7 +348,7 @@ const deleteTask = async (
await ensureSuccess(response); await ensureSuccess(response);
removeTask(id); removeTask(id);
notify.success('Task deleted.'); useNotification().success('Task deleted.');
lastError.value = null; lastError.value = null;
if (callback) { if (callback) {
@ -408,7 +407,7 @@ const markTaskItems = async (id: number): Promise<string | null> => {
const json = await response.json(); const json = await response.json();
const message = json.message || 'All items marked as downloaded.'; const message = json.message || 'All items marked as downloaded.';
notify.success(message); useNotification().success(message);
lastError.value = null; lastError.value = null;
return message; return message;
} catch (error) { } catch (error) {
@ -431,7 +430,7 @@ const unmarkTaskItems = async (id: number): Promise<string | null> => {
const json = await response.json(); const json = await response.json();
const message = json.message || 'All items removed from archive.'; const message = json.message || 'All items removed from archive.';
notify.success(message); useNotification().success(message);
lastError.value = null; lastError.value = null;
return message; return message;
} catch (error) { } catch (error) {
@ -454,7 +453,7 @@ const generateTaskMetadata = async (id: number): Promise<TaskMetadataResponse |
const json = await response.json(); const json = await response.json();
const metadata = await parse_api_response<TaskMetadataResponse>(json); const metadata = await parse_api_response<TaskMetadataResponse>(json);
notify.success('Metadata generation completed.'); useNotification().success('Metadata generation completed.');
lastError.value = null; lastError.value = null;
return metadata; return metadata;
} catch (error) { } catch (error) {

1
ui/tests/setup.ts
View file

@ -17,6 +17,7 @@ globalThis.requestAnimationFrame = window.requestAnimationFrame
globalThis.cancelAnimationFrame = window.cancelAnimationFrame globalThis.cancelAnimationFrame = window.cancelAnimationFrame
globalThis.localStorage = window.localStorage globalThis.localStorage = window.localStorage
globalThis.sessionStorage = window.sessionStorage globalThis.sessionStorage = window.sessionStorage
globalThis.Storage = window.Storage
if (!globalThis.crypto) { if (!globalThis.crypto) {
globalThis.crypto = window.crypto globalThis.crypto = window.crypto