From 9536e025aa35b582243d4daf976b7e0e39190923 Mon Sep 17 00:00:00 2001 From: arabcoders Date: Sun, 6 Jul 2025 19:52:49 +0300 Subject: [PATCH 1/2] correctly upload artifacts --- .github/workflows/native-build.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/native-build.yml b/.github/workflows/native-build.yml index 75fd02c8..3b576497 100644 --- a/.github/workflows/native-build.yml +++ b/.github/workflows/native-build.yml @@ -6,6 +6,9 @@ on: tag: required: true description: "Ref to build from (e.g. v1.0.0)" + push: + tags: + - "v*" env: PYTHON_VERSION: 3.11 @@ -101,7 +104,7 @@ jobs: path: dist/* - name: Upload to GitHub Release - if: startsWith(github.ref, 'refs/tags/') + if: startsWith(github.event.inputs.tag, 'v') uses: softprops/action-gh-release@v2 with: tag_name: ${{ github.event.inputs.tag }} From 354a7b3ed04b5c226fdb5faa0b618da4bd669884 Mon Sep 17 00:00:00 2001 From: arabcoders Date: Sun, 6 Jul 2025 20:03:31 +0300 Subject: [PATCH 2/2] followup fix for webview builds --- .github/workflows/native-build.yml | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/.github/workflows/native-build.yml b/.github/workflows/native-build.yml index 3b576497..ec334e7d 100644 --- a/.github/workflows/native-build.yml +++ b/.github/workflows/native-build.yml @@ -10,26 +10,28 @@ on: tags: - "v*" -env: - PYTHON_VERSION: 3.11 - PNPM_VERSION: 10 - NODE_VERSION: 20 - jobs: build: - permissions: - packages: write - contents: write + runs-on: ${{ matrix.os }} strategy: matrix: os: [ubuntu-latest, windows-latest, macos-latest] - runs-on: ${{ matrix.os }} + + permissions: + packages: write + contents: write + + env: + PYTHON_VERSION: 3.11 + PNPM_VERSION: 10 + NODE_VERSION: 20 + TAG_NAME: ${{ github.event.inputs.tag || github.ref_name }} steps: - name: Checkout source repo uses: actions/checkout@v4 with: - ref: ${{ github.event.inputs.tag }} + ref: ${{ env.TAG_NAME }} - name: Cache Chocolatey packages if: matrix.os == 'windows-latest' @@ -100,14 +102,14 @@ jobs: - name: Upload artifact uses: actions/upload-artifact@v4 with: - name: app-${{ matrix.os }}-${{ github.event.inputs.tag }} + name: app-${{ matrix.os }}-${{ env.TAG_NAME }} path: dist/* - name: Upload to GitHub Release - if: startsWith(github.event.inputs.tag, 'v') + if: startsWith(env.TAG_NAME, 'v') uses: softprops/action-gh-release@v2 with: - tag_name: ${{ github.event.inputs.tag }} + tag_name: ${{ env.TAG_NAME }} files: dist/* env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}