Compare commits

...

4 commits

Author SHA1 Message Date
Jesse Bannon
577afba4ce better messages 2025-06-06 10:05:39 -07:00
Jesse Bannon
23a0b3d434 Merge branch 'master' into j/airplane/default-verbose 2025-06-06 09:51:29 -07:00
Jesse Bannon
64b62b5881 better messaging 2024-11-23 10:40:51 -08:00
Jesse Bannon
7dc0b45ce5 [BACKEND] More informative info logs 2024-11-23 10:06:33 -08:00
3 changed files with 26 additions and 10 deletions

View file

@ -17,7 +17,7 @@ from yt_dlp.utils import RejectedVideoReached
from ytdl_sub.thread.log_entries_downloaded_listener import LogEntriesDownloadedListener
from ytdl_sub.utils.exceptions import FileNotDownloadedException
from ytdl_sub.utils.logger import Logger
from ytdl_sub.utils.logger import Logger, LoggerLevels
class YTDLP:
@ -123,10 +123,17 @@ class YTDLP:
del copied_ytdl_options_overrides["download_archive"]
if num_tries < cls._EXTRACT_ENTRY_NUM_RETRIES:
cls.logger.debug(
"Failed to download entry. Retrying %d / %d",
maybe_inform_verbose = ""
if Logger.get_log_level().level < LoggerLevels.VERBOSE.level:
maybe_inform_verbose = (
". Consider inspecting the yt-dlp logs using `--log-level verbose` to "
"see the issue."
)
cls.logger.info(
"Failed to download entry. Retrying %d / %d%s",
num_tries,
cls._EXTRACT_ENTRY_NUM_RETRIES,
maybe_inform_verbose
)
# Still return if the media file downloaded (thumbnail could be missing)
@ -222,14 +229,14 @@ class YTDLP:
):
cls.extract_info(ytdl_options_overrides=ytdl_options_overrides, **kwargs)
except RejectedVideoReached:
cls.logger.debug(
"RejectedVideoReached, stopping additional downloads "
"(Can be disable by setting `date_range.breaking` to False)."
cls.logger.info(
"RejectedVideoReached, stopping additional downloads. "
"Can be disable by setting `date_range.breaks` to False."
)
except ExistingVideoReached:
cls.logger.debug(
cls.logger.info(
"ExistingVideoReached, stopping additional downloads. "
"(Can be disable by setting `ytdl_options.break_on_existing` to False)."
"Can be disable by setting `ytdl_options.break_on_existing` to False."
)
except MaxDownloadsReached:
cls.logger.info("MaxDownloadsReached, stopping additional downloads.")
@ -247,7 +254,7 @@ class YTDLP:
if uploader_id in entry_ids or not (uploader_url := entry_dict.get("uploader_url")):
continue
cls.logger.debug("Attempting to get parent metadata from URL %s", uploader_url)
cls.logger.info("Attempting to get parent metadata from URL %s", uploader_url)
parent_dict: Optional[Dict] = None
try:
parent_dict = cls.extract_info(

View file

@ -198,7 +198,7 @@ class SubtitlesPlugin(Plugin[SubtitleOptions]):
"""
requested_subtitles = entry.get(v.requested_subtitles, expected_type=dict)
if not requested_subtitles:
logger.debug("subtitles not found for %s", entry.title)
logger.info("Subtitles not found for %s", entry.title)
return None
file_metadata: Optional[FileMetadata] = None

View file

@ -125,6 +125,15 @@ class Logger:
"""
cls._LOGGER_LEVEL = LoggerLevels.from_str(name=log_level_name)
@classmethod
def get_log_level(cls) -> LoggerLevel:
"""
Returns
-------
Application's log level
"""
return cls._LOGGER_LEVEL
@classmethod
def _get_formatter(cls) -> logging.Formatter:
"""