Commit graph

54 commits

Author SHA1 Message Date
Jesse Bannon
3eb838eb40
[DOCKER] Set default workspace separately for GUI image (#1328)
Another attempt to fix some broken cron setups
2025-09-01 11:26:36 -07:00
Jesse Bannon
c2afe05c11
[DOCKER] Fix & issue in cron (#1325)
Fixes the following issue in some people's cron runs:
```
/bin/sh: 4: /config/.cron_wrapper: Syntax error: "&" unexpected
```
2025-08-31 18:59:59 -07:00
Ross Patterson
283ccc8608
fix(docker): Default config available in WORKDIR (#1303)
Adds better support to run commands via `docker exec ...` by setting the working directory to be ytdl-sub's working directory.

Thanks @rpatterson for the contribution 😊
2025-08-27 20:17:57 -07:00
Ross Patterson
26922e1787
[DOCKER] Missing cron script stderr output (#1307) 2025-08-27 09:02:45 -07:00
Ross Patterson
8eb5215a0c
[DOCS]: Large file long cross-device renames (#1301)
From [Discord discussion](https://discord.com/channels/994270357957648404/994270357957648408/1408832178623741993).
2025-08-24 07:55:16 -07:00
Ross Patterson
e1f81e5274
[DOCS] Add Architecture section and Quick Start (#1287)
* docs(config): Clarify preset ordering priority

Refs #1276

* docs(architecture): WIP Narrative how it works

Much of this is repetition of the reference docs and some of the changes here should
also be applied here. The goal is to repeat here the parts of the reference docs that
may hang up a user when reading "Getting Started" without sending them off to get lost
in the weeds of the reference docs.

Note that this references a `Quick Start` document which is just an empty placeholder
and is to be written in a subsequent change.

Fixes #1279

* docs(terms): Glossary redundant with architecture

Now that the introduction includes an architectural overview, that section introduces
new users to necessary concepts and associated terminology and makes the terminology
section redundant in that part of the docs.

* docs(quick): Add a rote quick start guide

This is what I came up with when I tried to write instructions requiring as little
understanding as possible. Doing so really did reinforce my impression that this just
shouldn't be done, that significant understanding is required for *any* use of ytdl-sub
and even offering a quick start may be irresponsible. I'm still on the fence, thoughts?

That said, I also think I got some good explanations out of this and a better
understanding of what the next bits of the Getting Started should be. This Quick Start
is currently redundant with other parts of the Getting Started pages. I suspect that
I'll end up repeating and/or reorganizing parts of this Quick Start into the next bits
of the Getting Started. To that end I might argue that this change is a WIP and that
merging should wait. But I could also argue that this is an incremental improvement and
can be merged before that other work. Your call.

* docs(start): Various rST/Sphinx markup issues
2025-08-19 00:38:39 -07:00
Jesse Bannon
faf9fd8a10
[DOCKER] Update yt-dlp, fix phantomjs (#1240)
Bumps [yt-dlp[default]](https://github.com/yt-dlp/yt-dlp) from 2025.5.22 to 2025.6.9.
- [Release notes](https://github.com/yt-dlp/yt-dlp/releases)
- [Changelog](https://github.com/yt-dlp/yt-dlp/blob/master/Changelog.md)
- [Commits](https://github.com/yt-dlp/yt-dlp/compare/2025.05.22...2025.06.09)

Also fixes phantomjs in docker builds
2025-06-11 23:25:56 -07:00
Jesse Bannon
e27a7c5495
[DOCKER] Fix various cron issues (#1204)
Closes
- https://github.com/jmbannon/ytdl-sub/issues/1200
  - Runs in the background now
- https://github.com/jmbannon/ytdl-sub/issues/1201
  - Was not running as user `abc`, now it is
- https://github.com/jmbannon/ytdl-sub/issues/1202
  - Due to reading stdout and tail of hidden log file. Should only tail from hidden log file now

Will leave crontab as-is if no CRON_SCHEDULE is specified
2025-04-02 21:22:12 -07:00
Jesse Bannon
1264f0c656
[DOCKER] Update Ubuntu-based images (#1185)
- Update Ubuntu-based images to use Python 3.12
- Move hidden files from GUI image's main dir
- Update github workflows to use python 3.12
- Update fixtures
- Minor doc fixes
2025-03-15 21:58:51 -07:00
Jesse Bannon
51c134a036
[DOCKER] Simplify cron (#1184)
Drastically simplifies setting up cron within ytdl-sub. Below is the documentation which is available in readthedocs, and a section on how to migrate from the old way to this.

## New Cron Documentation
Cron is preconfigured in every ytdl-sub docker container. Enable by adding the following ENV variables to your docker setup.

```
services:
  ytdl-sub:
    environment:
    - CRON_SCHEDULE="0 */6 * * *"
    - CRON_RUN_ON_START=false
```  
- CRON_SCHEDULE follows the standard [cron scheduling syntax](https://crontab.guru/#0_*/6_*_*_*). The above value will run the script once every 6 hours.
- CRON_RUN_ON_START toggles whether to run your cron script on container start.

The cron script will reside in the main directory with the file name `cron`. Cron logs should show when viewing the Docker logs.

## Migrating Existing Cron Setup
Containers' cron files will remain intact until you add the `CRON_SCHEDULE` variable. Once you add that with your preferred schedule, it will write that value to /config/crontabs/abc and create a new file `cron` within your working directory. Simply copy everything from your existing `run_cron` script into `cron`.

If you have the ENV variable `DOCKER_MODS` in your docker-compose, remove it. It is now included by default. Not removing this will prevent cron logs from showing in your docker container logs.
2025-03-15 15:47:03 -07:00
Jesse Bannon
2b1e74bc8e
[DOCKER] Export SSL certs (#1163)
Fixes a common issue with downloading channel thumbnails and fanart.
2025-01-26 21:07:54 -08:00
Joey Babcock
fa13ba30cf
[DOCS] Fixing 404 link to presets (#1008) 2024-06-22 23:30:21 -07:00
Jesse Bannon
248e9a15a6
[DOCS] Various doc cleanups (#928) 2024-02-17 08:53:06 -08:00
Jesse Bannon
544af2207b
[FEATURE] Add output_options.keep_max_files to limit number of downloads per subscription (#820)
Adds a new mechanism to limit subscriptions' number of videos to an explicit number (only supported date ranges prior to this).

Example usage:
```
output_options:
  keep_max_files: 10
```
will only keep 10 videos at max.

In addition:
- `keep_max_files` is bundled into the `Only Recent` preset and can be used via setting the `only_recent_max_files` override variable (see examples or README for usage).
- Changed the `date_range` variable name to `only_recent_date_range` for more clarity.  Usage of `date_range` will continue to work.
2023-11-17 09:01:21 -08:00
Jesse Bannon
c7fce5dbdd
[BACKEND] Upgrade yt-dlp to 2023.11.16 (#817) 2023-11-15 16:58:29 -08:00
Jesse Bannon
19eee28f4a
[DOCKER] New default config/subscription in Docker (#798)
The default subscription file in the docker container now matches the one in the repo's README
2023-11-03 17:14:38 -07:00
Jesse Bannon
d64d863175
[DOCKER][BUGFIX] Upgrade base code-server image to fix ytdl-sub-gui image (#797)
As of ~2 days ago, the ytdl-sub-gui image broke from using an older version of the `code-server` image. After this push, it should be fixed + working as intended
2023-11-03 14:04:12 -07:00
Jesse Bannon
c149957b04
[DOCKER] Remove default gui settings (#776) 2023-10-22 14:35:52 -07:00
Jesse Bannon
ee09e85a33
[DOCKER] Move cont-init.d files (#775) 2023-10-22 13:02:06 -07:00
Jesse Bannon
c932583165
[DOCKER] GUI Docker image using Code-Server (#774)
Adds a new docker image: `ytdl-sub-gui:latest` which is ytdl-sub packaged with VS-Code via LinuxServer.io's code-server image: https://hub.docker.com/r/linuxserver/code-server

Proper documentation will be added later
2023-10-22 01:17:09 -07:00
Jesse Bannon
a9e6a80111
[REFACTOR] Support simple download (#671)
* [REFACTOR] Support simple `download`

* fix test

* asdfas
2023-07-26 09:00:00 -07:00
Jesse Bannon
598b1da8a4
[REFACTOR] Purge download_strategy from configs + tests (#670) 2023-07-25 20:26:04 -07:00
Jesse Bannon
3404ed9cc5
[DOCKER][BUGFIX] Use PUID/PGID to chown /config dir (#644)
* [DOCKER][BUGFIX] Use `PUID`/`PGID` to chown `/config` dir

* lint
2023-07-24 10:12:20 -07:00
Jesse Bannon
d8a64ca82c
[DOCKER] Use official phantomjs package, fix system pip install (#658) 2023-07-24 09:36:38 -07:00
Jesse Bannon
f0847cee63
Revert "[BACKEND] Update yt-dlp to latest commit (#655)" (#656)
This reverts commit 3cbd07c9a4.
2023-07-18 13:17:19 -07:00
Jesse Bannon
3cbd07c9a4
[BACKEND] Update yt-dlp to latest commit (#655)
* [BACKEND] Update yt-dlp to latest commit

* git for installing commits
2023-07-18 10:48:16 -07:00
Jesse Bannon
8f4cc5df39
[DOCKER] Fix ubuntu docker build (#589) 2023-04-12 09:13:15 -07:00
Jesse Bannon
c77015353d
[DOCKER] Install aria2 in container (#577) 2023-04-02 22:10:51 -07:00
Jesse Bannon
84cd611f89
[BUGFIX] File name too long with -thumb.jpg, upgrade docker alpine image (#560) 2023-03-24 11:15:54 -07:00
Jesse Bannon
52fdc9a213
[DOCKER] Add ubuntu docker image for device passthrough (#545) 2023-03-15 14:10:32 -07:00
Jesse Bannon
5d57eb14b8
[DOCS] Universal cron mod for docker (#495) 2023-03-02 11:24:04 -08:00
Jesse Bannon
c153185b33
[DOCKER] Relax ffmpeg version requirement (#465) 2023-02-22 09:53:24 -08:00
Jesse Bannon
f713d720e4
[DOCKER] Upgrade ffmpeg, add phantomjs (#448)
* [DOCKER] Upgrade ffmpeg, add phantomjs

* only install phantomjs for x86

* lint
2023-02-20 09:36:41 -08:00
Jesse Bannon
031e17307a
[BACKEND] Check ffmpeg + ytdl-sub versions in Dockerfile to ensure successful installation (#359) 2022-11-24 19:19:42 -08:00
Jesse Bannon
06a9ed2974
[DOCKER][BUGFIX] Fix ffmpeg (#358) 2022-11-24 10:29:38 -08:00
Jesse Bannon
ead5620c5c
[FEATURE] Add mp3 id3v2.4 multi-tag support (#356)
* [FEATURE] Add mp3 id3v2.4 multi-tag support

* docs

* fix new docker issue

* update fixture
2022-11-24 00:56:23 -08:00
Jesse Bannon
21eb36774b
[DOCKER] Use alpine-3.16, update ffmpeg (attempt 2) (#332)
* Revert "Revert "[DOCKER] Use alpine-3.16, update ffmpeg (#330)" (#331)"

This reverts commit 1fa3aa5967.

* update mediafile

* lots of changes

* remove setup py
2022-11-15 13:34:47 -08:00
Jesse Bannon
1fa3aa5967
Revert "[DOCKER] Use alpine-3.16, update ffmpeg (#330)" (#331)
This reverts commit 7b43aa904b.
2022-11-15 11:29:49 -08:00
Jesse Bannon
7b43aa904b
[DOCKER] Use alpine-3.16, update ffmpeg (#330) 2022-11-15 11:16:45 -08:00
Jesse Bannon
d49cd95c08
Revert "[BACKEND] Use latest ffmpeg (#327)" (#329)
This reverts commit 52b0130888.
2022-11-15 09:14:19 -08:00
Jesse Bannon
52b0130888
[BACKEND] Use latest ffmpeg (#327) 2022-11-15 09:00:09 -08:00
Jesse Bannon
726da5b6be
[BACKEND] Update docker container to have latest examples (#319) 2022-11-13 11:24:59 -08:00
Jesse Bannon
a1149bd655
[DOCKER] Add nano to container (#274) 2022-10-07 11:33:07 -07:00
Maka0
cb31156b42
Added QEMU/buildx to Github Actions to build multiarch containers (#84)
* Updated docker to use buildx Buildkit

* Updated github actions to include QEMU/buildx to build multiarch containers

* Removed packages after build is done

* Updated documentation to set the correct default thumbnail file name

* Parallel jobs (#1)

Implemented parallel docker builds on Github Actions

* Updated default config file in Docker container

* Replaced Pillow with ffmpeg for thumbnail converting (and updated documentation to change the default thumbnail to -thumb.jpg) (#2)

* Swapped Pillow for ffmpeg for thumbnail conversion
* Further changed default thumbname to include "-thumb" (Kodi needs this to pick up the thumbnail image)
* Added ffmpeg bitexact for reproducability

* Removed extra packages needed for Pillow

* Updated ref check (#3)

* Fixed formatting on if statement for deploy job

Co-authored-by: Maka0 <bas@oddens.net>
2022-07-04 01:17:04 -07:00
Jesse Bannon
ee6706334f
ytdl_options defaults for each download strategy (#72)
* `ytdl_options` defaults for each download strategy

* fix docker, fix defaults getting added, add debugger test

* test playlist as well

* fix with hack

* fix full channel test

* existing
2022-06-14 00:03:01 -07:00
Jesse Bannon
a79fcaa25b
Use URLs instead of IDs for sources (#70)
* youtube video url

* WIP, channel /user/ and /c/ should be valid

* unit tests passing

* soundcloud artist url

* soundcloud username

* break configs with name change

* Update all yamls with urls

* update all docs

* more negative url tests
2022-06-05 16:19:08 -07:00
Jesse Bannon
67104bca43
Move docker install into main readme (#61) 2022-06-02 22:34:09 -07:00
Jesse Bannon
1d5992f93a
Remove unused apk packages (#56) 2022-05-30 17:24:14 -07:00
Jesse Bannon
4f64089e22
ffmpeg install in docker (#55) 2022-05-30 13:02:23 -07:00
Jesse Bannon
8b336e6fb0
Always convert thumbnails to jpg (#51)
* always use jpg

* fix unit test

* update readme and configs
2022-05-30 09:59:25 -07:00