From df21941ec77ff581a4415dfbb6da0158daf12bb6 Mon Sep 17 00:00:00 2001 From: Jesse Bannon Date: Mon, 24 Jul 2023 17:50:38 -0700 Subject: [PATCH] better dict instantiate --- src/ytdl_sub/plugins/music_tags.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/ytdl_sub/plugins/music_tags.py b/src/ytdl_sub/plugins/music_tags.py index e8698dc9..d5928567 100644 --- a/src/ytdl_sub/plugins/music_tags.py +++ b/src/ytdl_sub/plugins/music_tags.py @@ -81,21 +81,16 @@ class MusicTagsOptions(OptionsDictValidator): def __init__(self, name, value): super().__init__(name, value) - old_tags_validator = self._validate_key( - key="tags", validator=MusicTagsValidator, default={} - ) self._embed_thumbnail = self._validate_key_if_present( key="embed_thumbnail", validator=BoolValidator ) - self._is_old_format = old_tags_validator._dict or self._embed_thumbnail is not None new_tags_dict: Dict[str, Any] = copy.deepcopy(value) - new_tags_dict.pop("tags", None) + old_tags_dict = new_tags_dict.pop("tags", {}) new_tags_dict.pop("embed_thumbnail", None) - self._tags = MusicTagsValidator( - name=name, value=dict(old_tags_validator._dict, **new_tags_dict) - ) + self._is_old_format = len(old_tags_dict) > 0 or self._embed_thumbnail is not None + self._tags = MusicTagsValidator(name=name, value=dict(old_tags_dict, **new_tags_dict)) @property def tags(self) -> MusicTagsValidator: