danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[DEV] Do not hash .info.json files in expected download summaries (#752)

Browse source
This commit is contained in:
Jesse Bannon 2023-10-03 13:22:19 -07:00
parent dd55b2bc56
commit d911200e2b
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/expected_download.py
View file

@ -28,6 +28,12 @@ def _get_files_in_directory(relative_directory: Path | str) -> List[Path]:
return relative_file_paths return relative_file_paths
def _get_file_md5_hash(full_file_path: str | Path) -> str:
if str(full_file_path).endswith(".info.json"):
return "INFO_JSON"
return get_file_md5_hash(full_file_path=full_file_path)
@dataclass @dataclass
class ExpectedDownloadFile: class ExpectedDownloadFile:
path: Path path: Path
@ -79,7 +85,7 @@ class ExpectedDownloads:
if IS_WINDOWS or path in ignore_md5_hashes_for or path.endswith(".info.json"): if IS_WINDOWS or path in ignore_md5_hashes_for or path.endswith(".info.json"):
continue continue
md5_hash = get_file_md5_hash(full_file_path=full_path) md5_hash = _get_file_md5_hash(full_file_path=full_path)
assert md5_hash in expected_download.md5, ( assert md5_hash in expected_download.md5, (
f"MD5 hash for {str(expected_download.path)} does not match: " f"MD5 hash for {str(expected_download.path)} does not match: "
f"{md5_hash} != {expected_download.md5}" f"{md5_hash} != {expected_download.md5}"
@ -103,7 +109,7 @@ class ExpectedDownloads:
def from_directory(cls, directory_path: str | Path) -> "ExpectedDownloads": def from_directory(cls, directory_path: str | Path) -> "ExpectedDownloads":
relative_file_paths = _get_files_in_directory(relative_directory=directory_path) relative_file_paths = _get_files_in_directory(relative_directory=directory_path)
expected_downloads_dict = { expected_downloads_dict = {
str(file_path): get_file_md5_hash(full_file_path=Path(directory_path) / file_path) str(file_path): _get_file_md5_hash(full_file_path=Path(directory_path) / file_path)
for file_path in relative_file_paths for file_path in relative_file_paths
} }
return cls.from_dict(expected_downloads_dict) return cls.from_dict(expected_downloads_dict)