danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[BUGFIX] Create dir before converting channel thumbnails (#381)

Browse source
This commit is contained in:
Jesse Bannon 2022-11-30 15:06:56 -08:00 committed by GitHub
parent 96e741c71d
commit c8c66b5660
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/ytdl_sub/utils/thumbnail.py
View file

@ -46,7 +46,7 @@ def convert_download_thumbnail(entry: Entry, error_if_not_found: bool = True) ->
FileHandler.delete(download_thumbnail_path) FileHandler.delete(download_thumbnail_path)
@retry(times=5, exceptions=(Exception,)) @retry(times=3, exceptions=(Exception,))
def convert_url_thumbnail(thumbnail_url: str, output_thumbnail_path: str) -> Optional[bool]: def convert_url_thumbnail(thumbnail_url: str, output_thumbnail_path: str) -> Optional[bool]:
""" """
Downloads and converts a thumbnail from a url into a jpg Downloads and converts a thumbnail from a url into a jpg
@ -63,10 +63,11 @@ def convert_url_thumbnail(thumbnail_url: str, output_thumbnail_path: str) -> Opt
True to indicate it converted the thumbnail from url. None if the retry failed. True to indicate it converted the thumbnail from url. None if the retry failed.
""" """
# timeout after 8 seconds # timeout after 8 seconds
with urlopen(thumbnail_url, timeout=8.0) as file: with urlopen(thumbnail_url, timeout=1.0) as file:
with tempfile.NamedTemporaryFile() as thumbnail: with tempfile.NamedTemporaryFile() as thumbnail:
thumbnail.write(file.read()) thumbnail.write(file.read())
FFMPEG.run(["-bitexact", "-i", thumbnail.name, output_thumbnail_path, "-bitexact"]) os.makedirs(os.path.dirname(output_thumbnail_path), exist_ok=True)
FFMPEG.run(["-bitexact", "-i", thumbnail.name, output_thumbnail_path])
return True return True