danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test passing, is reproducible

Browse source
This commit is contained in:
jbannon 2022-06-24 16:10:13 +00:00
parent fd88d066f3
commit bb952dfec0
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ytdl_sub/downloaders/youtube/merge_playlist.py
View file

@ -94,7 +94,7 @@ class YoutubeMergePlaylistDownloader(
"playlistreverse": True, "playlistreverse": True,
"postprocessors": [ "postprocessors": [
{ {
"key": "FFmpegVideoRemuxer", "key": "FFmpegVideoConvertor",
"when": "post_process", "when": "post_process",
"preferedformat": "mkv", "preferedformat": "mkv",
}, },

3
src/ytdl_sub/utils/ffmpeg.py
View file

@ -1,8 +1,6 @@
import shutil import shutil
import subprocess import subprocess
import tempfile import tempfile
import termios
from typing import Dict
from typing import List from typing import List
from typing import Optional from typing import Optional
@ -123,6 +121,7 @@ def add_ffmpeg_metadata(
metadata_file.name, metadata_file.name,
"-map_metadata", "-map_metadata",
"1", "1",
"-bitexact", # for reproducibility
"-codec", "-codec",
"copy", "copy",
output_file_path, output_file_path,

5
tests/e2e/youtube/test_merge_playlist.py
View file

@ -36,7 +36,8 @@ def subscription_dict(output_directory, subscription_name):
"output_options": {"output_directory": output_directory}, "output_options": {"output_directory": output_directory},
# download the worst format so it is fast # download the worst format so it is fast
"ytdl_options": { "ytdl_options": {
"format": "best", "format": "best[height<=480]",
"postprocessor_args": {"ffmpeg": ["-bitexact"]}, # Must add this for reproducibility
}, },
"overrides": {"artist": "JMC"}, "overrides": {"artist": "JMC"},
} }
@ -65,7 +66,7 @@ def expected_playlist_download():
return ExpectedDownload( return ExpectedDownload(
expected_md5_file_hashes={ expected_md5_file_hashes={
Path("JMC - Jesse's Minecraft Server.jpg"): "348e3007fc590d0b1e2f6682501b0b5f", Path("JMC - Jesse's Minecraft Server.jpg"): "348e3007fc590d0b1e2f6682501b0b5f",
Path("JMC - Jesse's Minecraft Server.mkv"): "a568758afb79f42c7de0af027a4bf62d", Path("JMC - Jesse's Minecraft Server.mkv"): "6053c47a8690519b0a33c13fa4b01ac0",
Path("JMC - Jesse's Minecraft Server.nfo"): "10df5dcdb65ab18ecf21b3503c77e48b", Path("JMC - Jesse's Minecraft Server.nfo"): "10df5dcdb65ab18ecf21b3503c77e48b",
} }
) )