From 9e7ac3777d11526a794c91ea851c5197cbad583a Mon Sep 17 00:00:00 2001 From: Ross Patterson Date: Tue, 2 Sep 2025 02:48:43 -0700 Subject: [PATCH] fix(docker): Unintentional unattended dry runs [PR feedback](https://github.com/jmbannon/ytdl-sub/pull/1321#discussion_r2315215600) prompted me to reconsider having a default command at all. We should assume, unfortunately, that many new users will just skim the docs enough to enable the image's cron integration but not actually incrementally test their configuration. In those cases, they'd end up sending dry-run non-download requests for all their subscriptions every 6 hours for no good reason. There's just no way to provide a default command that isn't also providing a footgun. --- docker/root/defaults/cron | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/docker/root/defaults/cron b/docker/root/defaults/cron index 358a981f..0deb3568 100644 --- a/docker/root/defaults/cron +++ b/docker/root/defaults/cron @@ -4,9 +4,12 @@ # default `./config.yaml` and `./subscriptions.yaml`, so you don't need to use the # `--config` CLI option or pass a `SUBPATH` to the `$ ytdl-sub sub` sub-command. # -# To prevent users accidentally triggering throttles or bans or downloading before -# testing their configuration, these default options only simulate a few -# downloads. Remove the `--dry-run` and `-o ...` CLI options when you've tested your -# configuration and you're ready to download entries unattended: - -ytdl-sub --dry-run sub -o '--ytdl_options.max_downloads 3' +# Test your configuration and subscriptions carefully before automating downloads to +# prevent triggering throttles or bans: +# +# https://ytdl-sub.readthedocs.io/en/latest/guides/getting_started/downloading.html +# +# Once you've tested your configuration and you're ready to download entries unattended, +# remove the next line and un-comment the following line: +echo "WARNING: Read /config/ytdl-sub-configs/cron and modify to automate downloads." +# ytdl-sub sub