danvics/ytdl-sub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[BUGFIX] Find ext when info.json wrong (#1045)

Browse source 
Fixes a bug where YouTube's info.json sometimes say ext: mkv but download is not mkv. Thanks @0xBLERKO for the contribution!
This commit is contained in:
0xBLERKO 2024-09-08 15:19:05 -05:00 committed by GitHub
parent c44b98505e
commit 941fa43bb9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/ytdl_sub/entries/entry.py
View file

@ -109,12 +109,15 @@ class Entry(BaseEntry, Scriptable):
@property
def ext(self) -> str:
"""
With ffmpeg installed, yt-dlp will sometimes merge the file into an mkv file.
This is not reflected in the entry. See if the mkv file exists and return "mkv" if so,
otherwise, return the original extension.
With ffmpeg installed, yt-dlp will sometimes merge the file into an mkv file or
info.json states mkv when it is not. This is not reflected in the entry. See
if the expected file exists and return it if so, otherwise, search for present ext.
Fall back to expected ext but this will fail.
"""
ext = self.try_get(v.ext, str) or self._kwargs[v.ext.metadata_key]
for possible_ext in [ext, "mkv"]:
for possible_ext in [
ext,
] + list(VIDEO_CODEC_EXTS):
file_name = self.base_filename(ext=possible_ext)
file_path = str(Path(self.working_directory()) / file_name)
if os.path.isfile(file_path):